Commit e221a1da authored by Alex Elder's avatar Alex Elder Committed by Andy Gross

soc: qcom: smem: return proper type for cached entry functions

What phdr_to_last_uncached_entry() returns is the address of the
start of the free space following all allocated uncached entries.
It really doesn't refer to an actual (initialized) private entry
structure.   Similarly phdr_to_last_cached_entry() returns the
address of the end of free space, preceding the last allocated cache
entry.  Change both functions' return type to be pointer to void
to reflect this.

Meanwhile, phdr_to_first_cached_entry() really *does* point to a
private entry structure, so change its return type to reflect
this fact.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
parent 70708749
...@@ -280,7 +280,7 @@ struct qcom_smem { ...@@ -280,7 +280,7 @@ struct qcom_smem {
struct smem_region regions[0]; struct smem_region regions[0];
}; };
static struct smem_private_entry * static void *
phdr_to_last_uncached_entry(struct smem_partition_header *phdr) phdr_to_last_uncached_entry(struct smem_partition_header *phdr)
{ {
void *p = phdr; void *p = phdr;
...@@ -288,7 +288,8 @@ phdr_to_last_uncached_entry(struct smem_partition_header *phdr) ...@@ -288,7 +288,8 @@ phdr_to_last_uncached_entry(struct smem_partition_header *phdr)
return p + le32_to_cpu(phdr->offset_free_uncached); return p + le32_to_cpu(phdr->offset_free_uncached);
} }
static void *phdr_to_first_cached_entry(struct smem_partition_header *phdr, static struct smem_private_entry *
phdr_to_first_cached_entry(struct smem_partition_header *phdr,
size_t cacheline) size_t cacheline)
{ {
void *p = phdr; void *p = phdr;
...@@ -297,7 +298,8 @@ static void *phdr_to_first_cached_entry(struct smem_partition_header *phdr, ...@@ -297,7 +298,8 @@ static void *phdr_to_first_cached_entry(struct smem_partition_header *phdr,
return p + le32_to_cpu(phdr->size) - ALIGN(sizeof(*e), cacheline); return p + le32_to_cpu(phdr->size) - ALIGN(sizeof(*e), cacheline);
} }
static void *phdr_to_last_cached_entry(struct smem_partition_header *phdr) static void *
phdr_to_last_cached_entry(struct smem_partition_header *phdr)
{ {
void *p = phdr; void *p = phdr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment