Commit e2610b26 authored by Colin Cross's avatar Colin Cross Committed by Rafael J. Wysocki

binder: use freezable blocking calls

Avoid waking up every thread sleeping in a binder call during
suspend and resume by calling a freezable blocking call.  Previous
patches modified the freezer to avoid sending wakeups to threads
that are blocked in freezable blocking calls.

This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarColin Cross <ccross@android.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent dd5ec0f4
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include <asm/cacheflush.h> #include <asm/cacheflush.h>
#include <linux/fdtable.h> #include <linux/fdtable.h>
#include <linux/file.h> #include <linux/file.h>
#include <linux/freezer.h>
#include <linux/fs.h> #include <linux/fs.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/miscdevice.h> #include <linux/miscdevice.h>
...@@ -2140,13 +2141,13 @@ static int binder_thread_read(struct binder_proc *proc, ...@@ -2140,13 +2141,13 @@ static int binder_thread_read(struct binder_proc *proc,
if (!binder_has_proc_work(proc, thread)) if (!binder_has_proc_work(proc, thread))
ret = -EAGAIN; ret = -EAGAIN;
} else } else
ret = wait_event_interruptible_exclusive(proc->wait, binder_has_proc_work(proc, thread)); ret = wait_event_freezable_exclusive(proc->wait, binder_has_proc_work(proc, thread));
} else { } else {
if (non_block) { if (non_block) {
if (!binder_has_thread_work(thread)) if (!binder_has_thread_work(thread))
ret = -EAGAIN; ret = -EAGAIN;
} else } else
ret = wait_event_interruptible(thread->wait, binder_has_thread_work(thread)); ret = wait_event_freezable(thread->wait, binder_has_thread_work(thread));
} }
binder_lock(__func__); binder_lock(__func__);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment