Commit e2eb179c authored by Colin Ian King's avatar Colin Ian King Committed by Jonathan Cameron

iio: magnetometer: ak8974: remove redundant zero timeout check

At the end of the delay loop timeout will always be zero
and hence the check for !timeout will always be true. Remove
the redundant check and the redundant return 0 at the end of
the function.

Fixes CoverityScan CID#1357168 ("Logically dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent a9c99c76
...@@ -278,13 +278,9 @@ static int ak8974_await_drdy(struct ak8974 *ak8974) ...@@ -278,13 +278,9 @@ static int ak8974_await_drdy(struct ak8974 *ak8974)
if (val & AK8974_STATUS_DRDY) if (val & AK8974_STATUS_DRDY)
return 0; return 0;
} while (--timeout); } while (--timeout);
if (!timeout) {
dev_err(&ak8974->i2c->dev,
"timeout waiting for DRDY\n");
return -ETIMEDOUT;
}
return 0; dev_err(&ak8974->i2c->dev, "timeout waiting for DRDY\n");
return -ETIMEDOUT;
} }
static int ak8974_getresult(struct ak8974 *ak8974, __le16 *result) static int ak8974_getresult(struct ak8974 *ak8974, __le16 *result)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment