Commit e40cf640 authored by Logan Gunthorpe's avatar Logan Gunthorpe Committed by Bjorn Helgaas

switchtec: Use new cdev_device_add() helper function

Convert from "cdev_add() + device_add()" to cdev_device_add(), and from
"device_del() + cdev_del()" to cdev_device_del().

[bhelgaas: changelog]
Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent c849e551
...@@ -1291,7 +1291,6 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev) ...@@ -1291,7 +1291,6 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev)
cdev = &stdev->cdev; cdev = &stdev->cdev;
cdev_init(cdev, &switchtec_fops); cdev_init(cdev, &switchtec_fops);
cdev->owner = THIS_MODULE; cdev->owner = THIS_MODULE;
cdev->kobj.parent = &dev->kobj;
return stdev; return stdev;
...@@ -1479,11 +1478,7 @@ static int switchtec_pci_probe(struct pci_dev *pdev, ...@@ -1479,11 +1478,7 @@ static int switchtec_pci_probe(struct pci_dev *pdev,
SWITCHTEC_EVENT_EN_IRQ, SWITCHTEC_EVENT_EN_IRQ,
&stdev->mmio_part_cfg->mrpc_comp_hdr); &stdev->mmio_part_cfg->mrpc_comp_hdr);
rc = cdev_add(&stdev->cdev, stdev->dev.devt, 1); rc = cdev_device_add(&stdev->cdev, &stdev->dev);
if (rc)
goto err_put;
rc = device_add(&stdev->dev);
if (rc) if (rc)
goto err_devadd; goto err_devadd;
...@@ -1492,7 +1487,6 @@ static int switchtec_pci_probe(struct pci_dev *pdev, ...@@ -1492,7 +1487,6 @@ static int switchtec_pci_probe(struct pci_dev *pdev,
return 0; return 0;
err_devadd: err_devadd:
cdev_del(&stdev->cdev);
stdev_kill(stdev); stdev_kill(stdev);
err_put: err_put:
ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt)); ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt));
...@@ -1506,8 +1500,7 @@ static void switchtec_pci_remove(struct pci_dev *pdev) ...@@ -1506,8 +1500,7 @@ static void switchtec_pci_remove(struct pci_dev *pdev)
pci_set_drvdata(pdev, NULL); pci_set_drvdata(pdev, NULL);
device_del(&stdev->dev); cdev_device_del(&stdev->cdev, &stdev->dev);
cdev_del(&stdev->cdev);
ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt)); ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt));
dev_info(&stdev->dev, "unregistered.\n"); dev_info(&stdev->dev, "unregistered.\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment