Commit e447d358 authored by Julia Lawall's avatar Julia Lawall Committed by Grant Likely

spi/orion: Drop unnecessary null test

list_for_each_entry binds its first argument to a non-null value, and thus
any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x,E;
@@

I(x,...) { <...
- (x != NULL) &&
  E
  ...> }
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent 079a176d
...@@ -404,7 +404,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m) ...@@ -404,7 +404,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected; goto msg_rejected;
} }
if ((t != NULL) && t->bits_per_word) if (t->bits_per_word)
bits_per_word = t->bits_per_word; bits_per_word = t->bits_per_word;
if ((bits_per_word != 8) && (bits_per_word != 16)) { if ((bits_per_word != 8) && (bits_per_word != 16)) {
...@@ -415,7 +415,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m) ...@@ -415,7 +415,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected; goto msg_rejected;
} }
/*make sure buffer length is even when working in 16 bit mode*/ /*make sure buffer length is even when working in 16 bit mode*/
if ((t != NULL) && (t->bits_per_word == 16) && (t->len & 1)) { if ((t->bits_per_word == 16) && (t->len & 1)) {
dev_err(&spi->dev, dev_err(&spi->dev,
"message rejected : " "message rejected : "
"odd data length (%d) while in 16 bit mode\n", "odd data length (%d) while in 16 bit mode\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment