Commit e5c87b76 authored by Stratos Karafotis's avatar Stratos Karafotis Committed by Rafael J. Wysocki

cpufreq: Fix checkpatch errors and warnings

Fix 2 checkpatch errors about using assignment in if condition,
1 checkpatch error about a required space after comma
and 3 warnings about line over 80 characters.
Signed-off-by: default avatarStratos Karafotis <stratosk@semaphore.gr>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent bfa709bc
...@@ -939,8 +939,11 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, ...@@ -939,8 +939,11 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy,
up_write(&policy->rwsem); up_write(&policy->rwsem);
if (has_target()) { if (has_target()) {
if ((ret = __cpufreq_governor(policy, CPUFREQ_GOV_START)) || ret = __cpufreq_governor(policy, CPUFREQ_GOV_START);
(ret = __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS))) { if (!ret)
ret = __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS);
if (ret) {
pr_err("%s: Failed to start governor\n", __func__); pr_err("%s: Failed to start governor\n", __func__);
return ret; return ret;
} }
...@@ -1394,14 +1397,14 @@ static int __cpufreq_remove_dev_finish(struct device *dev, ...@@ -1394,14 +1397,14 @@ static int __cpufreq_remove_dev_finish(struct device *dev,
if (!cpufreq_suspended) if (!cpufreq_suspended)
cpufreq_policy_free(policy); cpufreq_policy_free(policy);
} else { } else if (has_target()) {
if (has_target()) { ret = __cpufreq_governor(policy, CPUFREQ_GOV_START);
if ((ret = __cpufreq_governor(policy, CPUFREQ_GOV_START)) || if (!ret)
(ret = __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS))) { ret = __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS);
pr_err("%s: Failed to start governor\n",
__func__); if (ret) {
return ret; pr_err("%s: Failed to start governor\n", __func__);
} return ret;
} }
} }
...@@ -2086,7 +2089,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, ...@@ -2086,7 +2089,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy,
if (old_gov) { if (old_gov) {
__cpufreq_governor(policy, CPUFREQ_GOV_STOP); __cpufreq_governor(policy, CPUFREQ_GOV_STOP);
up_write(&policy->rwsem); up_write(&policy->rwsem);
__cpufreq_governor(policy,CPUFREQ_GOV_POLICY_EXIT); __cpufreq_governor(policy, CPUFREQ_GOV_POLICY_EXIT);
down_write(&policy->rwsem); down_write(&policy->rwsem);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment