Commit e5ebb772 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (adm9240) Convert to use devm_ functions

Convert to use devm_ functions to reduce code size and simplify the code.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
parent dc2fd663
...@@ -650,11 +650,9 @@ static int adm9240_probe(struct i2c_client *new_client, ...@@ -650,11 +650,9 @@ static int adm9240_probe(struct i2c_client *new_client,
struct adm9240_data *data; struct adm9240_data *data;
int err; int err;
data = kzalloc(sizeof(*data), GFP_KERNEL); data = devm_kzalloc(&new_client->dev, sizeof(*data), GFP_KERNEL);
if (!data) { if (!data)
err = -ENOMEM; return -ENOMEM;
goto exit;
}
i2c_set_clientdata(new_client, data); i2c_set_clientdata(new_client, data);
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
...@@ -664,7 +662,7 @@ static int adm9240_probe(struct i2c_client *new_client, ...@@ -664,7 +662,7 @@ static int adm9240_probe(struct i2c_client *new_client,
/* populate sysfs filesystem */ /* populate sysfs filesystem */
err = sysfs_create_group(&new_client->dev.kobj, &adm9240_group); err = sysfs_create_group(&new_client->dev.kobj, &adm9240_group);
if (err) if (err)
goto exit_free; return err;
data->hwmon_dev = hwmon_device_register(&new_client->dev); data->hwmon_dev = hwmon_device_register(&new_client->dev);
if (IS_ERR(data->hwmon_dev)) { if (IS_ERR(data->hwmon_dev)) {
...@@ -676,9 +674,6 @@ static int adm9240_probe(struct i2c_client *new_client, ...@@ -676,9 +674,6 @@ static int adm9240_probe(struct i2c_client *new_client,
exit_remove: exit_remove:
sysfs_remove_group(&new_client->dev.kobj, &adm9240_group); sysfs_remove_group(&new_client->dev.kobj, &adm9240_group);
exit_free:
kfree(data);
exit:
return err; return err;
} }
...@@ -689,7 +684,6 @@ static int adm9240_remove(struct i2c_client *client) ...@@ -689,7 +684,6 @@ static int adm9240_remove(struct i2c_client *client)
hwmon_device_unregister(data->hwmon_dev); hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_group(&client->dev.kobj, &adm9240_group); sysfs_remove_group(&client->dev.kobj, &adm9240_group);
kfree(data);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment