Commit e757201b authored by George Spelvin's avatar George Spelvin Committed by John W. Linville

drivers/net/wireless/ti/wl*/spi.c: Simplify CRC computation

These devices require commands stored in buffers in an odd order,
different from that in which the CRC is computed.

Rather than make two copies of the commands in two different orders,
form the commands in logical (CRC) order, append the CRC, then byte-swap
in place to the desired order.

The old code worked fine, I'm just scratching an "ugh, that's ugly"
itch.
Signed-off-by: default avatarGeorge Spelvin <linux@horizon.com>
Reviewed-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9b60fa4a
...@@ -23,6 +23,7 @@ ...@@ -23,6 +23,7 @@
#include <linux/irq.h> #include <linux/irq.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/swab.h>
#include <linux/crc7.h> #include <linux/crc7.h>
#include <linux/spi/spi.h> #include <linux/spi/spi.h>
#include <linux/wl12xx.h> #include <linux/wl12xx.h>
...@@ -83,46 +84,44 @@ static void wl1251_spi_reset(struct wl1251 *wl) ...@@ -83,46 +84,44 @@ static void wl1251_spi_reset(struct wl1251 *wl)
static void wl1251_spi_wake(struct wl1251 *wl) static void wl1251_spi_wake(struct wl1251 *wl)
{ {
u8 crc[WSPI_INIT_CMD_CRC_LEN], *cmd;
struct spi_transfer t; struct spi_transfer t;
struct spi_message m; struct spi_message m;
u8 *cmd = kzalloc(WSPI_INIT_CMD_LEN, GFP_KERNEL);
cmd = kzalloc(WSPI_INIT_CMD_LEN, GFP_KERNEL);
if (!cmd) { if (!cmd) {
wl1251_error("could not allocate cmd for spi init"); wl1251_error("could not allocate cmd for spi init");
return; return;
} }
memset(crc, 0, sizeof(crc));
memset(&t, 0, sizeof(t)); memset(&t, 0, sizeof(t));
spi_message_init(&m); spi_message_init(&m);
/* Set WSPI_INIT_COMMAND /* Set WSPI_INIT_COMMAND
* the data is being send from the MSB to LSB * the data is being send from the MSB to LSB
*/ */
cmd[2] = 0xff; cmd[0] = 0xff;
cmd[3] = 0xff; cmd[1] = 0xff;
cmd[1] = WSPI_INIT_CMD_START | WSPI_INIT_CMD_TX; cmd[2] = WSPI_INIT_CMD_START | WSPI_INIT_CMD_TX;
cmd[0] = 0; cmd[3] = 0;
cmd[7] = 0; cmd[4] = 0;
cmd[6] |= HW_ACCESS_WSPI_INIT_CMD_MASK << 3; cmd[5] = HW_ACCESS_WSPI_INIT_CMD_MASK << 3;
cmd[6] |= HW_ACCESS_WSPI_FIXED_BUSY_LEN & WSPI_INIT_CMD_FIXEDBUSY_LEN; cmd[5] |= HW_ACCESS_WSPI_FIXED_BUSY_LEN & WSPI_INIT_CMD_FIXEDBUSY_LEN;
cmd[6] = WSPI_INIT_CMD_IOD | WSPI_INIT_CMD_IP | WSPI_INIT_CMD_CS
| WSPI_INIT_CMD_WSPI | WSPI_INIT_CMD_WS;
if (HW_ACCESS_WSPI_FIXED_BUSY_LEN == 0) if (HW_ACCESS_WSPI_FIXED_BUSY_LEN == 0)
cmd[5] |= WSPI_INIT_CMD_DIS_FIXEDBUSY; cmd[6] |= WSPI_INIT_CMD_DIS_FIXEDBUSY;
else else
cmd[5] |= WSPI_INIT_CMD_EN_FIXEDBUSY; cmd[6] |= WSPI_INIT_CMD_EN_FIXEDBUSY;
cmd[5] |= WSPI_INIT_CMD_IOD | WSPI_INIT_CMD_IP | WSPI_INIT_CMD_CS
| WSPI_INIT_CMD_WSPI | WSPI_INIT_CMD_WS;
crc[0] = cmd[1];
crc[1] = cmd[0];
crc[2] = cmd[7];
crc[3] = cmd[6];
crc[4] = cmd[5];
cmd[4] = crc7_be(0, crc, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END; cmd[7] = crc7_be(0, cmd+2, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END;
/*
* The above is the logical order; it must actually be stored
* in the buffer byte-swapped.
*/
__swab32s((u32 *)cmd);
__swab32s((u32 *)cmd+1);
t.tx_buf = cmd; t.tx_buf = cmd;
t.len = WSPI_INIT_CMD_LEN; t.len = WSPI_INIT_CMD_LEN;
......
...@@ -24,11 +24,12 @@ ...@@ -24,11 +24,12 @@
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/irq.h> #include <linux/irq.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/slab.h>
#include <linux/swab.h>
#include <linux/crc7.h> #include <linux/crc7.h>
#include <linux/spi/spi.h> #include <linux/spi/spi.h>
#include <linux/wl12xx.h> #include <linux/wl12xx.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/slab.h>
#include "wlcore.h" #include "wlcore.h"
#include "wl12xx_80211.h" #include "wl12xx_80211.h"
...@@ -110,18 +111,16 @@ static void wl12xx_spi_reset(struct device *child) ...@@ -110,18 +111,16 @@ static void wl12xx_spi_reset(struct device *child)
static void wl12xx_spi_init(struct device *child) static void wl12xx_spi_init(struct device *child)
{ {
struct wl12xx_spi_glue *glue = dev_get_drvdata(child->parent); struct wl12xx_spi_glue *glue = dev_get_drvdata(child->parent);
u8 crc[WSPI_INIT_CMD_CRC_LEN], *cmd;
struct spi_transfer t; struct spi_transfer t;
struct spi_message m; struct spi_message m;
u8 *cmd = kzalloc(WSPI_INIT_CMD_LEN, GFP_KERNEL);
cmd = kzalloc(WSPI_INIT_CMD_LEN, GFP_KERNEL);
if (!cmd) { if (!cmd) {
dev_err(child->parent, dev_err(child->parent,
"could not allocate cmd for spi init\n"); "could not allocate cmd for spi init\n");
return; return;
} }
memset(crc, 0, sizeof(crc));
memset(&t, 0, sizeof(t)); memset(&t, 0, sizeof(t));
spi_message_init(&m); spi_message_init(&m);
...@@ -129,29 +128,29 @@ static void wl12xx_spi_init(struct device *child) ...@@ -129,29 +128,29 @@ static void wl12xx_spi_init(struct device *child)
* Set WSPI_INIT_COMMAND * Set WSPI_INIT_COMMAND
* the data is being send from the MSB to LSB * the data is being send from the MSB to LSB
*/ */
cmd[2] = 0xff; cmd[0] = 0xff;
cmd[3] = 0xff; cmd[1] = 0xff;
cmd[1] = WSPI_INIT_CMD_START | WSPI_INIT_CMD_TX; cmd[2] = WSPI_INIT_CMD_START | WSPI_INIT_CMD_TX;
cmd[0] = 0; cmd[3] = 0;
cmd[7] = 0; cmd[4] = 0;
cmd[6] |= HW_ACCESS_WSPI_INIT_CMD_MASK << 3; cmd[5] = HW_ACCESS_WSPI_INIT_CMD_MASK << 3;
cmd[6] |= HW_ACCESS_WSPI_FIXED_BUSY_LEN & WSPI_INIT_CMD_FIXEDBUSY_LEN; cmd[5] |= HW_ACCESS_WSPI_FIXED_BUSY_LEN & WSPI_INIT_CMD_FIXEDBUSY_LEN;
cmd[6] = WSPI_INIT_CMD_IOD | WSPI_INIT_CMD_IP | WSPI_INIT_CMD_CS
| WSPI_INIT_CMD_WSPI | WSPI_INIT_CMD_WS;
if (HW_ACCESS_WSPI_FIXED_BUSY_LEN == 0) if (HW_ACCESS_WSPI_FIXED_BUSY_LEN == 0)
cmd[5] |= WSPI_INIT_CMD_DIS_FIXEDBUSY; cmd[6] |= WSPI_INIT_CMD_DIS_FIXEDBUSY;
else else
cmd[5] |= WSPI_INIT_CMD_EN_FIXEDBUSY; cmd[6] |= WSPI_INIT_CMD_EN_FIXEDBUSY;
cmd[5] |= WSPI_INIT_CMD_IOD | WSPI_INIT_CMD_IP | WSPI_INIT_CMD_CS cmd[7] = crc7_be(0, cmd+2, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END;
| WSPI_INIT_CMD_WSPI | WSPI_INIT_CMD_WS; /*
* The above is the logical order; it must actually be stored
crc[0] = cmd[1]; * in the buffer byte-swapped.
crc[1] = cmd[0]; */
crc[2] = cmd[7]; __swab32s((u32 *)cmd);
crc[3] = cmd[6]; __swab32s((u32 *)cmd+1);
crc[4] = cmd[5];
cmd[4] = crc7_be(0, crc, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END;
t.tx_buf = cmd; t.tx_buf = cmd;
t.len = WSPI_INIT_CMD_LEN; t.len = WSPI_INIT_CMD_LEN;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment