Commit e83cf875 authored by Darrick J. Wong's avatar Darrick J. Wong

xfs: xfs_buf_corruption_error should take __this_address

Add a xfs_failaddr_t parameter to this function so that callers can
potentially pass in (and therefore report) the exact point in the code
where we decided that a metadata buffer was corrupt.  This enables us to
wire it up to checking functions that have to run outside of verifiers.
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
parent 8d57c216
...@@ -1591,7 +1591,7 @@ __xfs_buf_mark_corrupt( ...@@ -1591,7 +1591,7 @@ __xfs_buf_mark_corrupt(
{ {
ASSERT(bp->b_flags & XBF_DONE); ASSERT(bp->b_flags & XBF_DONE);
xfs_buf_corruption_error(bp); xfs_buf_corruption_error(bp, fa);
xfs_buf_stale(bp); xfs_buf_stale(bp);
} }
......
...@@ -350,13 +350,14 @@ xfs_corruption_error( ...@@ -350,13 +350,14 @@ xfs_corruption_error(
*/ */
void void
xfs_buf_corruption_error( xfs_buf_corruption_error(
struct xfs_buf *bp) struct xfs_buf *bp,
xfs_failaddr_t fa)
{ {
struct xfs_mount *mp = bp->b_mount; struct xfs_mount *mp = bp->b_mount;
xfs_alert_tag(mp, XFS_PTAG_VERIFIER_ERROR, xfs_alert_tag(mp, XFS_PTAG_VERIFIER_ERROR,
"Metadata corruption detected at %pS, %s block 0x%llx", "Metadata corruption detected at %pS, %s block 0x%llx",
__return_address, bp->b_ops->name, bp->b_bn); fa, bp->b_ops->name, bp->b_bn);
xfs_alert(mp, "Unmount and run xfs_repair"); xfs_alert(mp, "Unmount and run xfs_repair");
......
...@@ -15,7 +15,7 @@ extern void xfs_corruption_error(const char *tag, int level, ...@@ -15,7 +15,7 @@ extern void xfs_corruption_error(const char *tag, int level,
struct xfs_mount *mp, const void *buf, size_t bufsize, struct xfs_mount *mp, const void *buf, size_t bufsize,
const char *filename, int linenum, const char *filename, int linenum,
xfs_failaddr_t failaddr); xfs_failaddr_t failaddr);
void xfs_buf_corruption_error(struct xfs_buf *bp); void xfs_buf_corruption_error(struct xfs_buf *bp, xfs_failaddr_t fa);
extern void xfs_buf_verifier_error(struct xfs_buf *bp, int error, extern void xfs_buf_verifier_error(struct xfs_buf *bp, int error,
const char *name, const void *buf, size_t bufsz, const char *name, const void *buf, size_t bufsz,
xfs_failaddr_t failaddr); xfs_failaddr_t failaddr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment