Commit e8f1bc14 authored by Liu Bo's avatar Liu Bo Committed by David Sterba

Btrfs: fix btrfs_evict_inode to handle abnormal inodes correctly

This regression is introduced in
commit 3d48d981 ("btrfs: Handle uninitialised inode eviction").

There are two problems,

a) it is ->destroy_inode() that does the final free on inode, not
   ->evict_inode(),
b) clear_inode() must be called before ->evict_inode() returns.

This could end up hitting BUG_ON(inode->i_state != (I_FREEING | I_CLEAR));
in evict() because I_CLEAR is set in clear_inode().

Fixes: commit 3d48d981 ("btrfs: Handle uninitialised inode eviction")
Cc: <stable@vger.kernel.org> # v4.7-rc6+
Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarJosef Bacik <jbacik@fb.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 55237a5f
...@@ -5281,7 +5281,7 @@ void btrfs_evict_inode(struct inode *inode) ...@@ -5281,7 +5281,7 @@ void btrfs_evict_inode(struct inode *inode)
trace_btrfs_inode_evict(inode); trace_btrfs_inode_evict(inode);
if (!root) { if (!root) {
kmem_cache_free(btrfs_inode_cachep, BTRFS_I(inode)); clear_inode(inode);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment