Commit e917fd39 authored by Jesper Juhl's avatar Jesper Juhl Committed by Dave Airlie

radeon mkregtable: Add missing fclose() calls

drivers/gpu/drm/radeon/mkregtable.c:parser_auth() almost always remembers
to fclose(file) before returning, but it misses two spots.

This is not really important since the process will exit shortly after and
thus close the file for us, but being explicit prevents static analysis
tools from complaining about leaked memory and missing fclose() calls and
it also seems to be the prefered style of the existing code to explicitly
close the file.

So, here's a patch to add the two missing fclose() calls.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent c9417bdd
...@@ -673,8 +673,10 @@ static int parser_auth(struct table *t, const char *filename) ...@@ -673,8 +673,10 @@ static int parser_auth(struct table *t, const char *filename)
last_reg = strtol(last_reg_s, NULL, 16); last_reg = strtol(last_reg_s, NULL, 16);
do { do {
if (fgets(buf, 1024, file) == NULL) if (fgets(buf, 1024, file) == NULL) {
fclose(file);
return -1; return -1;
}
len = strlen(buf); len = strlen(buf);
if (ftell(file) == end) if (ftell(file) == end)
done = 1; done = 1;
...@@ -685,6 +687,7 @@ static int parser_auth(struct table *t, const char *filename) ...@@ -685,6 +687,7 @@ static int parser_auth(struct table *t, const char *filename)
fprintf(stderr, fprintf(stderr,
"Error matching regular expression %d in %s\n", "Error matching regular expression %d in %s\n",
r, filename); r, filename);
fclose(file);
return -1; return -1;
} else { } else {
buf[match[0].rm_eo] = 0; buf[match[0].rm_eo] = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment