Commit edd2126a authored by Jiri Kosina's avatar Jiri Kosina

HID: wacom: make sysfs permissions more strict

It's not really dangerous in this driver, but it's against general
practice and worth fixing.

Wacom uses the attribute for changing the reporting speed of the
tablet (and this actually requires poking the device in the
background) (still I wouldn't consider it a security issue though).

udev is a proper place to handle this.
Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent c311598b
...@@ -172,7 +172,7 @@ static ssize_t wacom_store_speed(struct device *dev, ...@@ -172,7 +172,7 @@ static ssize_t wacom_store_speed(struct device *dev,
return -EINVAL; return -EINVAL;
} }
static DEVICE_ATTR(speed, S_IRUGO | S_IWUGO, static DEVICE_ATTR(speed, S_IRUGO | S_IWUSR | S_IWGRP,
wacom_show_speed, wacom_store_speed); wacom_show_speed, wacom_store_speed);
static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report, static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment