Commit ef100682 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville

cfg80211: annotate cfg80211_inform_bss

This function returns a referenced BSS struct
(or NULL), annotate with __must_check. It seems
that a lot of drivers get this completely wrong
and leak all BSS structs as a result.
Reported-by: default avatarAdam Mikuta <Adam.Mikuta@tieto.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c74d084f
...@@ -2636,8 +2636,10 @@ void cfg80211_sched_scan_stopped(struct wiphy *wiphy); ...@@ -2636,8 +2636,10 @@ void cfg80211_sched_scan_stopped(struct wiphy *wiphy);
* *
* This informs cfg80211 that BSS information was found and * This informs cfg80211 that BSS information was found and
* the BSS should be updated/added. * the BSS should be updated/added.
*
* NOTE: Returns a referenced struct, must be released with cfg80211_put_bss()!
*/ */
struct cfg80211_bss* struct cfg80211_bss * __must_check
cfg80211_inform_bss_frame(struct wiphy *wiphy, cfg80211_inform_bss_frame(struct wiphy *wiphy,
struct ieee80211_channel *channel, struct ieee80211_channel *channel,
struct ieee80211_mgmt *mgmt, size_t len, struct ieee80211_mgmt *mgmt, size_t len,
...@@ -2659,8 +2661,10 @@ cfg80211_inform_bss_frame(struct wiphy *wiphy, ...@@ -2659,8 +2661,10 @@ cfg80211_inform_bss_frame(struct wiphy *wiphy,
* *
* This informs cfg80211 that BSS information was found and * This informs cfg80211 that BSS information was found and
* the BSS should be updated/added. * the BSS should be updated/added.
*
* NOTE: Returns a referenced struct, must be released with cfg80211_put_bss()!
*/ */
struct cfg80211_bss* struct cfg80211_bss * __must_check
cfg80211_inform_bss(struct wiphy *wiphy, cfg80211_inform_bss(struct wiphy *wiphy,
struct ieee80211_channel *channel, struct ieee80211_channel *channel,
const u8 *bssid, const u8 *bssid,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment