Commit f026fe3d authored by Stephen Warren's avatar Stephen Warren Committed by Linus Walleij

pinctrl: downgrade pinctrl_get warning when no maps are found

This may be perfectly legitimate. An IP block may get re-used
across SoCs. Not all of those SoCs may need pinmux settings for the
IP block, e.g. if one SoC dedicates pins to that function but
another doesn't. The driver won't know this, and will always
attempt to set up the pinmux. The mapping table defines whether any
HW programming is actually needed.
Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
[rebased to fit the applied patch series]
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9891d98c
...@@ -567,14 +567,16 @@ static struct pinctrl *pinctrl_get_locked(struct device *dev, const char *name) ...@@ -567,14 +567,16 @@ static struct pinctrl *pinctrl_get_locked(struct device *dev, const char *name)
} }
} }
/* We should have atleast one map, right */ /*
if (!num_maps) { * This may be perfectly legitimate. An IP block may get re-used
pr_err("could not find any mux maps for device %s, ID %s\n", * across SoCs. Not all of those SoCs may need pinmux settings for the
devname ? devname : "(anonymous)", * IP block, e.g. if one SoC dedicates pins to that function but
name ? name : "(undefined)"); * another doesn't. The driver won't know this, and will always
kfree(p); * attempt to set up the pinmux. The mapping table defines whether any
return ERR_PTR(-EINVAL); * HW programming is actually needed.
} */
if (!num_maps)
dev_info(dev, "zero maps found for mapping %s\n", name);
pr_debug("found %u mux maps for device %s, UD %s\n", pr_debug("found %u mux maps for device %s, UD %s\n",
num_maps, num_maps,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment