Commit f39f54af authored by Jingoo Han's avatar Jingoo Han Committed by Linus Walleij

gpio: pcf857x: use devm_kzalloc()

Use devm_kzalloc() to make cleanup paths simpler.
Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 632d8e55
...@@ -268,7 +268,7 @@ static int pcf857x_probe(struct i2c_client *client, ...@@ -268,7 +268,7 @@ static int pcf857x_probe(struct i2c_client *client,
} }
/* Allocate, initialize, and register this gpio_chip. */ /* Allocate, initialize, and register this gpio_chip. */
gpio = kzalloc(sizeof *gpio, GFP_KERNEL); gpio = devm_kzalloc(&client->dev, sizeof(*gpio), GFP_KERNEL);
if (!gpio) if (!gpio)
return -ENOMEM; return -ENOMEM;
...@@ -391,7 +391,6 @@ static int pcf857x_probe(struct i2c_client *client, ...@@ -391,7 +391,6 @@ static int pcf857x_probe(struct i2c_client *client,
if (pdata && client->irq) if (pdata && client->irq)
pcf857x_irq_domain_cleanup(gpio); pcf857x_irq_domain_cleanup(gpio);
kfree(gpio);
return status; return status;
} }
...@@ -416,9 +415,7 @@ static int pcf857x_remove(struct i2c_client *client) ...@@ -416,9 +415,7 @@ static int pcf857x_remove(struct i2c_client *client)
pcf857x_irq_domain_cleanup(gpio); pcf857x_irq_domain_cleanup(gpio);
status = gpiochip_remove(&gpio->chip); status = gpiochip_remove(&gpio->chip);
if (status == 0) if (status)
kfree(gpio);
else
dev_err(&client->dev, "%s --> %d\n", "remove", status); dev_err(&client->dev, "%s --> %d\n", "remove", status);
return status; return status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment