Commit f5cd8de2 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

regulator: ti-abb: Fix off-by-one valid range checking for abb->current_info_idx

abb->current_info_idx is used as array subscript to access volt_table,
thus the valid value range should be 0 ... desc->n_voltages - 1.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarNishanth Menon <nm@ti.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 40b1936e
......@@ -387,8 +387,8 @@ static int ti_abb_get_voltage_sel(struct regulator_dev *rdev)
return -EINVAL;
}
if (abb->current_info_idx > (int)desc->n_voltages) {
dev_err(dev, "%s: Corrupted data? idx(%d) > n_voltages(%d)\n",
if (abb->current_info_idx >= (int)desc->n_voltages) {
dev_err(dev, "%s: Corrupted data? idx(%d) >= n_voltages(%d)\n",
__func__, abb->current_info_idx, desc->n_voltages);
return -EINVAL;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment