Commit f5d84a21 authored by Prashant Malani's avatar Prashant Malani Committed by Benson Leung

platform/chrome: cros_usbpd_notify: Add driver data struct

Introduce a device driver data structure, cros_usbpd_notify_data, in
which we can store the notifier block object and pointers to the struct
cros_ec_device and struct device objects.

This will make it more convenient to access these pointers when
executing both platform and ACPI callbacks.
Signed-off-by: default avatarPrashant Malani <pmalani@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
parent 92e399c0
...@@ -16,6 +16,12 @@ ...@@ -16,6 +16,12 @@
static BLOCKING_NOTIFIER_HEAD(cros_usbpd_notifier_list); static BLOCKING_NOTIFIER_HEAD(cros_usbpd_notifier_list);
struct cros_usbpd_notify_data {
struct device *dev;
struct cros_ec_device *ec;
struct notifier_block nb;
};
/** /**
* cros_usbpd_register_notify - Register a notifier callback for PD events. * cros_usbpd_register_notify - Register a notifier callback for PD events.
* @nb: Notifier block pointer to register * @nb: Notifier block pointer to register
...@@ -98,18 +104,21 @@ static int cros_usbpd_notify_probe_plat(struct platform_device *pdev) ...@@ -98,18 +104,21 @@ static int cros_usbpd_notify_probe_plat(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent); struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent);
struct notifier_block *nb; struct cros_usbpd_notify_data *pdnotify;
int ret; int ret;
nb = devm_kzalloc(dev, sizeof(*nb), GFP_KERNEL); pdnotify = devm_kzalloc(dev, sizeof(*pdnotify), GFP_KERNEL);
if (!nb) if (!pdnotify)
return -ENOMEM; return -ENOMEM;
nb->notifier_call = cros_usbpd_notify_plat; pdnotify->dev = dev;
dev_set_drvdata(dev, nb); pdnotify->ec = ecdev->ec_dev;
pdnotify->nb.notifier_call = cros_usbpd_notify_plat;
dev_set_drvdata(dev, pdnotify);
ret = blocking_notifier_chain_register(&ecdev->ec_dev->event_notifier, ret = blocking_notifier_chain_register(&ecdev->ec_dev->event_notifier,
nb); &pdnotify->nb);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "Failed to register notifier\n"); dev_err(dev, "Failed to register notifier\n");
return ret; return ret;
...@@ -122,10 +131,11 @@ static int cros_usbpd_notify_remove_plat(struct platform_device *pdev) ...@@ -122,10 +131,11 @@ static int cros_usbpd_notify_remove_plat(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent); struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent);
struct notifier_block *nb = struct cros_usbpd_notify_data *pdnotify =
(struct notifier_block *)dev_get_drvdata(dev); (struct cros_usbpd_notify_data *)dev_get_drvdata(dev);
blocking_notifier_chain_unregister(&ecdev->ec_dev->event_notifier, nb); blocking_notifier_chain_unregister(&ecdev->ec_dev->event_notifier,
&pdnotify->nb);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment