Commit f5da7cb2 authored by Mark Brown's avatar Mark Brown Committed by Greg Kroah-Hartman

coresight: etb10: Fix check for bogus buffer depth

We attempt to sanity check the buffer depth reported by the hardware by
making sure it is not less than zero however this check will never be true
since the buffer depth is stored in an unsigned integer. Instead change
the check to look for the top bit being set which was the intention.
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cc545449
...@@ -457,7 +457,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) ...@@ -457,7 +457,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
drvdata->buffer_depth = etb_get_buffer_depth(drvdata); drvdata->buffer_depth = etb_get_buffer_depth(drvdata);
clk_disable_unprepare(drvdata->clk); clk_disable_unprepare(drvdata->clk);
if (drvdata->buffer_depth < 0) if (drvdata->buffer_depth & 0x80000000)
return -EINVAL; return -EINVAL;
drvdata->buf = devm_kzalloc(dev, drvdata->buf = devm_kzalloc(dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment