Commit f60dc013 authored by John W. Linville's avatar John W. Linville

iwlwifi: Convert to new PCI PM framework

Use the new PCI PM and let the PCI core code handle the PCI-specific
details of power transitions.

Based on similarly titled ath9k patch posted by Rafael J. Wysocki.
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Acked-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
parent b9237578
...@@ -4838,10 +4838,7 @@ static struct pci_driver iwl_driver = { ...@@ -4838,10 +4838,7 @@ static struct pci_driver iwl_driver = {
.id_table = iwl_hw_card_ids, .id_table = iwl_hw_card_ids,
.probe = iwl_pci_probe, .probe = iwl_pci_probe,
.remove = __devexit_p(iwl_pci_remove), .remove = __devexit_p(iwl_pci_remove),
#ifdef CONFIG_PM .driver.pm = IWL_PM_OPS,
.suspend = iwl_pci_suspend,
.resume = iwl_pci_resume,
#endif
}; };
static int __init iwl_init(void) static int __init iwl_init(void)
......
...@@ -2592,8 +2592,9 @@ EXPORT_SYMBOL(iwl_add_beacon_time); ...@@ -2592,8 +2592,9 @@ EXPORT_SYMBOL(iwl_add_beacon_time);
#ifdef CONFIG_PM #ifdef CONFIG_PM
int iwl_pci_suspend(struct pci_dev *pdev, pm_message_t state) int iwl_pci_suspend(struct device *device)
{ {
struct pci_dev *pdev = to_pci_dev(device);
struct iwl_priv *priv = pci_get_drvdata(pdev); struct iwl_priv *priv = pci_get_drvdata(pdev);
/* /*
...@@ -2605,18 +2606,14 @@ int iwl_pci_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -2605,18 +2606,14 @@ int iwl_pci_suspend(struct pci_dev *pdev, pm_message_t state)
*/ */
iwl_apm_stop(priv); iwl_apm_stop(priv);
pci_save_state(pdev);
pci_disable_device(pdev);
pci_set_power_state(pdev, PCI_D3hot);
return 0; return 0;
} }
EXPORT_SYMBOL(iwl_pci_suspend); EXPORT_SYMBOL(iwl_pci_suspend);
int iwl_pci_resume(struct pci_dev *pdev) int iwl_pci_resume(struct device *device)
{ {
struct pci_dev *pdev = to_pci_dev(device);
struct iwl_priv *priv = pci_get_drvdata(pdev); struct iwl_priv *priv = pci_get_drvdata(pdev);
int ret;
bool hw_rfkill = false; bool hw_rfkill = false;
/* /*
...@@ -2625,11 +2622,6 @@ int iwl_pci_resume(struct pci_dev *pdev) ...@@ -2625,11 +2622,6 @@ int iwl_pci_resume(struct pci_dev *pdev)
*/ */
pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00); pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00);
pci_set_power_state(pdev, PCI_D0);
ret = pci_enable_device(pdev);
if (ret)
return ret;
pci_restore_state(pdev);
iwl_enable_interrupts(priv); iwl_enable_interrupts(priv);
if (!(iwl_read32(priv, CSR_GP_CNTRL) & if (!(iwl_read32(priv, CSR_GP_CNTRL) &
...@@ -2647,4 +2639,14 @@ int iwl_pci_resume(struct pci_dev *pdev) ...@@ -2647,4 +2639,14 @@ int iwl_pci_resume(struct pci_dev *pdev)
} }
EXPORT_SYMBOL(iwl_pci_resume); EXPORT_SYMBOL(iwl_pci_resume);
const struct dev_pm_ops iwl_pm_ops = {
.suspend = iwl_pci_suspend,
.resume = iwl_pci_resume,
.freeze = iwl_pci_suspend,
.thaw = iwl_pci_resume,
.poweroff = iwl_pci_suspend,
.restore = iwl_pci_resume,
};
EXPORT_SYMBOL(iwl_pm_ops);
#endif /* CONFIG_PM */ #endif /* CONFIG_PM */
...@@ -615,9 +615,17 @@ __le32 iwl_add_beacon_time(struct iwl_priv *priv, u32 base, ...@@ -615,9 +615,17 @@ __le32 iwl_add_beacon_time(struct iwl_priv *priv, u32 base,
u32 addon, u32 beacon_interval); u32 addon, u32 beacon_interval);
#ifdef CONFIG_PM #ifdef CONFIG_PM
int iwl_pci_suspend(struct pci_dev *pdev, pm_message_t state); int iwl_pci_suspend(struct device *device);
int iwl_pci_resume(struct pci_dev *pdev); int iwl_pci_resume(struct device *device);
#endif /* CONFIG_PM */ extern const struct dev_pm_ops iwl_pm_ops;
#define IWL_PM_OPS (&iwl_pm_ops)
#else /* !CONFIG_PM */
#define IWL_PM_OPS NULL
#endif /* !CONFIG_PM */
/***************************************************** /*****************************************************
* Error Handling Debugging * Error Handling Debugging
......
...@@ -4275,10 +4275,7 @@ static struct pci_driver iwl3945_driver = { ...@@ -4275,10 +4275,7 @@ static struct pci_driver iwl3945_driver = {
.id_table = iwl3945_hw_card_ids, .id_table = iwl3945_hw_card_ids,
.probe = iwl3945_pci_probe, .probe = iwl3945_pci_probe,
.remove = __devexit_p(iwl3945_pci_remove), .remove = __devexit_p(iwl3945_pci_remove),
#ifdef CONFIG_PM .driver.pm = IWL_PM_OPS,
.suspend = iwl_pci_suspend,
.resume = iwl_pci_resume,
#endif
}; };
static int __init iwl3945_init(void) static int __init iwl3945_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment