Commit f6b4b4a1 authored by Evan Quan's avatar Evan Quan Committed by Alex Deucher

drm/amd/powerplay: correct the APIs' naming

'UVD' is a HW engine name for Vega20 and before ASICs.
For newer ASICs, the similar engine is named as 'VCN'.
Signed-off-by: default avatarEvan Quan <evan.quan@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7a1105bd
...@@ -455,10 +455,15 @@ int smu_dpm_set_power_gate(struct smu_context *smu, uint32_t block_type, ...@@ -455,10 +455,15 @@ int smu_dpm_set_power_gate(struct smu_context *smu, uint32_t block_type,
return -EOPNOTSUPP; return -EOPNOTSUPP;
switch (block_type) { switch (block_type) {
/*
* Some legacy code of amdgpu_vcn.c and vcn_v2*.c still uses
* AMD_IP_BLOCK_TYPE_UVD for VCN. So, here both of them are kept.
*/
case AMD_IP_BLOCK_TYPE_UVD: case AMD_IP_BLOCK_TYPE_UVD:
ret = smu_dpm_set_uvd_enable(smu, !gate); case AMD_IP_BLOCK_TYPE_VCN:
ret = smu_dpm_set_vcn_enable(smu, !gate);
if (ret) if (ret)
dev_err(smu->adev->dev, "Failed to power %s UVD!\n", dev_err(smu->adev->dev, "Failed to power %s VCN!\n",
gate ? "gate" : "ungate"); gate ? "gate" : "ungate");
break; break;
case AMD_IP_BLOCK_TYPE_GFX: case AMD_IP_BLOCK_TYPE_GFX:
...@@ -1328,7 +1333,7 @@ static int smu_hw_init(void *handle) ...@@ -1328,7 +1333,7 @@ static int smu_hw_init(void *handle)
if (smu->is_apu) { if (smu->is_apu) {
smu_powergate_sdma(&adev->smu, false); smu_powergate_sdma(&adev->smu, false);
smu_dpm_set_uvd_enable(smu, true); smu_dpm_set_vcn_enable(smu, true);
smu_dpm_set_jpeg_enable(smu, true); smu_dpm_set_jpeg_enable(smu, true);
smu_set_gfx_cgpg(&adev->smu, true); smu_set_gfx_cgpg(&adev->smu, true);
} }
...@@ -1460,7 +1465,7 @@ static int smu_hw_fini(void *handle) ...@@ -1460,7 +1465,7 @@ static int smu_hw_fini(void *handle)
if (smu->is_apu) { if (smu->is_apu) {
smu_powergate_sdma(&adev->smu, true); smu_powergate_sdma(&adev->smu, true);
smu_dpm_set_uvd_enable(smu, false); smu_dpm_set_vcn_enable(smu, false);
smu_dpm_set_jpeg_enable(smu, false); smu_dpm_set_jpeg_enable(smu, false);
} }
......
...@@ -2118,7 +2118,7 @@ static bool arcturus_is_dpm_running(struct smu_context *smu) ...@@ -2118,7 +2118,7 @@ static bool arcturus_is_dpm_running(struct smu_context *smu)
return !!(feature_enabled & SMC_DPM_FEATURE); return !!(feature_enabled & SMC_DPM_FEATURE);
} }
static int arcturus_dpm_set_uvd_enable(struct smu_context *smu, bool enable) static int arcturus_dpm_set_vcn_enable(struct smu_context *smu, bool enable)
{ {
struct smu_power_context *smu_power = &smu->smu_power; struct smu_power_context *smu_power = &smu->smu_power;
struct smu_power_gate *power_gate = &smu_power->power_gate; struct smu_power_gate *power_gate = &smu_power->power_gate;
...@@ -2617,7 +2617,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = { ...@@ -2617,7 +2617,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {
.dump_pptable = arcturus_dump_pptable, .dump_pptable = arcturus_dump_pptable,
.get_power_limit = arcturus_get_power_limit, .get_power_limit = arcturus_get_power_limit,
.is_dpm_running = arcturus_is_dpm_running, .is_dpm_running = arcturus_is_dpm_running,
.dpm_set_uvd_enable = arcturus_dpm_set_uvd_enable, .dpm_set_vcn_enable = arcturus_dpm_set_vcn_enable,
.i2c_eeprom_init = arcturus_i2c_eeprom_control_init, .i2c_eeprom_init = arcturus_i2c_eeprom_control_init,
.i2c_eeprom_fini = arcturus_i2c_eeprom_control_fini, .i2c_eeprom_fini = arcturus_i2c_eeprom_control_fini,
.get_unique_id = arcturus_get_unique_id, .get_unique_id = arcturus_get_unique_id,
......
...@@ -453,7 +453,7 @@ struct pptable_funcs { ...@@ -453,7 +453,7 @@ struct pptable_funcs {
*clocks); *clocks);
int (*get_power_profile_mode)(struct smu_context *smu, char *buf); int (*get_power_profile_mode)(struct smu_context *smu, char *buf);
int (*set_power_profile_mode)(struct smu_context *smu, long *input, uint32_t size); int (*set_power_profile_mode)(struct smu_context *smu, long *input, uint32_t size);
int (*dpm_set_uvd_enable)(struct smu_context *smu, bool enable); int (*dpm_set_vcn_enable)(struct smu_context *smu, bool enable);
int (*dpm_set_jpeg_enable)(struct smu_context *smu, bool enable); int (*dpm_set_jpeg_enable)(struct smu_context *smu, bool enable);
int (*read_sensor)(struct smu_context *smu, enum amd_pp_sensors sensor, int (*read_sensor)(struct smu_context *smu, enum amd_pp_sensors sensor,
void *data, uint32_t *size); void *data, uint32_t *size);
......
...@@ -729,7 +729,7 @@ static int navi10_set_default_dpm_table(struct smu_context *smu) ...@@ -729,7 +729,7 @@ static int navi10_set_default_dpm_table(struct smu_context *smu)
return 0; return 0;
} }
static int navi10_dpm_set_uvd_enable(struct smu_context *smu, bool enable) static int navi10_dpm_set_vcn_enable(struct smu_context *smu, bool enable)
{ {
struct smu_power_context *smu_power = &smu->smu_power; struct smu_power_context *smu_power = &smu->smu_power;
struct smu_power_gate *power_gate = &smu_power->power_gate; struct smu_power_gate *power_gate = &smu_power->power_gate;
...@@ -2429,7 +2429,7 @@ static const struct pptable_funcs navi10_ppt_funcs = { ...@@ -2429,7 +2429,7 @@ static const struct pptable_funcs navi10_ppt_funcs = {
.get_workload_type = navi10_get_workload_type, .get_workload_type = navi10_get_workload_type,
.get_allowed_feature_mask = navi10_get_allowed_feature_mask, .get_allowed_feature_mask = navi10_get_allowed_feature_mask,
.set_default_dpm_table = navi10_set_default_dpm_table, .set_default_dpm_table = navi10_set_default_dpm_table,
.dpm_set_uvd_enable = navi10_dpm_set_uvd_enable, .dpm_set_vcn_enable = navi10_dpm_set_vcn_enable,
.dpm_set_jpeg_enable = navi10_dpm_set_jpeg_enable, .dpm_set_jpeg_enable = navi10_dpm_set_jpeg_enable,
.get_current_clk_freq_by_table = navi10_get_current_clk_freq_by_table, .get_current_clk_freq_by_table = navi10_get_current_clk_freq_by_table,
.print_clk_levels = navi10_print_clk_levels, .print_clk_levels = navi10_print_clk_levels,
......
...@@ -349,7 +349,7 @@ static enum amd_pm_state_type renoir_get_current_power_state(struct smu_context ...@@ -349,7 +349,7 @@ static enum amd_pm_state_type renoir_get_current_power_state(struct smu_context
return pm_type; return pm_type;
} }
static int renoir_dpm_set_uvd_enable(struct smu_context *smu, bool enable) static int renoir_dpm_set_vcn_enable(struct smu_context *smu, bool enable)
{ {
struct smu_power_context *smu_power = &smu->smu_power; struct smu_power_context *smu_power = &smu->smu_power;
struct smu_power_gate *power_gate = &smu_power->power_gate; struct smu_power_gate *power_gate = &smu_power->power_gate;
...@@ -929,7 +929,7 @@ static const struct pptable_funcs renoir_ppt_funcs = { ...@@ -929,7 +929,7 @@ static const struct pptable_funcs renoir_ppt_funcs = {
.get_dpm_clk_limited = renoir_get_dpm_clk_limited, .get_dpm_clk_limited = renoir_get_dpm_clk_limited,
.print_clk_levels = renoir_print_clk_levels, .print_clk_levels = renoir_print_clk_levels,
.get_current_power_state = renoir_get_current_power_state, .get_current_power_state = renoir_get_current_power_state,
.dpm_set_uvd_enable = renoir_dpm_set_uvd_enable, .dpm_set_vcn_enable = renoir_dpm_set_vcn_enable,
.dpm_set_jpeg_enable = renoir_dpm_set_jpeg_enable, .dpm_set_jpeg_enable = renoir_dpm_set_jpeg_enable,
.get_current_clk_freq_by_table = renoir_get_current_clk_freq_by_table, .get_current_clk_freq_by_table = renoir_get_current_clk_freq_by_table,
.force_dpm_limit_value = renoir_force_dpm_limit_value, .force_dpm_limit_value = renoir_force_dpm_limit_value,
......
...@@ -722,7 +722,7 @@ static int sienna_cichlid_set_default_dpm_table(struct smu_context *smu) ...@@ -722,7 +722,7 @@ static int sienna_cichlid_set_default_dpm_table(struct smu_context *smu)
return 0; return 0;
} }
static int sienna_cichlid_dpm_set_uvd_enable(struct smu_context *smu, bool enable) static int sienna_cichlid_dpm_set_vcn_enable(struct smu_context *smu, bool enable)
{ {
struct smu_power_context *smu_power = &smu->smu_power; struct smu_power_context *smu_power = &smu->smu_power;
struct smu_power_gate *power_gate = &smu_power->power_gate; struct smu_power_gate *power_gate = &smu_power->power_gate;
...@@ -2602,7 +2602,7 @@ static const struct pptable_funcs sienna_cichlid_ppt_funcs = { ...@@ -2602,7 +2602,7 @@ static const struct pptable_funcs sienna_cichlid_ppt_funcs = {
.get_workload_type = sienna_cichlid_get_workload_type, .get_workload_type = sienna_cichlid_get_workload_type,
.get_allowed_feature_mask = sienna_cichlid_get_allowed_feature_mask, .get_allowed_feature_mask = sienna_cichlid_get_allowed_feature_mask,
.set_default_dpm_table = sienna_cichlid_set_default_dpm_table, .set_default_dpm_table = sienna_cichlid_set_default_dpm_table,
.dpm_set_uvd_enable = sienna_cichlid_dpm_set_uvd_enable, .dpm_set_vcn_enable = sienna_cichlid_dpm_set_vcn_enable,
.dpm_set_jpeg_enable = sienna_cichlid_dpm_set_jpeg_enable, .dpm_set_jpeg_enable = sienna_cichlid_dpm_set_jpeg_enable,
.get_current_clk_freq_by_table = sienna_cichlid_get_current_clk_freq_by_table, .get_current_clk_freq_by_table = sienna_cichlid_get_current_clk_freq_by_table,
.print_clk_levels = sienna_cichlid_print_clk_levels, .print_clk_levels = sienna_cichlid_print_clk_levels,
......
...@@ -157,8 +157,8 @@ static inline int smu_send_smc_msg(struct smu_context *smu, enum smu_message_typ ...@@ -157,8 +157,8 @@ static inline int smu_send_smc_msg(struct smu_context *smu, enum smu_message_typ
#define smu_get_current_shallow_sleep_clocks(smu, clocks) \ #define smu_get_current_shallow_sleep_clocks(smu, clocks) \
((smu)->ppt_funcs->get_current_shallow_sleep_clocks ? (smu)->ppt_funcs->get_current_shallow_sleep_clocks((smu), (clocks)) : 0) ((smu)->ppt_funcs->get_current_shallow_sleep_clocks ? (smu)->ppt_funcs->get_current_shallow_sleep_clocks((smu), (clocks)) : 0)
#define smu_dpm_set_uvd_enable(smu, enable) \ #define smu_dpm_set_vcn_enable(smu, enable) \
((smu)->ppt_funcs->dpm_set_uvd_enable ? (smu)->ppt_funcs->dpm_set_uvd_enable((smu), (enable)) : 0) ((smu)->ppt_funcs->dpm_set_vcn_enable ? (smu)->ppt_funcs->dpm_set_vcn_enable((smu), (enable)) : 0)
#define smu_dpm_set_jpeg_enable(smu, enable) \ #define smu_dpm_set_jpeg_enable(smu, enable) \
((smu)->ppt_funcs->dpm_set_jpeg_enable ? (smu)->ppt_funcs->dpm_set_jpeg_enable((smu), (enable)) : 0) ((smu)->ppt_funcs->dpm_set_jpeg_enable ? (smu)->ppt_funcs->dpm_set_jpeg_enable((smu), (enable)) : 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment