Commit fa24b7f2 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] ext3 journalled quota locking fix

From: Jan Kara <jack@ucw.cz>

I've attached a fix for a problem in ext3 journalled quota patch - the problem
is that detecting whether dqput() sleeps was wrong and so we could possibly
schedule when holding a spinlock.
parent 10c189cd
...@@ -642,7 +642,7 @@ static void add_dquot_ref(struct super_block *sb, int type) ...@@ -642,7 +642,7 @@ static void add_dquot_ref(struct super_block *sb, int type)
/* Return 0 if dqput() won't block (note that 1 doesn't necessarily mean blocking) */ /* Return 0 if dqput() won't block (note that 1 doesn't necessarily mean blocking) */
static inline int dqput_blocks(struct dquot *dquot) static inline int dqput_blocks(struct dquot *dquot)
{ {
if (atomic_read(&dquot->dq_count) <= 1 && dquot_dirty(dquot)) if (atomic_read(&dquot->dq_count) <= 1)
return 1; return 1;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment