Commit fa34aea6 authored by Jan Harkes's avatar Jan Harkes Committed by Linus Torvalds

[PATCH] coda: make global code static

The patch below makes some needlessly global code static.
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarJan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9db7f451
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include <linux/coda_fs_i.h> #include <linux/coda_fs_i.h>
#include <linux/coda_psdev.h> #include <linux/coda_psdev.h>
inline int coda_fideq(struct CodaFid *fid1, struct CodaFid *fid2) static inline int coda_fideq(struct CodaFid *fid1, struct CodaFid *fid2)
{ {
return memcmp(fid1, fid2, sizeof(*fid1)) == 0; return memcmp(fid1, fid2, sizeof(*fid1)) == 0;
} }
......
...@@ -55,7 +55,7 @@ int coda_fsync(struct file *, struct dentry *dentry, int datasync); ...@@ -55,7 +55,7 @@ int coda_fsync(struct file *, struct dentry *dentry, int datasync);
int coda_hasmknod; int coda_hasmknod;
struct dentry_operations coda_dentry_operations = static struct dentry_operations coda_dentry_operations =
{ {
.d_revalidate = coda_dentry_revalidate, .d_revalidate = coda_dentry_revalidate,
.d_delete = coda_dentry_delete, .d_delete = coda_dentry_delete,
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
/* if CODA_STORE fails with EOPNOTSUPP, venus clearly doesn't support /* if CODA_STORE fails with EOPNOTSUPP, venus clearly doesn't support
* CODA_STORE/CODA_RELEASE and we fall back on using the CODA_CLOSE upcall */ * CODA_STORE/CODA_RELEASE and we fall back on using the CODA_CLOSE upcall */
int use_coda_close; static int use_coda_close;
static ssize_t static ssize_t
coda_file_read(struct file *coda_file, char __user *buf, size_t count, loff_t *ppos) coda_file_read(struct file *coda_file, char __user *buf, size_t count, loff_t *ppos)
......
...@@ -89,7 +89,7 @@ static int coda_remount(struct super_block *sb, int *flags, char *data) ...@@ -89,7 +89,7 @@ static int coda_remount(struct super_block *sb, int *flags, char *data)
} }
/* exported operations */ /* exported operations */
struct super_operations coda_super_operations = static struct super_operations coda_super_operations =
{ {
.alloc_inode = coda_alloc_inode, .alloc_inode = coda_alloc_inode,
.destroy_inode = coda_destroy_inode, .destroy_inode = coda_destroy_inode,
......
...@@ -41,35 +41,22 @@ static struct ctl_table_header *fs_table_header; ...@@ -41,35 +41,22 @@ static struct ctl_table_header *fs_table_header;
#define CODA_CACHE_INV 9 /* cache invalidation statistics */ #define CODA_CACHE_INV 9 /* cache invalidation statistics */
#define CODA_FAKE_STATFS 10 /* don't query venus for actual cache usage */ #define CODA_FAKE_STATFS 10 /* don't query venus for actual cache usage */
static ctl_table coda_table[] = {
{CODA_TIMEOUT, "timeout", &coda_timeout, sizeof(int), 0644, NULL, &proc_dointvec},
{CODA_HARD, "hard", &coda_hard, sizeof(int), 0644, NULL, &proc_dointvec},
{CODA_VFS, "vfs_stats", NULL, 0, 0644, NULL, &do_reset_coda_vfs_stats},
{CODA_CACHE_INV, "cache_inv_stats", NULL, 0, 0644, NULL, &do_reset_coda_cache_inv_stats},
{CODA_FAKE_STATFS, "fake_statfs", &coda_fake_statfs, sizeof(int), 0600, NULL, &proc_dointvec},
{ 0 }
};
static ctl_table fs_table[] = {
{FS_CODA, "coda", NULL, 0, 0555, coda_table},
{0}
};
struct coda_vfs_stats coda_vfs_stat; struct coda_vfs_stats coda_vfs_stat;
struct coda_cache_inv_stats coda_cache_inv_stat; static struct coda_cache_inv_stats coda_cache_inv_stat;
void reset_coda_vfs_stats( void ) static void reset_coda_vfs_stats( void )
{ {
memset( &coda_vfs_stat, 0, sizeof( coda_vfs_stat ) ); memset( &coda_vfs_stat, 0, sizeof( coda_vfs_stat ) );
} }
void reset_coda_cache_inv_stats( void ) static void reset_coda_cache_inv_stats( void )
{ {
memset( &coda_cache_inv_stat, 0, sizeof( coda_cache_inv_stat ) ); memset( &coda_cache_inv_stat, 0, sizeof( coda_cache_inv_stat ) );
} }
int do_reset_coda_vfs_stats( ctl_table * table, int write, struct file * filp, static int do_reset_coda_vfs_stats( ctl_table * table, int write,
void __user * buffer, size_t * lenp, loff_t * ppos ) struct file * filp, void __user * buffer,
size_t * lenp, loff_t * ppos )
{ {
if ( write ) { if ( write ) {
reset_coda_vfs_stats(); reset_coda_vfs_stats();
...@@ -82,8 +69,9 @@ int do_reset_coda_vfs_stats( ctl_table * table, int write, struct file * filp, ...@@ -82,8 +69,9 @@ int do_reset_coda_vfs_stats( ctl_table * table, int write, struct file * filp,
return 0; return 0;
} }
int do_reset_coda_cache_inv_stats( ctl_table * table, int write, static int do_reset_coda_cache_inv_stats( ctl_table * table, int write,
struct file * filp, void __user * buffer, struct file * filp,
void __user * buffer,
size_t * lenp, loff_t * ppos ) size_t * lenp, loff_t * ppos )
{ {
if ( write ) { if ( write ) {
...@@ -97,8 +85,8 @@ int do_reset_coda_cache_inv_stats( ctl_table * table, int write, ...@@ -97,8 +85,8 @@ int do_reset_coda_cache_inv_stats( ctl_table * table, int write,
return 0; return 0;
} }
int coda_vfs_stats_get_info( char * buffer, char ** start, off_t offset, static int coda_vfs_stats_get_info( char * buffer, char ** start,
int length) off_t offset, int length)
{ {
int len=0; int len=0;
off_t begin; off_t begin;
...@@ -158,8 +146,8 @@ int coda_vfs_stats_get_info( char * buffer, char ** start, off_t offset, ...@@ -158,8 +146,8 @@ int coda_vfs_stats_get_info( char * buffer, char ** start, off_t offset,
return len; return len;
} }
int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset, static int coda_cache_inv_stats_get_info( char * buffer, char ** start,
int length) off_t offset, int length)
{ {
int len=0; int len=0;
off_t begin; off_t begin;
...@@ -196,6 +184,20 @@ int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset, ...@@ -196,6 +184,20 @@ int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset,
return len; return len;
} }
static ctl_table coda_table[] = {
{CODA_TIMEOUT, "timeout", &coda_timeout, sizeof(int), 0644, NULL, &proc_dointvec},
{CODA_HARD, "hard", &coda_hard, sizeof(int), 0644, NULL, &proc_dointvec},
{CODA_VFS, "vfs_stats", NULL, 0, 0644, NULL, &do_reset_coda_vfs_stats},
{CODA_CACHE_INV, "cache_inv_stats", NULL, 0, 0644, NULL, &do_reset_coda_cache_inv_stats},
{CODA_FAKE_STATFS, "fake_statfs", &coda_fake_statfs, sizeof(int), 0600, NULL, &proc_dointvec},
{ 0 }
};
static ctl_table fs_table[] = {
{FS_CODA, "coda", NULL, 0, 0555, coda_table},
{0}
};
#ifdef CONFIG_PROC_FS #ifdef CONFIG_PROC_FS
...@@ -207,7 +209,7 @@ int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset, ...@@ -207,7 +209,7 @@ int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset,
*/ */
struct proc_dir_entry* proc_fs_coda; static struct proc_dir_entry* proc_fs_coda;
#endif #endif
......
...@@ -72,26 +72,5 @@ struct coda_cache_inv_stats ...@@ -72,26 +72,5 @@ struct coda_cache_inv_stats
/* these global variables hold the actual statistics data */ /* these global variables hold the actual statistics data */
extern struct coda_vfs_stats coda_vfs_stat; extern struct coda_vfs_stats coda_vfs_stat;
extern struct coda_cache_inv_stats coda_cache_inv_stat;
/* reset statistics to 0 */
void reset_coda_vfs_stats( void );
void reset_coda_cache_inv_stats( void );
/* like coda_dointvec, these functions are to be registered in the ctl_table
* data structure for /proc/sys/... files
*/
int do_reset_coda_vfs_stats( ctl_table * table, int write, struct file * filp,
void __user * buffer, size_t * lenp, loff_t * ppos );
int do_reset_coda_cache_inv_stats( ctl_table * table, int write,
struct file * filp, void __user * buffer,
size_t * lenp, loff_t * ppos );
/* these functions are called to form the content of /proc/fs/coda/... files */
int coda_vfs_stats_get_info( char * buffer, char ** start, off_t offset,
int length);
int coda_cache_inv_stats_get_info( char * buffer, char ** start, off_t offset,
int length);
#endif /* _CODA_PROC_H */ #endif /* _CODA_PROC_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment