Commit fb90a1c8 authored by Ayush Sawal's avatar Ayush Sawal Committed by David S. Miller

Crypto/chcr: Calculate src and dst sg lengths separately for dma map

This patch calculates src and dst sg lengths separately for
dma mapping in case of aead operation.

This fixes a panic which occurs due to the accessing of a zero
length sg.
Panic:
[  138.173225] kernel BUG at drivers/iommu/intel-iommu.c:1184!
Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 934e36ec
...@@ -2590,11 +2590,22 @@ int chcr_aead_dma_map(struct device *dev, ...@@ -2590,11 +2590,22 @@ int chcr_aead_dma_map(struct device *dev,
struct chcr_aead_reqctx *reqctx = aead_request_ctx(req); struct chcr_aead_reqctx *reqctx = aead_request_ctx(req);
struct crypto_aead *tfm = crypto_aead_reqtfm(req); struct crypto_aead *tfm = crypto_aead_reqtfm(req);
unsigned int authsize = crypto_aead_authsize(tfm); unsigned int authsize = crypto_aead_authsize(tfm);
int dst_size; int src_len, dst_len;
dst_size = req->assoclen + req->cryptlen + (op_type ? /* calculate and handle src and dst sg length separately
0 : authsize); * for inplace and out-of place operations
if (!req->cryptlen || !dst_size) */
if (req->src == req->dst) {
src_len = req->assoclen + req->cryptlen + (op_type ?
0 : authsize);
dst_len = src_len;
} else {
src_len = req->assoclen + req->cryptlen;
dst_len = req->assoclen + req->cryptlen + (op_type ?
-authsize : authsize);
}
if (!req->cryptlen || !src_len || !dst_len)
return 0; return 0;
reqctx->iv_dma = dma_map_single(dev, reqctx->iv, (IV + reqctx->b0_len), reqctx->iv_dma = dma_map_single(dev, reqctx->iv, (IV + reqctx->b0_len),
DMA_BIDIRECTIONAL); DMA_BIDIRECTIONAL);
...@@ -2606,20 +2617,23 @@ int chcr_aead_dma_map(struct device *dev, ...@@ -2606,20 +2617,23 @@ int chcr_aead_dma_map(struct device *dev,
reqctx->b0_dma = 0; reqctx->b0_dma = 0;
if (req->src == req->dst) { if (req->src == req->dst) {
error = dma_map_sg(dev, req->src, error = dma_map_sg(dev, req->src,
sg_nents_for_len(req->src, dst_size), sg_nents_for_len(req->src, src_len),
DMA_BIDIRECTIONAL); DMA_BIDIRECTIONAL);
if (!error) if (!error)
goto err; goto err;
} else { } else {
error = dma_map_sg(dev, req->src, sg_nents(req->src), error = dma_map_sg(dev, req->src,
sg_nents_for_len(req->src, src_len),
DMA_TO_DEVICE); DMA_TO_DEVICE);
if (!error) if (!error)
goto err; goto err;
error = dma_map_sg(dev, req->dst, sg_nents(req->dst), error = dma_map_sg(dev, req->dst,
sg_nents_for_len(req->dst, dst_len),
DMA_FROM_DEVICE); DMA_FROM_DEVICE);
if (!error) { if (!error) {
dma_unmap_sg(dev, req->src, sg_nents(req->src), dma_unmap_sg(dev, req->src,
DMA_TO_DEVICE); sg_nents_for_len(req->src, src_len),
DMA_TO_DEVICE);
goto err; goto err;
} }
} }
...@@ -2637,24 +2651,37 @@ void chcr_aead_dma_unmap(struct device *dev, ...@@ -2637,24 +2651,37 @@ void chcr_aead_dma_unmap(struct device *dev,
struct chcr_aead_reqctx *reqctx = aead_request_ctx(req); struct chcr_aead_reqctx *reqctx = aead_request_ctx(req);
struct crypto_aead *tfm = crypto_aead_reqtfm(req); struct crypto_aead *tfm = crypto_aead_reqtfm(req);
unsigned int authsize = crypto_aead_authsize(tfm); unsigned int authsize = crypto_aead_authsize(tfm);
int dst_size; int src_len, dst_len;
dst_size = req->assoclen + req->cryptlen + (op_type ? /* calculate and handle src and dst sg length separately
0 : authsize); * for inplace and out-of place operations
if (!req->cryptlen || !dst_size) */
if (req->src == req->dst) {
src_len = req->assoclen + req->cryptlen + (op_type ?
0 : authsize);
dst_len = src_len;
} else {
src_len = req->assoclen + req->cryptlen;
dst_len = req->assoclen + req->cryptlen + (op_type ?
-authsize : authsize);
}
if (!req->cryptlen || !src_len || !dst_len)
return; return;
dma_unmap_single(dev, reqctx->iv_dma, (IV + reqctx->b0_len), dma_unmap_single(dev, reqctx->iv_dma, (IV + reqctx->b0_len),
DMA_BIDIRECTIONAL); DMA_BIDIRECTIONAL);
if (req->src == req->dst) { if (req->src == req->dst) {
dma_unmap_sg(dev, req->src, dma_unmap_sg(dev, req->src,
sg_nents_for_len(req->src, dst_size), sg_nents_for_len(req->src, src_len),
DMA_BIDIRECTIONAL); DMA_BIDIRECTIONAL);
} else { } else {
dma_unmap_sg(dev, req->src, sg_nents(req->src), dma_unmap_sg(dev, req->src,
DMA_TO_DEVICE); sg_nents_for_len(req->src, src_len),
dma_unmap_sg(dev, req->dst, sg_nents(req->dst), DMA_TO_DEVICE);
DMA_FROM_DEVICE); dma_unmap_sg(dev, req->dst,
sg_nents_for_len(req->dst, dst_len),
DMA_FROM_DEVICE);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment