Commit fd2c19b2 authored by Michal Hocko's avatar Michal Hocko Committed by Pablo Neira Ayuso

netfilter: x_tables: remove size check

Back in 2002 vmalloc used to BUG on too large sizes.  We are much better
behaved these days and vmalloc simply returns NULL for those.  Remove the
check as it simply not needed and the comment is even misleading.

Link: http://lkml.kernel.org/r/20180131081916.GO21609@dhcp22.suse.czSuggested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 5c487bb9
...@@ -1004,10 +1004,6 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size) ...@@ -1004,10 +1004,6 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
if (sz < sizeof(*info)) if (sz < sizeof(*info))
return NULL; return NULL;
/* Pedantry: prevent them from hitting BUG() in vmalloc.c --RR */
if ((size >> PAGE_SHIFT) + 2 > totalram_pages)
return NULL;
/* __GFP_NORETRY is not fully supported by kvmalloc but it should /* __GFP_NORETRY is not fully supported by kvmalloc but it should
* work reasonably well if sz is too large and bail out rather * work reasonably well if sz is too large and bail out rather
* than shoot all processes down before realizing there is nothing * than shoot all processes down before realizing there is nothing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment