Commit fe0b4867 authored by Linus Walleij's avatar Linus Walleij Committed by Lee Jones

mfd: dm355evm_mps: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent f7d62366
...@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset) ...@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
return status; return status;
if (reg == DM355EVM_MSP_LED) if (reg == DM355EVM_MSP_LED)
msp_led_cache = status; msp_led_cache = status;
return status & MSP_GPIO_MASK(offset); return !!(status & MSP_GPIO_MASK(offset));
} }
static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value) static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment