- 03 Jul, 2011 40 commits
-
-
Edmund Nadolski authored
Additional state machine cleanups: o Remove static functions sci_state_machine_exit_state() and sci_state_machine_enter_state() o Combines sci_base_state_machine_construct() and sci_base_state_machine_start() into a single function, sci_init_sm() o Remove sci_base_state_machine_stop() which is unused. o Kill state_machine.[ch] Signed-off-by:
Edmund Nadolski <edmund.nadolski@intel.com> [fixed too large to inline functions] Signed-off-by:
Dan Williams <dan.j.williams@intel.com>
-
Edmund Nadolski authored
This cleans up several areas of the state machine mechanism: o Rename sci_base_state_machine_change_state to sci_change_state o Remove sci_base_state_machine_get_state function o Rename 'state_machine' struct member to 'sm' in client structs o Shorten the name of request states o Shorten state machine state names as follows: SCI_BASE_CONTROLLER_STATE_xxx to SCIC_xxx SCI_BASE_PHY_STATE_xxx to SCI_PHY_xxx SCIC_SDS_PHY_STARTING_SUBSTATE_xxx to SCI_PHY_SUB_xxx SCI_BASE_PORT_STATE_xxx to SCI_PORT_xxx and SCIC_SDS_PORT_READY_SUBSTATE_xxx to SCI_PORT_SUB_xxx SCI_BASE_REMOTE_DEVICE_STATE_xxx to SCI_DEV_xxx SCIC_SDS_STP_REMOTE_DEVICE_READY_SUBSTATE_xxx to SCI_STP_DEV_xxx SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_xxx to SCI_SMP_DEV_xxx SCIC_SDS_REMOTE_NODE_CONTEXT_xxx_STATE to SCI_RNC_xxx Signed-off-by:Dave Jiang <dave.jiang@intel.com> Signed-off-by:
-
Dave Jiang authored
Newer gcc's are better at identifying "set, but not used" variables. Signed-off-by:
-
Dave Jiang authored
We can call the EFI get_variable service routine directly to retrieve the EFI variable that holds the OEM parameters table. Signed-off-by:
-
Dave Jiang authored
It doesn't look like there is any reason to do a kmalloc. We can do the byte swap in place and avoid the allocation. This allow us to remove a kmalloc and a memcpy. Signed-off-by:
-
Edmund Nadolski authored
Delete code which is no longer used. Signed-off-by:
-
Edmund Nadolski authored
Replace the timeout_timer in the isci_tmf with a call to wait_for_completion_timeout Signed-off-by:
-
Edmund Nadolski authored
Signed-off-by:
-
Edmund Nadolski authored
Signed-off-by:
-
Edmund Nadolski authored
Signed-off-by:
-
Edmund Nadolski authored
Convert the sata_timeout_timer in the scic_sds_phy struct to use a struct sci_timer Signed-off-by:
-
Edmund Nadolski authored
Signed-off-by:
-
Edmund Nadolski authored
Rather than preallocating a list of timers and doling them out at runtime, embed a struct timerlist in each object that needs one. A struct sci_timer interface is introduced to manage the timer cancellation semantics which currently need to guarantee the timer is cancelled while holding spin_lock(ihost->scic_lock). Since the timeout functions also need to acquire the lock it currently prevents the driver from using del_timer_sync() for runtime cancellations. del_timer_sync() is used however before the objects go out of scope. Signed-off-by:
-
Dan Williams authored
Now that any given object type only has one state_machine we can use container_of() to get back to the given state machine owner. Reported-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
Dan Williams authored
Unify rnc start{io|task} handlers and delete the state handler infrastructure. Reported-by: -
Dan Williams authored
Unify rnc suspend/resume handlers and delete the state handlers. Reported-by:
-
Dan Williams authored
Unify rnc destruct handlers and delete the state handler. Reported-by:
-
Dan Williams authored
Unify rnc event handlers and delete the state handler. Reported-by:
-
Dan Williams authored
Unify the handlers and kill the state handler infrastructure. Reported-by:
-
Piotr Sawicki authored
Unify the handlers and kill the state handler implementations. Reported-by:
Piotr Sawicki <piotr.sawicki@intel.com> Signed-off-by:
-
Piotr Sawicki authored
Unused infrastructure. Reported-by:
-
Piotr Sawicki authored
Unify the implementations and remove the state handlers. Reported-by:
-
Piotr Sawicki authored
The handler was never used. Signed-off-by:
-
Piotr Sawicki authored
Implement the stop handlers directly in scic_sds_port_stop() Reported-by:
-
Piotr Sawicki authored
remove the handler from the port state handler table and implement the logic directly in scic_sds_port_start(). Signed-off-by:
-
Piotr Sawicki authored
This conversion was complicated by the fact that the ready state exit routine took unconditional action beyond just stopping the substate machine (like in previous conversions). In order to ensure identical behaviour every state transition needs to be instrumented to catch ready-->!ready transitions and execute scic_sds_port_invalidate_dummy_remote_node() Reported-by:
-
Piotr Sawicki authored
Name the table fields for consistancy and clarity. Signed-off-by:
-
Dan Williams authored
While cleaning up the driver it is very tempting to convert scic_sds_get_* macros to their open coded equivalent. They are all just pointer dereferences *except* scic_sds_phy_get_port() which returns NULL if the phy is assigned to the dummy port. Clarify this by renaming it to phy_get_non_dummy_port(). Signed-off-by: -
Dan Williams authored
Unify the implementations in scic_sds_phy_consume_power_handler(), and kill the state handler plus infrastructure. Reported-by:
-
Dan Williams authored
Unify the implementations in scic_sds_phy_event_handler(), and kill the state handler Reported-by:
-
Dan Williams authored
Unify the implementations in scic_sds_phy_frame_handler(), and kill the state handler Reported-by:
-
Dan Williams authored
Unused infrastructure. Reported-by:
-
Dan Williams authored
Unify the implementations in scic_sds_phy_reset(), and kill the state handler Reported-by:
-
Dan Williams authored
Merge all implementations in scic_sds_phy_stop(), and kill the state handler Reported-by:
-
Dan Williams authored
Implement all handlers in scic_sds_phy_start(), and kill the state handler Reported-by:
-
Adam Gruchala authored
Merged states and substates into one state machine, as we always unconditionally transitioned to the substate machine it was straightforward to enter that substate from the starting state. Reported-by:
Adam Gruchala <adam.gruchala@intel.com> [fixed construction, starting_state_enter, and starting check] Signed-off-by:
-
Dan Williams authored
With these handlers gone the rest of the state handler infrastructure is removed. Added some WARN_ONCEs where previously we would cause NULL pointer dereferences or silently run handlers from a previous state. Reported-by:
-
Dan Williams authored
Unlike the other conversions this only updates scic_sds_io_request_tc_completion() to call the old state handlers directly (with less verbose names). This was done for future patch readability, the implementations have only minor differences for different completion codes. Without a reference to the function name it would be difficult to dicern which state is being updated. Considered changing the order to look up the completion code before the state but that was not a clean conversion either. Reported-by:
-
Dan Williams authored
Unify the implementation in scic_sds_io_request_frame_handler and kill the state handler. Reported-by:
-
Piotr Sawicki authored
Unify the implementation in scic_sds_request_start and kill the state handler. Reported-by:
-
