- 28 Feb, 2015 1 commit
-
-
Arnd Bergmann authored
ak8975 depends on I2C and GPIOLIB, so any symbols that selects ak8975 must have the same dependency, or we get build errors: drivers/iio/magnetometer/ak8975.c: In function 'ak8975_who_i_am': drivers/iio/magnetometer/ak8975.c:393:2: error: implicit declaration of function 'i2c_smbus_read_i2c_block_data' [-Werror=implicit-function-declaration] ret = i2c_smbus_read_i2c_block_data(client, AK09912_REG_WIA1, ^ drivers/iio/magnetometer/ak8975.c: In function 'ak8975_set_mode': drivers/iio/magnetometer/ak8975.c:431:2: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration] ret = i2c_smbus_write_byte_data(data->client, Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Fixes: 57e73a42 ("iio: ak8975: add ak09911 and ak09912 support") Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
- 22 Feb, 2015 1 commit
-
-
Geert Uytterhoeven authored
If CONFIG_PM_SLEEP=n: drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this. Signed-off-by:Geert Uytterhoeven <geert@linux-m68k.org> Acked-by:
Karol Wrona <k.wrona@samsung.com> Signed-off-by:
-
- 14 Feb, 2015 1 commit
-
-
Roberta Dobrescu authored
This patch adds missing 'select' statement for jsa1212 driver. Without regmap_i2c, we get the following error when loading the module: Unknown symbol devm_regmap_init_i2c. Signed-off-by:
Roberta Dobrescu <roberta.dobrescu@gmail.com> Reviewed-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
- 07 Feb, 2015 37 commits
-
-
Chen Weixiang authored
This patch fixes the following warning using sparse - warning: symbol 'libcfs_debug_mb' was not declared. Should it be static? - warning: symbol 'portal_enter_debugger' was not declared. Should it be static? Signed-off-by:
Chen Weixiang <weixiangx.chen@outlook.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Hornung authored
* Fix checkpatch.pl warnings "Fix missing space after return type warning". Signed-off-by:
Michael Hornung <mhornung.linux@gmail.com> Signed-off-by:
-
Fabian Frederick authored
obd_updatemax_lock is only used in class_obd.c Signed-off-by:
Fabian Frederick <fabf@skynet.be> Signed-off-by:
-
Nicholas Mc Guire authored
A few redundant switch cases as well as a redundant if/else within one of the cases was consolidated to a single call. The cases are intentionally retained for documentation purposes. case WIFI_REASSOCREQ,WIFI_PROBEREQ,WIFI_BEACON,WIFI_ACTION all have the same effect - notably the also for WIFI_PROBEREQ where the if/else is executing the same function. These redundant cases could all be dropped and consolidated into the default but probably it is better for documentation/readability to leave them in the switch/case explicitly. Signed-off-by:
Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by:
-
Nicholas Mc Guire authored
The if and the else branch code are identical - so the condition has no effect on the effective code - this patch removes the condition and the duplicated code. Due to this being a fall-through-if here - the first if condition has no effect either - so it also can be removed. struct mlme_priv is thus also no longer needed here. Signed-off-by:
-
Nicholas Mc Guire authored
The if and the else branch code are identical - so the condition has no effect on the effective code - this patch removes the condition and the duplicated code. Signed-off-by:
-
Bilel DRIRA authored
This patch fix checkpatch.pl WARNING: WARNING: braces {} are not necessary for single statement blocks Signed-off-by:Bilel DRIRA <bilel.dr@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
since mixed case names are not encouraged in coding, so those has been changed to their corresponding lowercase version. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
since mixed case names are not encouraged in coding, so those has been changed to their corresponding lowercase version. Signed-off-by:
-
Nicholas Mc Guire authored
A number if/else if/else branches are identical - so the condition has no effect on the effective code and can be significantly simplified - this patch removes the condition and the duplicated code. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Max Perepelitsyn authored
This symbol is never used anywhere else besides sm7xxfb.c Signed-off-by:
Max Perepelitsyn <mperepelitsyn@gmail.com> Tested-by:
-
Oleg Drokin authored
Commit ab909585 ("staging: lustre: Cleanup variable declarations in mdc_enqueue()") broke Lustre flock handling introducing access to uninitialized req variable, leading to bizzare crash in a later call to __req_capsule_offset with invalid pill value. Set req to NULL just for this case as in all other cases req is explicitly initialized with request packing call. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> CC: Srikrishan Malik <srikrishanmalik@gmail.com> Signed-off-by:
-
Patrick Farrell authored
When a group lock with GID=0 is released (put_grouplock is called), an assertion in cl_put_grouplock is hit. We should not allow group lock requests with GID=0, instead we should return -EINVAL. Signed-off-by:
Patrick Farrell <paf@cray.com> Reviewed-on: http://review.whamcloud.com/12459 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5817Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
frank zago <fzago@cray.com> Signed-off-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Lai Siyao authored
Reading directory pages may fail on MDS, in this case client should not cache a non-up-to-date directory page, because it will cause a later read on the same page fail. Signed-off-by:
Lai Siyao <lai.siyao@intel.com> Signed-off-by:
-
Yang Sheng authored
We need to check for an exception entry after radix_tree lookup. Signed-off-by:
Yang Sheng <yang.sheng@intel.com> Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
James Simmons <uja.ornl@gmail.com> Signed-off-by:
-
Frank Zago authored
Since reg->kr_fp can be changed inside the foreach loop, kkuc_groups must be write protected, and not just read protected. This should fix the following oops, which could happen if two different threads simultaneously execute the function, and EPIPE is returned. PID: 24385 TASK: ffff88012da5f500 CPU: 1 COMMAND: "ldlm_cb00_056" #0 [ffff88012db55810] machine_kexec at ffffffff81038f3b #1 [ffff88012db55870] crash_kexec at ffffffff810c59f2 #2 [ffff88012db55940] oops_end at ffffffff8152b7f0 #3 [ffff88012db55970] no_context at ffffffff8104a00b #4 [ffff88012db559c0] __bad_area_nosemaphore at ffffffff8104a295 #5 [ffff88012db55a10] bad_area_nosemaphore at ffffffff8104a363 #6 [ffff88012db55a20] __do_page_fault at ffffffff8104aabf #7 [ffff88012db55b40] do_page_fault at ffffffff8152d73e #8 [ffff88012db55b70] page_fault at ffffffff8152aaf5 [exception RIP: fput+9] RIP: ffffffff8118a509 RSP: ffff88012db55c20 RFLAGS: 00010246 RAX: 00000000ffffffe0 RBX: ffff8800a8ea4fc0 RCX: 0000000000000000 RDX: ffffffffa03c9eb0 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffff88012db55c20 R8: 00000000ffffff0a R9: 00000000fffffffc R10: 0000000000000001 R11: 282064656c696166 R12: ffffffffa03c9c60 R13: ffff88005df240f8 R14: 0000000000000000 R15: ffff88013b4ca000 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 #9 [ffff88012db55c28] libcfs_kkuc_group_put at ffffffffa0388044 [libcfs] [ptlrpc] Signed-off-by:Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
-
wang di authored
It is possible that when fld client is trying to lookup seq on one of MDT, but the connection between the client and the MDT is not being initialized yet, especially during striped dir creation, because client will only send create req to the master MDT, then master MDT will distribute the operation to all of other MDT, instead of client distributing these requests, which will usually trigger the connection. In this case, we will send the fld request to MDT0, since it has all of location information. Signed-off-by:
wang di <di.wang@intel.com> Reviewed-on: http://review.whamcloud.com/11780 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4855Reviewed-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Signed-off-by:
-
Jinshan Xiong authored
In vvp_io_read_lock(), it used to decide if to add read lock by checking lli_has_smd. Accessing lli_has_smd is racy when an empty file is turned into raid0, therefore, it may result in read requests are issued without corresponding lock. Signed-off-by:
Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-on: http://review.whamcloud.com/12139 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5062Reviewed-by:
Bobi Jam <bobijam@gmail.com> Signed-off-by:
-
Niu Yawei authored
In after_reply(), take the rq_lock for changing the rq_resend. Signed-off-by:
Niu Yawei <yawei.niu@intel.com> Reviewed-on: http://review.whamcloud.com/11957 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5633Reviewed-by:
Johann Lombardi <johann.lombardi@intel.com> Signed-off-by:
-
Liang Zhen authored
Portal spreading rotor should be unsigned, otherwise lnet may get negative CPT number and access invalid addresses. Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-on: http://review.whamcloud.com/11936 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5639Reviewed-by:
Amir Shehata <amir.shehata@intel.com> Reviewed-by:
Isaac Huang <he.huang@intel.com> Reviewed-by:
Doug Oucharek <doug.s.oucharek@intel.com> Signed-off-by:
-
Henri Doreau authored
A variable-length structure preceeds llog_rec_tail within an llog block. Thus cr_tail shouldn't be accessed directly as a structure member but its actual location should be computed dynamically. Signed-off-by:
Henri Doreau <henri.doreau@cea.fr> Reviewed-on: http://review.whamcloud.com/11937 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5631Reviewed-by:
jacques-Charles Lafoucriere <jacques-charles.lafoucriere@cea.fr> Reviewed-by:
-
John L. Hammond authored
In init_lustre_lite() ensure that /proc/fs/lustre/llite is removed in case of failure. Generally rework the cleanup code in this function. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Reviewed-on: http://review.whamcloud.com/6420 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3331Reviewed-by:
-
Jinshan Xiong authored
If there exists MGS conf_param to reduce the memory cache max_cached_mb it will fail because dt_exp is not initialized yet. It should just go ahead and configure it because certainly it have enough free LRU slot to deduct ccc_lru_left. Signed-off-by:
-
Liang Zhen authored
A couple of changes to improve aliveness detection: - When LNet received a message, it can determine peer of this message is alive - When LNet received a message from remote network, it can determine router is alive and NI status on router is UP. Signed-off-by:
-
Hongchao Zhang authored
in "class_export_recovery_cleanup", the check of the flag "exp->exp_req_replay_needed" should be protected by "exp_lock". Signed-off-by:
Hongchao Zhang <hongchao.zhang@intel.com> Reviewed-on: http://review.whamcloud.com/10849 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5128Reviewed-by:
-
Li Xi authored
After failure happens and put_pages_back() returns the pages, tracefiled() should not go on itering on the page list. Otherwise, some pages might be accessed illegally. Signed-off-by:
Li Xi <lixi@ddn.com> Signed-off-by:
Jian Yu <jian.yu@intel.com> Reviewed-on: http://review.whamcloud.com/11454 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5126Reviewed-by:
Emoly Liu <emoly.liu@intel.com> Reviewed-by:
-
Asaf Vertz authored
Fixed a coding style error, space prohibited before that '++' Signed-off-by:
Asaf Vertz <asaf.vertz@tandemg.com> Signed-off-by:
-
Asaf Vertz authored
Fixed a coding style error, space prohibited after that '!' Signed-off-by:
-
Oleg Drokin authored
lustre_update.h containts various server-side structures that are not really relevant for the client. Also remove the only user of this file that does not actually need it. Signed-off-by:
-
Li Xi authored
When the time of LRU resizing exceeds waiting period of recalculation, the ldlm daemon will keep on resizing without any interval of rest. That will cause high CPU load. This patch fixes the problem by setting the recalculation timestamp after LRU resizing finishes rather than before it. What is more, an interval of one second is enforced between each recalculation. Signed-off-by:
-
Alexander Boyko authored
Do not allow different type of pages at the same rpc. Signed-off-by:
Alexander Boyko <alexander_boyko@xyratex.com> Signed-off-by:
Vitaly Fertman <vitaly_fertman@xyratex.com> Xyratex-bug-id: MRP-859 Reviewed-on: http://review.whamcloud.com/10930 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3192Reviewed-by:
-
Liang Zhen authored
ptlrpcd_check() always scan all requests on ptlrpc_request_set and try to finish completed requests, this is low efficiency. Even worse, l_wait_event() always checks condition for twice before sleeping and one more time after waking up, which means it will call ptlrpcd_check() for three times in each loop. This patch will move completed requests at the head of list in ptlrpc_check_set(), with this change ptlrpcd_check doesn't need to scan all requests anymore. Signed-off-by:
-
Andreas Ruprecht authored
osc_init() is marked as the module_init function in osc_request.c and is never used anywhere else. Hence, it can (and should) be declared static. sparse also complained about this with the following warning, which is fixed by this patch. andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/ [...] drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: warning: symbol 'osc_init' was not declared. Should it be static? [...] Signed-off-by:
Andreas Ruprecht <rupran@einserver.de> Signed-off-by:
-
Kolbeinn Karlsson authored
Fixed a coding style issue. Signed-off-by:
Kolbeinn Karlsson <kolbeinnkarls@gmail.com> Signed-off-by:
-
Nicholas Mc Guire authored
This is only an API consolidation to make things more readable. Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). Signed-off-by:
Nicholas Mc Guire <der.herr@hofr.at> Signed-off-by:
-
Nicholas Mc Guire authored
The check for return of schedule_timeout() has no effect on the effective control flow of sleep_schedulable() so it can be dropped. Signed-off-by:
-
Nicholas Mc Guire authored
This is only an API consolidation to make things more readable. Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). As msecs_to_jiffies will return > 0 if it is passed a value > 0 the == 0 check is not needed. Signed-off-by:
-
