- 03 Oct, 2011 35 commits
-
-
Roland Vossen authored
Reported-by:
Johannes Berg <johannes@sipsolutions.net> Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
Franky Lin <frankyl@broadcom.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Global variables are undesirable unless they are read only. Removed by instead using an already defined Station Control Block variable in a per-device structure. Reported-by:
-
Roland Vossen authored
Global variables are undesirable unless they are read only. Variables are now maintained in a device specific structure. Reported-by:
-
Arend van Spriel authored
Several callback were implemented without executing any further function calls into the driver. Review feedback indicated that these could be removed. Reported-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
-
Arend van Spriel authored
When the device dies the driver could extract cpu registers on the device to analyze the trap handling on the dongle. As the firmware with this driver is stable this code does not belong in the brcmfmac driver. Reported-by:
-
Arend van Spriel authored
For chip initialisation of the wme parameters a table is used, but it was not marked as constant. Reviewed-by:
-
Arend van Spriel authored
The function is not used in the driver and has been removed. Reviewed-by:
-
Arend van Spriel authored
In the transmit path the field seq_ctrl is filled in, but the fragment number was not properly determined. Reviewed-by:
-
Arend van Spriel authored
The field ht_cap was typed ieee80211_ht_cap from ieee80211.h. This contained little endian annotated field cap_info resulting in sparse endian warnings. It turned out the driver was setting the field, but it was actually never used. Therefore it has been removed. Reported-by:
-
Roland Vossen authored
WAR16165 is only used on older PCI chips, the driver does not support these chips. Reviewed-by:
-
Roland Vossen authored
Moved global vars into a per-device structure. Reviewed-by:
-
Roland Vossen authored
Reviewed-by:
-
Roland Vossen authored
After initialization ('attach'), this struct member always pointed at the same memory as wlc->bsscfg. Reviewed-by: -
Roland Vossen authored
List always had one element. Converted the array to a scalar. Reviewed-by:
-
Roland Vossen authored
Parameter 's2' was unused. Affected function was only used internally to main.c and has been made static and moved above its callers. Reported-by:
-
Arend van Spriel authored
Using a block statement to scope function variables is not common in linux kernel development. Browsed through the brcmsmac to remove those. Reported-by:
-
Paul Gortmaker authored
Since they are assuming it is there implicitly and will fail otherwise with things like: drivers/staging/iio/impedance-analyzer/ad5933.c:816: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’ drivers/staging/iio/adc/ad7280a.c:990: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’ Signed-off-by:
Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:
-
Lu Guanqun authored
include module.h to fix the following compile errors: drivers/staging/intel_sst/intelmid.c:52: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:52: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:52: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/staging/intel_sst/intelmid.c:52: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:53: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:53: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:53: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/staging/intel_sst/intelmid.c:53: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:54: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:54: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:54: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/staging/intel_sst/intelmid.c:54: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:55: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:55: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:55: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/staging/intel_sst/intelmid.c:55: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:56: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:56: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:56: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/staging/intel_sst/intelmid.c:56: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:57: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:57: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:57: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/staging/intel_sst/intelmid.c:57: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:58: error: expected declaration specifiers or '...' before string constant drivers/staging/intel_sst/intelmid.c:58: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:58: warning: type defaults to 'int' in declaration of 'MODULE_SUPPORTED_DEVICE' drivers/staging/intel_sst/intelmid.c:58: warning: function declaration isn't a prototype drivers/staging/intel_sst/intelmid.c:64: error: expected ')' before 'int' drivers/staging/intel_sst/intelmid.c:65: error: expected ')' before string constant drivers/staging/intel_sst/intelmid.c:66: error: expected ')' before numeric constant drivers/staging/intel_sst/intelmid.c:67: error: expected ')' before string constant drivers/staging/intel_sst/intelmid.c:461: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:461: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/staging/intel_sst/intelmid.c:461: warning: parameter names (without types) in function declaration drivers/staging/intel_sst/intelmid.c:475: warning: data definition has no type or storage class drivers/staging/intel_sst/intelmid.c:475: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' drivers/staging/intel_sst/intelmid.c:475: warning: parameter names (without types) in function declaration drivers/staging/intel_sst/intelmid.c: In function 'snd_intelmad_probe': drivers/staging/intel_sst/intelmid.c:859: error: 'THIS_MODULE' undeclared (first use in this function) drivers/staging/intel_sst/intelmid.c:859: error: (Each undeclared identifier is reported only once drivers/staging/intel_sst/intelmid.c:859: error: for each function it appears in.) drivers/staging/intel_sst/intelmid.c: At top level: drivers/staging/intel_sst/intelmid.c:989: error: 'THIS_MODULE' undeclared here (not in a function) Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Lu Guanqun <guanqun.lu@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
-
Jonathan Cameron authored
Part never existed under that name. Ooops Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Jonathan Cameron authored
It's going away. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Signed-off-by:
-
Jonathan Cameron authored
These are now handled through the chan_spec arrays and no one is using them anymore. Signed-off-by:
-
Jonathan Cameron authored
id wasn't used anywhere and st->irq can be removed by simply passing it into the core remove function (trivially available in the two bus implementations). Signed-off-by:
-
Jonathan Cameron authored
Other than a few slight refactorings the local version was pretty standard so replace it and rework to get rid of st->d_size which it setup. Signed-off-by:
-
Jonathan Cameron authored
To my mind, if a gpio is specified in the board file, yet fails to be successfully requested, that is an error condidtion and the driver should not muddle on regardless. This does mean unwinding the gpios on error. Also the free_gpios function is reordered so that it is consistent with the request one (reverse order obviously). This patch is the category of not technically fixing anything, just making the driver be more in line with what a reviewer will expect. Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
IIO_CHAN is being phased out and in this case things are so simple it makes sense to have a local one parameter equivalent. Signed-off-by:
-
Jonathan Cameron authored
Saves on setting the value of address for the simple situation seen in this device. They are already used interchangably to get data from the buffer. Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
This is much cleaner than bouncing through the various structures to get to the same thing. Signed-off-by:
-
Jonathan Cameron authored
Preparation for moving driver out of staging. That macro is a nightmare to maintain so it is going away. Signed-off-by:
-
Jonathan Cameron authored
A few of these had the wrong shifts, which would lead to userspace hacking off the top couple of bits. Also, one part had the wrong accuracy. Signed-off-by:
-
Greg Kroah-Hartman authored
Now that we are in the 3.x days, "2.6" doesn't make sense. Signed-off-by:
-
- 30 Sep, 2011 5 commits
-
-
Marc Dietrich authored
The suspend commands need to be sent using the synchronous method, otherwise the power gets disabled before the messages are transferred. Signed-off-by:
Marc Dietrich <marvin24@gmx.de> [jak@jak-linux.org: Rewrote commit message] Signed-off-by:
Julian Andres Klode <jak@jak-linux.org> Signed-off-by:
-
Julian Andres Klode authored
As the comment indicates, adding that udelay seems to improve the stability of the communication, although it is not known why this is the case. Signed-off-by:
-
Julian Andres Klode authored
Add the includes that are currently missing in nvec.h and nvec.c and reorder them alphabetically. Signed-off-by:
-
Julian Andres Klode authored
I intent to support this code, especially the parts I wrote; and will thus enter as co-maintainer. Signed-off-by:
-
Julian Andres Klode authored
The nvec_power system polls nvec for battery information. In some cases, that part seems to be overloaded and unable to respond fast in which case it sends an incomplete response. We need to mark the transfer as completed, though, in order to prevent endless retries which can kill nvec. Signed-off-by:
-
