- 06 Sep, 2011 40 commits
-
-
Mark Einon authored
Replaced et131x_phy.c magic numbers specifying registers and their values with defines, defined in et131x_phy.h Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Mark Einon authored
The VMI_* set of register defines are not used, and duplicate the set of PHY_* registers from the same file, which are used - hence removing. Signed-off-by:
-
Mark Einon authored
cached_mask_value is only ever assigned, never read. Remove it. Signed-off-by:
-
Mark Einon authored
registry_rx_mem_end is not referenced anywhere in the driver. Signed-off-by:
-
Mark Einon authored
As et131x_adjust_link is called from the phydev in response to a netif_carrier_[on|off], and is the only caller of et131x_mii_check, we don't need to call netif_carrier_[on|off] again. Signed-off-by:
-
Mark Einon authored
The PHY interrupt is now handled by the phy_device, and the equivalent code is present in et131x_adjust_link, called from the phy_device when needed. Signed-off-by:
-
Mark Einon authored
adapter->speed_duplex was never referenced. adapter->registry_phy_coma was always set to zero, even in the vendor driver. Removing all member references and associated dead code. Signed-off-by:
-
Mark Einon authored
The phy device keeps a note of the duplex mode, so use that value instead of duplex mode. Also use the phydev defines for duplex modes, and remove the driver private ones. Signed-off-by:
-
Mark Einon authored
The phy device keeps a note of the link speed, so use that value instead of the driver private one. Also use the phydev defines for link speeds, and remove the driver private ones. adapter->hw_errs was never used, even in the vendor driver, so remove that too. Signed-off-by:
-
Mark Einon authored
I think the kernel style cleanups are done now. Adding myself as a recipient of patches. Signed-off-by:
-
Mark Einon authored
Some of my previous hacking attempts have not been following the rules. All fixes either lines > 80 chars or whitespace corrections (spaces->tabs etc). Signed-off-by:
-
Larry Finger authored
Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Mark Einon authored
Use defines from include/linux/mii.h instead of et131x_phy.h and delete the latter defines. Signed-off-by:
-
Michal Marek authored
Remove dead and unused code in sbecom_inline_linux.h. This also fixes a build failure under Turkish locale, where include/config/modversions.h is incorrectly named as modversIons.h (an unrelated kbuild bug) and the driver tries to needlessly include the empty file. Reported-by:
Serdar KÖYLÜ <s.koylux@gmail.com> Cc: Bob Beers <bob.beers@gmail.com> Signed-off-by:
Michal Marek <mmarek@suse.cz> Signed-off-by:
-
Alexey Khoroshilov authored
If sep_ioctl() is called from a process that does not own current transaction, it unlocks unheld sep->ioctl_mutex and returns -EACCES leaving sep->sep_mutex acquired. The patch fixes the mutex lock-unlock mismatch. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Pelle Windestam authored
Fixed the checkpatch warning about sing simple_strtoul instead of kstrtoul() in panel.c. Signed-off-by:
Pelle Windestam <iceaway@gmail.com> Signed-off-by:
-
Mark Einon authored
Now we are using a phy_device, remove driver functionality that is now handled by the phydev. Signed-off-by:
-
Mark Einon authored
Use the phy_device equivalents instead. Signed-off-by:
-
Mark Einon authored
Handing over ioctls handled by the driver to the phydev. Signed-off-by:
-
Alexey Khoroshilov authored
mei_open() acquires dev->device_lock mutex and try to allocate mei_cl, but if the allocation fails it goes to return statement. As a result dev->device_lock left locked. The patch fixes goto to unlock dev->device_lock mutex on this path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
-
Roland Vossen authored
Substituted macro. Reported-by:
Johannes Berg <johannes@sipsolutions.net> Reported-by:
Joe Perches <joe@perches.com> Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Substituted/removed macro's. Reported-by:
-
Roland Vossen authored
Substituted/removed macro's. Reported-by:
-
Roland Vossen authored
AP support was only partially implemented and never invoked. AP related code sections removed. Reported-by:
-
Roland Vossen authored
Substituted/removed macro's. Reported-by:
-
Roland Vossen authored
Substituted macro's. Reported-by:
-
Roland Vossen authored
Substituted macro's. Reported-by:
-
Arend van Spriel authored
Kconfig options are by default not selected so adding the statement 'default n' to the option is not needed. Reported-by:
-
Arend van Spriel authored
The source file main.c contained several sparse warnings which have been cleaned up. Reported-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Reviewed-by:
Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by:
-
Arend van Spriel authored
Several sparse warning were issued due to missing __user qualifier for brcmfmac variables. This patch adds those. Reported-by:
-
Arend van Spriel authored
Running sparse showed following warning: Using plain integer as NULL pointer. This has been fixed. Reported-by:
-
Arend van Spriel authored
Sparse warning was given when using the extern keyword in the function definition. This patch removes those instances. Reported-by:
-
Roland Vossen authored
Moved, deleted or substituted macro's. Reported-by:
-
Roland Vossen authored
Moved, deleted or substituted macro's. Reported-by:
-
Roland Vossen authored
Moved, deleted or substituted macro's. Reported-by:
-
Roland Vossen authored
Moved, deleted or substituted macro's. Reported-by:
-
Roland Vossen authored
Moved, deleted or substituted macro's. Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Arend van Spriel authored
Cleanup resulted in merging several files and made several symbols local to a source file. These were found by running sparse as it gave the warning: symbol 'foo' was not declared. Should it be static? Reported-by:
-
