- 28 Jan, 2008 40 commits
-
-
Al Viro authored
A couple of places forgot cpu_to_le16() in assignments to that field, even though right next to those in other branches of if-else we do it correctly. Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Al Viro authored
some places in driver forget conversions Signed-off-by:
-
Al Viro authored
bugs galore: * 0xf380 instead of htons(ETH_P_AARP), etc. Works only on l-e. * back in 2.3.20 driver got readb() and friends instead of direct dereferencing of iomem. Somebody got too enthusiatic and replaced ntohs(p->mrx_overflow) with ntohs(read(&p->mrx_overflow) without noticing that (a) the sucker is 16bit and (b) that expression can't possibly be portable anyway (hell, on l-e it's always less than 256, on b-e it's always a multiple of 256). Proper fix is swab16(readw(&p->mrx_overflow) taking into account the conversion done by readw() itself. That crap happened in several places; the same fix applies. * untranslate() assumes little-endian almost everywhere, except for the code checking for IPX/AARP packets; there we forgot ntohs(), so that part only works on big-endian. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
* ->exp_id in bootrec_exp_if is __le16; missing conversion in its use * !(x & y) misspelled as !x & y Signed-off-by:
-
Al Viro authored
it's le32, not le16... Signed-off-by:
-
Al Viro authored
in writerids() we do _not_ byteswap, so we want to access ->opmode as little-endian. Signed-off-by:
-
Al Viro authored
never had been byteswapped, used as host-endian... Signed-off-by:
-
Al Viro authored
On big-endian we end up with swapped first two bytes in packet, due to earlier conversion to host-endian and forgotten conversion back. The code we calculated that host-endian for had been duplicated several time - it finds the 802.11 MAC header length by the first two bytes of packet; taken into a new helper (header_len(__le16 ctl)). Signed-off-by:
-
Al Viro authored
airo_translate_scan() reads BSSListRid directly, does _not_ byteswap and uses ->dBm (__le16) as host-endian. Signed-off-by:
-
Al Viro authored
a) gaplen would better be stored little-endian b) for control packets (shorter than 24-byte header) we ended up with bap_write(ai, hdrlen == 30 ? (const u16*)&gap.gaplen : (const u16*)&gap, 38 - hdrlen, BAP1); passing to card the data past the end of gap (i.e. random stuff from stack) and did _not_ feed the gaplen at the right offset. c) sending the contents of uninitialized fields of struct is Not Nice(tm) either Signed-off-by: -
Al Viro authored
It's only a debugging printk, so it went unnoticed; still, the fix is trivial, so... Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
The struct ieee8021_auth * passed to it comes straight from skb->data without any conversions; members of the struct are little-endian, so we'd better take that into account when doing switch by auth->algorithm, etc. Signed-off-by:
-
Al Viro authored
on some codepaths we forgot to convert to little-endian as we do on the rest of them and as the caller expects from us. Signed-off-by:
-
Al Viro authored
Make it match the on-the-wire endianness, eliminate byteswapping. The only driver that used this sucker (ipw2200) updated. Signed-off-by:
-
John W. Linville authored
Signed-off-by: -
Jan Engelhardt authored
This short patch modifies the IPv4 networking to enable use of the 240.0.0.0/4 (aka "class-E") address space as propsed in the internet draft draft-fuller-240space-00.txt. Signed-off-by:
Jan Engelhardt <jengelh@computergmbh.de> Acked-by:
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Jarek Poplawski authored
White spaces etc. are changed in gen_replace_estimator() to make it similar to others in a file. Signed-off-by:
Jarek Poplawski <jarkao2@gmail.com> Signed-off-by:
-
Stephen Hemminger authored
Get rid of some more sparse warnings. Signed-off-by:
Stephen Hemminger <shemminger@vyatta.com> Signed-off-by:
-
Stephen Hemminger authored
Classifier code cleanup. Get rid of printk wrapper, and fix whitespace and other style stuff reported by checkpatch Signed-off-by:
-
Stephen Hemminger authored
ATM scheduler clean house: * get rid of printk and qdisc_priv() wrapper * split some assignment in if() statements * whitespace and line breaks. Signed-off-by:
-
Stephen Hemminger authored
Get rid of all style things checkpatch warns about, indentation and whitespace. Signed-off-by:
-
Stephen Hemminger authored
Make dsmark work properly with non-linear and cloned skb's Before modifying the header, it needs to check that skb header is writeable. Note: this makes the assumption, that if it queues a good skb then a good skb will come out of the embedded qdisc. Signed-off-by:
-
David S. Miller authored
Based upon a patch by Stephen Hemminger and suggestions from Patrick McHardy. Signed-off-by: -
Stephen Hemminger authored
Remove extraneous macro wrappers for printk and qdisc_priv. Signed-off-by:
-
Stephen Hemminger authored
Get rid of a couple of sparse warnings in IPV6 addrconf code. Signed-off-by:
-
Patrick McHardy authored
The code is already gone for about half a year, the config option has been kept around to select the replacement options for easier upgrades. This seems long enough, people upgrading from older kernels will have to reconfigure a lot anyway. Signed-off-by:
Patrick McHardy <kaber@trash.net> Signed-off-by:
-
Patrick McHardy authored
When the lower device's carrier is off, the macvlan devices's carrier state should be checked to decide whether it needs to be turned off. Currently the lower device's state is checked a second time. This still works, but unnecessarily tries to turn off the carrier when its already off. Signed-off-by:
-
Pavel Emelyanov authored
I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the name is good) to setup the skb proto and merge the paths calling netif_rx() together. [Patrick: Modified to apply on top of my previous patches] Signed-off-by:
Pavel Emelyanov <xemul@openvz.org> Signed-off-by:
-
Patrick McHardy authored
- remove three instances of identical code - remove unnecessary NULL initialization - remove obvious and unnecessary comments Signed-off-by:
-
Patrick McHardy authored
VLAN related mail should go to netdev. Signed-off-by:
-
Patrick McHardy authored
Checkpatch cleanups, consisting mainly of overly long lines and missing spaces. Signed-off-by:
-
Patrick McHardy authored
Signed-off-by:
-
Patrick McHardy authored
Signed-off-by:
-
Patrick McHardy authored
Keep track of the number of VLAN devices in a vlan group. This allows to have the caller sense when the group is going to be destroyed and stop using it, which in turn allows to remove the wrapper around unregister_vlan_dev for the NETDEV_UNREGISTER notifier and avoid iterating over all possible VLAN ids whenever a device in unregistered. Also fix what looks like a use-after-free (but is actually safe since we're holding the RTNL), the real_dev reference should not be dropped while we still use it. Signed-off-by:
-
Patrick McHardy authored
Save two levels of indentation by aborting on error conditions, remove unnecessary initialization to NULL and remove two obvious comments. Signed-off-by:
-
Patrick McHardy authored
- move module init/exit functions to end of file, remove some now unnecessary forward declarations - remove some obvious comments - clean up proc init function and move a proc-related printk there Signed-off-by:
-
Patrick McHardy authored
The GET_VLAN_INGRESS_PRIORITY_CMD/GET_VLAN_EGRESS_PRIORITY_CMD ioctls are not implemented and won't be, new functionality will be added to the netlink interface. Remove the code and make the ioctl handler return -EOPNOTSUPP for unknown commands instead of -EINVAL. Also remove a comment about passing unknown commands to the underlying device, that doesn't make any sense since its a VLAN specific ioctl and if its not implemented here, its implemented nowhere. Signed-off-by:
-
Patrick McHardy authored
- use pr_* functions and common prefix for non-device related messages - remove VLAN_ printk levels - kill lots of useless debugging statements - remove a few unnecessary printks like for double VID registration (already returns -EEXIST) and kill of a number of unnecessary checks in vlan_proc_{add,rem}_dev() that are already performed by the caller Signed-off-by:
-
