- 02 Mar, 2016 40 commits
-
-
Oleg Drokin authored
commit 020ecc6f ("staging: lustre: llite: Remove IS_ERR tests") managed to break one of the converted checks by losing a dereference causing the condition to be wrong and hence leading to a crash later on in case of actual error. IS_ERR_OR_NULL(*inode) got converted into !inode. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> CC: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Greg Kroah-Hartman authored
This reverts commit caa88c26. Turns out that Alpha doesn't define these values :( Reported-by:
kbuild test robot <fengguang.wu@intel.com> Cc: Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove is_tcp_ack_filter() which only returns the value of boolean variable `enabled` by replacing the only call site with the variable `enabled` itself. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Tony Cho authored
This patch removes the unused functions anymore related to the configuration of the bus interface clock speed. Signed-off-by:
Tony Cho <tony.cho@atmel.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
Variables pcgroup_encrypt_val,pccipher_group,pcwpa_version, hold different values at different stages of the execution of connect(), however they are not being used anywhere. Hence, the unused variables have been removed. This was done using Coccinelle. @@ type T; identifier i; constant c; @@ -T i; <... when != i -i = c; ...> Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Rehas Sachdeva authored
This patch removes the checkpatch.pl warning: else is not generally useful after a break or return Signed-off-by:
Rehas Sachdeva <aquannie@gmail.com> Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, the #define, and the link_speed var. Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, the #define, and the channel var. Signed-off-by:
-
Sandhya Bankar authored
Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
The memory allocation functions generates a call stack containing all the context information on failure, so print statements can be removed on failure of these functions. Also remove unwanted {} around if block after removal of these statements. Done using coccinelle: @@ expression e,e1,e2; identifier x; @@ e=\(kmalloc\|kmalloc_array\|kzalloc\| devm_kzalloc\)(...); ...when!=e=e1 if(!e) -{ - \(printk\|DBG_8723A\|pr_err\|CERROR\|DBG_88E\)(...); ( goto x; | return e2; | return; ) -} Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Remove int typecast of offsetof(). As per below coccinelle rule: @@ type T; expression E; @@ - (int)(offsetof(T,E)) + offsetof(T,E) Signed-off-by:
-
Janani Ravichandran authored
Use list_entry() rather than container_of() for nodes of doubly linked lists. Semantic patch used: @A exists@ identifier var; struct list_head *ptr; @@ var = - container_of + list_entry (ptr, ...); Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Anchal Jain authored
Remove space and use tabs for indent the code. Signed-off-by:
Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Tapan Prakash T authored
Fixed checkpatch.pl warning 'Block comments use * on subsequent lines' Signed-off-by:
Tapan Prakash T <tapanprakasht@gmail.com> Signed-off-by:
-
Tapan Prakash T authored
Fixed checkpatch.pl warning space prohibited between function name and open parenthesis '(' Signed-off-by: -
M. Vefa Bicakci authored
This commit corrects two sparse warnings caused by the lack of a __user annotation for the third argument of the libcfs_ioctl_handle function. module.c:165:68: warning: incorrect type in argument 1 (different address spaces) module.c:165:68: expected void [noderef] <asn:1>*arg module.c:165:68: got void *arg module.c:209:47: warning: incorrect type in argument 3 (different address spaces) module.c:209:47: expected void *arg module.c:209:47: got void [noderef] <asn:1>*arg The need to have the __user annotation is supported by the fact that libcfs_ioctl_handle passes its third argument to a helper function (libcfs_ioctl_popdata) which also has a __user annotation for its corresponding argument. Signed-off-by:M. Vefa Bicakci <m.v.b@runbox.com> Signed-off-by:
-
M. Vefa Bicakci authored
This commit corrects the following sparse warning regarding a file_operations structure being non-static and constifies the structure in question as well. warning: symbol 'lprocfs_stats_seq_fops' was not declared. Should it be static? Signed-off-by: -
Bhaktipriya Shridhar authored
Doubly linked lists which are iterated using list_empty and list_entry macros have been replaced with list_for_each_entry_safe macro. This makes the iteration simpler and more readable. This patch replaces the while loop containing list_empty and list_entry with list_for_each_entry_safe. This was done with Coccinelle. @@ expression E1; identifier I1, I2; type T; iterator name list_for_each_entry_safe; @@ T *I1; + T *tmp; ... - while (list_empty(&E1) == 0) + list_for_each_entry_safe (I1, tmp, &E1, I2) { ...when != T *I1; - I1 = list_entry(E1.next, T, I2); ... } Signed-off-by: -
Andreas Dilger authored
The documentation about the return values for lnet_lib_init and lnet_lib_exit was in the old style format. Bring it in sync with the rest of the LNet core. Broken out of patch 16787. Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16787Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Frank Zago <fzago@cray.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Andreas Dilger authored
Make the name of the module_init()/_exit() functions consistently {module_name}_init and {module_name}_exit. Signed-off-by: -
Andreas Dilger authored
Fixup the MODULE_DESCRIPTION for several lustre modules. Some wrongly place the version in the string or they are not descriptive enough. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by:
-
James Simmons authored
For several lustre modules the MODULE_VERSION has the wrong value, located in the wrong place in the source code, or completely missing. This patch brings it up to date. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16729Reviewed-by:
-
Andreas Dilger authored
For LNet selftest module the MODULE_AUTHOR was missing. Add proper OpenSFS authorship. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by:
-
James Simmons authored
Move the MODULE_* field in module.c that belongs to libcfs to the end of the file like it is done for other kernel drivers. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc with flag GFP_ZERO since kmem_alloc_zalloc sets allocated memory to zero. The Coccinelle semantic patch used to make this change is as follows: // <smpl> @@ expression e,f; @@ - kmem_cache_alloc(e, f |__GFP_ZERO) + kmem_cache_zalloc(e, f) // </smpl> Signed-off-by:
-
Oleg Drokin authored
As it is ENABLE_PINGER is never defined, but in reality it's the code that is now compiled out that should be used since all other instances were converted like that too. Signed-off-by:
-
Oleg Drokin authored
Since there's only one call in those if () else branches, the braces are not really necessary. Highlighted by checkpatch. Signed-off-by:
-
Oleg Drokin authored
KMALLOC_MAX_SIZE is always defined in the kernel, so no point in checking for it, just use t directly. Signed-off-by:
-
Oleg Drokin authored
Found with checkpatch. Signed-off-by:
-
Oleg Drokin authored
This mostly fixes checkpatch complaints about "Alignment should match open parenthesis" Signed-off-by:
-
