- 23 Aug, 2011 40 commits
-
-
Thomas Meyer authored
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/Signed-off-by:
Thomas Meyer <thomas@m3y3r.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Thomas Meyer authored
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/Signed-off-by:
-
Thomas Meyer authored
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/Signed-off-by:
-
Alexey Khoroshilov authored
The patch replaces spinlock with mutex. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Randy Dunlap authored
Fix sparse warnings in staging/ft1000/: drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:69:7: warning: obsolete struct initializer, use C99 syntax and make many functions & data static. Examples: drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:65:23: warning: symbol 'fw_entry' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:836:6: warning: symbol 'ft1000_send_cmd' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:1014:6: warning: symbol 'ft1000_proc_drvmsg' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:1788:5: warning: symbol 'ft1000_copy_down_pkt' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2096:6: warning: symbol 'stop_ft1000_card' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2155:19: warning: symbol 'init_ft1000_card' was not declared. Should it be static? rivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c:172:5: warning: symbol 'ft1000_confcheck' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:50:5: warning: symbol 'ft1000ReadProc' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:194:6: warning: symbol 'ft1000InitProc' was not declared. Should it be static? drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:207:6: warning: symbol 'ft1000CleanupProc' was not declared. Should it be static? Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
-
Ben Wright authored
Fixed multiple indentation issues. Signed-off-by:
Benjamin James Wright <bwright.au@gmail.com> Signed-off-by:
-
Julia Lawall authored
Buff is only used as a temporary buffer within the function, so it should be freed before leaving the function in an error case. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ local idexpression x; statement S,S1; expression E; identifier fl; expression *ptr != NULL; @@ x = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...kfree(x)...+> } when any when != true x == NULL x->fl ...> ( if (x == NULL) S1 | if (...) { ... when != x when forall ( return \(0\|<+...x...+>\|ptr\); | * return ...; ) } ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Kevin McKinney authored
This patch fixes a potential memory leak were temp_buff buffer is not being freed when a certain condition is true. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Reviewed-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Kevin McKinney authored
Tool checkpatch.pl reported the following error: extern struct class *bcm_class;" declaration not allowed in .c files. Therefore, I move this declaration into the header "headers.h" file. Signed-off-by:
-
Kevin McKinney authored
Staging: bcm: Fix coding style errors reported by checkpatch.pl Fix multiple warnings and errors reported by checkpatch.pl Signed-off-by: Kevin McKinney<klmckinney1@gmail.com> Reviewed-by:
-
Oleg Nesterov authored
daemonize() is only needed when a user-space task does kernel_thread(). r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need the soon-to-be-deprecated daemonize(). It is the only caller of thread_enter() which actually does the call. Note: - we are going to remove the sigdelset(blocked) code from allow_signal(), this means that without this patch thread_enter() can't work after that. Not to mention daemonize() should be deprecated. - as a side effect, this patch changes ->comm. Hopefully this is fine, and padapter->pnetdev->name probably makes more sense anyway. Signed-off-by:
Oleg Nesterov <oleg@redhat.com> Acked-by:
Matt Fleming <matt.fleming@intel.com> Acked-by:
Tejun Heo <tj@kernel.org> Acked-and-tested-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Dan Carpenter authored
There were some curly braces missing so the original code in wpa_supplicant_ioctl() pretty much always returned -EFAULT without doing anything. Signed-off-by:
-
Manohar Vanga authored
This patch adds a list which keeps track of all registered VME buses. This is required for adding refcounting later to bridge modules, something that is not currently implemented. This is based on the changes introduced by Emilio G. Cota in the patch: https://lkml.org/lkml/2010/10/25/486Signed-off-by:Manohar Vanga <manohar.vanga@cern.ch> Acked-by:
Martyn Welch <martyn.welch@ge.com> Signed-off-by:
-
Manohar Vanga authored
Make PCI dependent functions ([alloc|free]_consistent() in 'vme.c') bridge specific. By removing the dependency of the VME bridge framework on PCI, this patch allows for addition of non-PCI based VME bridges. Signed-off-by:
-
Manohar Vanga authored
Signed-off-by:
-
Seth Jennings authored
The patch fixes two typos in zcache-main.c Signed-off-by:
Seth Jennings <sjenning@linux.vnet.ibm.com> Acked-by:
Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by:
-
Seth Jennings authored
zcache_new_pool() calls kmalloc() with GFP_KERNEL which has __GFP_WAIT set. However, zcache_new_pool() gets called on a stack that holds the swap_lock spinlock, leading to a possible sleep-with-lock situation. The lock is obtained in enable_swap_info(). The patch replaces GFP_KERNEL with GFP_ATOMIC. v2: replace with GFP_ATOMIC, not GFP_IOFS Signed-off-by:
-
Jesper Juhl authored
struct ieee80211_network is fairly large (more than half a kilobyte), so let's pass a pointer instead of passing the entire structure by value when ieee80211_is_54g() and ieee80211_is_shortslot() need to look at a few members. Also remove parentheses around the values being returned from those two functions - 'return' is not a function. Signed-off-by:
Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
Jesper Juhl authored
struct ieee80211_network is fairly large (more than half a kilobyte), so let's pass a pointer instead of passing the entire structure by value when ieee80211_is_54g() and ieee80211_is_shortslot() need to look at a few members. Also remove parentheses around the values being returned from those two functions - 'return' is not a function. Signed-off-by:
-
Julia Lawall authored
Test the just-initialized value rather than some other one. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST}; statement S; @@ x = f(...); ( if (\(x == NULL\|IS_ERR(x)\)) S | *if (\(y == NULL\|IS_ERR(y)\)) { ... when != x return ...; } ) // </smpl> Signed-off-by:
David Chang <dchang@suse.com> Signed-off-by:
-
Tobias Klauser authored
stub.h and vhci.h are missing proper #ifndef/#define header guards, so add them. Signed-off-by:
Tobias Klauser <tklauser@distanz.ch> Signed-off-by:
-
Márton Németh authored
Initial version of USBIP protocol document. Signed-off-by:
matt mooney <mfm@muteddisk.com> Signed-off-by:
-
Tobias Klauser authored
mkdir() could fail, so we should check its return value. Signed-off-by:
-
Akshay Joshi authored
Fix brace positioning and spaces at the start of lines in order to comply with the kernel coding style. Signed-off-by:
Akshay Joshi <me@akshayjoshi.com> Acked-by:
-
Akshay Joshi authored
Remove trailing spaces to comply with the kernel coding style. Signed-off-by:
-
Ruslan Pisarev authored
This is a patch to the smilsub.c file that fixed up comment, braces, whitespaces error found by the checkpatch.pl tools. Signed-off-by:
Ruslan Pisarev <ruslan@rpisarev.org.ua> Signed-off-by:
-
Ruslan Pisarev authored
Remove dead (comment) code in drivers/staging/keucr/smilsub.c Signed-off-by:
-
Ruslan Pisarev authored
Fixed macros in scsiglue.c Signed-off-by:
-
Ruslan Pisarev authored
Fixed brace style in smil.h Signed-off-by:
-
Ruslan Pisarev authored
I fixed whitespace, brace style and commetnt in smscsi.c Signed-off-by:
-
Andres Salomon authored
Use dcon_read and dcon_write; shorter, and understands the dcon_priv struct. This transition was started long ago. This converts the last few i2c_smbus_* callers. Signed-off-by:
Andres Salomon <dilinger@queued.net> Signed-off-by:
-
Andres Salomon authored
The v1 DCONs only existed for XO-1 prototypes (and even then, very very early prototypes). Drop support for v1 DCON. Signed-off-by:
-
Andres Salomon authored
This came from Jordan's original 2007 gxfb_dcon commit. I've never seen or heard of it actually being used. Presumably it was once useful for skipping hardware initialization when reloading the module over and over during driver development.. Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Noah Watkins authored
The global variable "num_devices" is too general to be global. This patch switches the name to be "zram_num_devices". Signed-off-by:
Noah Watkins <noahwatkins@gmail.com> Signed-off-by:
-
Noah Watkins authored
The global variable "devices" is too general to be global. This patch switches the name to be "zram_devices". Signed-off-by:
-
Kalle Valo authored
ath6kl is now in drivers/net/wireless/ath so the staging driver is not supported anymore and should be removed. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by:
-
Ruslan Pisarev authored
I fixed whitespace in drivers/staging/pohmelfs/trans.c Signed-off-by:
-
Aaro Koskinen authored
Replace a global variable with a constant. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Reviewed-by:
-
