- 08 Sep, 2014 24 commits
-
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
Adrian Nicoara <anicoara@uwaterloo.ca> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
-
Sudip Mukherjee authored
fixed sparse warning : context imbalance in 'pause_device' unexpected unlock this patch will generate warning from checkpatch for lines over 80 character , but since those are user-visible strings so it was not modified. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Tested-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Sudip Mukherjee authored
1) removed unused variables 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block 3) removed the call to visor_signalqueue_empty() , this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove. Signed-off-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl,rc,f; constant c; @@ - GOTO(lbl,\(rc\|rc->f\|c\)); - break; + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); - break; + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; @@ if (...) GOTO(lbl,...); +else GOTO(lbl,...); @@ identifier lbl; expression e,e1,e2; @@ if (e) - GOTO(lbl,e1); -else GOTO(lbl,e2); + e1; +else e2; +goto lbl; @@ identifier lbl1,lbl2; expression e,e1,e2; @@ + e1=e2; if (e) - GOTO(lbl1,e1=e2); -GOTO(lbl2,e1=e2); + goto lbl1; +goto lbl2; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Mostyn Bramley-Moore authored
Annotate the lock/unlock pair in lov_stripe_lock/lov_stripe_unlock to avoid sparse warning about a context imbalance. Part of the eudyptula challenge: http://eudyptula-challenge.org/Signed-off-by:
Mostyn Bramley-Moore <mbmcode@gmail.com> Signed-off-by:
-
John L. Hammond authored
Remove the unused files lustre/obdclass/local_storage.[ch]. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Signed-off-by:
-
John L. Hammond authored
Remove the unused function llog_ioctl() and the file lustre/obdclass/llog_ioctl.c. Signed-off-by:
-
John L. Hammond authored
Remove the unused function sptlrpc_conf_target_get_rules() and its supporting functions. Signed-off-by:
-
John L. Hammond authored
In mgc_process_cfg_log() remove code to handle LLOG_CONFIG_ORIG_CTXT. This context is not setup on clients. Signed-off-by:
-
John L. Hammond authored
Remove the unused OBD device methods: obd_brw() obd_cancel() obd_cancel_unused() obd_change_cbdata() obd_create_async() obd_enqueue() obd_enqueue_rqset() obd_extent_calc() obd_llog_connect() obd_llog_finish() obd_llog_init() obd_merge_lvb() obd_pin() obd_pin_observer() obd_ping() obd_precreate() obd_punch() obd_punch_rqset() obd_sync() obd_sync_rqset() obd_unpin() obd_unpin_observer() Signed-off-by: -
John L. Hammond authored
The function mgc_cancel() is never invoked as an OBD device method and is only called directly from mgc_process_log() so remove it. Signed-off-by:
-
John L. Hammond authored
In mdc_setup() and mdc_precleanup() call mdc_llog_init() and mdc_llog_finish() directly rather than through the OBD method wrappers obd_llog_init() and obd_llod_finish(). Simplify the prototypes of mdc_llog_init() and mdc_llog_finish() according to their uses. Signed-off-by:
-
John L. Hammond authored
Remove the unused OBD device methods mdc_pin() and mdc_unpin(). Signed-off-by:
-
John L. Hammond authored
Move the structures defined in lustre/include/obd_ost.h to the one file that uses them (lustre/osc/osc_request.c). Remove the unused function osc_update_enqueue(). Remove the then empty header lustre/include/obd_ost.h. Signed-off-by:
-
John L. Hammond authored
In osc_request.c there is no reason to handle any llog contexts since they are never setup. Remove the functions unused function osc_llog_init() and the obsolete function osc_llog_finish(). Remove the llog cleanup code in osc_disconnect() and osc_precleanup(). Signed-off-by:
-
John L. Hammond authored
Remove the unused OBD device methods: osc_brw() osc_cancel() osc_cancel_unused() osc_change_cbdata() osc_enqueue() osc_punch() osc_sync() and their supporting functions. Signed-off-by: -
John L. Hammond authored
Remove the unused OBD device methods: lov_brw() lov_cancel() lov_cancel_unused() lov_change_cbdata() lov_enqueue() lov_extent_calc() lov_getattr() lov_merge_lvb() lov_punch() lov_setattr() lov_sync() and their supporting functions. In lov_iocontrol() remove the unused cases LL_IOC_LOV_SETSTRIPE and LL_IOC_LOV_SETEA and their supporting functions. Signed-off-by:
-
- 07 Sep, 2014 16 commits
-
-
Loïc Pellegrino authored
Align the prototype of lprocfs_wr_uint() in the declaration with the one used in the definition. The prototype is: int lprocfs_wr_uint(struct file *file, const char __user *buffer, unsigned long count, void *data) In obdclass/lprocfs_status.c But in lustre/include/lprocfs_status.h, the __user annotation is missing for the attribute buffer. The correct prototype is the first one (the definition) since: - This function is eventually called by the write() function pointer of an instance of struct file_operations - In this function, buffer is a parameter of copy_from_user() - Before the commit 73bb1da6, the declaration and the definition had the same prototype, but only the .c has been updated. Correcting this will remove a sparse error and add sparse warnings. This is a task of the Eudyptula challenge. Signed-off-by:Loïc Pellegrino <oort10@gmail.com> Signed-off-by:
-
LABBE Corentin authored
Fix the warning reported by sparse on drivers/staging/lustre/lnet/lnet/router_proc.c warning: incorrect type in argument 4 (different address spaces) The correction is to annotate all user buffer variable by __user Signed-off-by:
LABBE Corentin <clabbe.montjoie@gmail.com> Signed-off-by:
-
Nicolas Thery authored
This patch fixes the following sparse warnings: drivers/staging/rtl8188eu/hal/phy.c:46:5: warning: symbol 'phy_query_bb_reg' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:56:6: warning: symbol 'phy_set_bb_reg' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:129:5: warning: symbol 'phy_query_rf_reg' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:140:6: warning: symbol 'phy_set_rf_reg' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:228:6: warning: symbol 'phy_set_tx_power_level' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:324:6: warning: symbol 'phy_set_bw_mode' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:360:6: warning: symbol 'phy_sw_chnl' was not declared. Should it be static? Signed-off-by:
Nicolas Thery <nthery@gmail.com> Signed-off-by:
-
Andreas Schlick authored
Signed-off-by:
Andreas Schlick <ninox@posteo.net> Signed-off-by:
-
Loic Pefferkorn authored
Coding style: avoid multiple assignments Signed-off-by:
Loic Pefferkorn <loic@loicp.eu> Signed-off-by:
-
Loic Pefferkorn authored
Coding style: document mutex usage Signed-off-by:
-
Loic Pefferkorn authored
Coding style: fix alignment to match open parenthesis Signed-off-by:
-
Loic Pefferkorn authored
Coding style: document spinlock usage Signed-off-by:
-
Loic Pefferkorn authored
Coding style: remove useless space after a cast Signed-off-by:
-
Loic Pefferkorn authored
Coding style: suppress consecutive blank lines Signed-off-by:
-
Michał Bartoszkiewicz authored
This fixes "void function return statements are not generally useful" warnings from checkpatch.pl. Signed-off-by:
Michał Bartoszkiewicz <mbartoszkiewicz@gmail.com> Reviewed-by:
Insop Song <insop.song@gainspeed.com> Signed-off-by:
-
Thomas Gummerer authored
Signed-off-by:
Thomas Gummerer <t.gummerer@gmail.com> Signed-off-by:
-
Filipe Gonçalves authored
Signed-off-by:
Filipe Gonçalves <filipe@codinghighway.com> Signed-off-by:
-
Piotr Witoslawski authored
Break lines exceeding 80 characters Signed-off-by:
Piotr Witoslawski <pwitos@gmail.com> Signed-off-by:
-
Juston Li authored
lmv_internal.h:96: ERROR: space prohibited after that open parenthesis '(' lmv_internal.h:96: ERROR: space required before the open parenthesis '(' lmv_internal.h:147: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by:Juston Li <juston.h.li@gmail.com> Signed-off-by:
-
Chaitra Ramaiah authored
Signed-off-by:
Chaitra Ramaiah <linux.delve@gmail.com> Signed-off-by:
-
