- 05 Apr, 2013 31 commits
-
-
Ian Abbott authored
`comedi_device_init()` is only called from one place (`comedi_alloc_board_minor()`) and the `struct comedi_device` has already been zeroed out by `kzalloc()`. Don't bother zeroing it out again with `memset()`. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ian Abbott authored
In the comedi core module, `comedi_file_info_table[]` is tentatively defined in the .bss section, so will already be zeroed out on initialization. Don't bother zeroing it out again in the module initialization function `comedi_init()`. Signed-off-by:
-
Ian Abbott authored
Do some minimal error checking of the parameters of `comedi_auto_config()`. Just make sure the `hardware_device` and `driver` parameters are non-NULL. Signed-off-by:
-
Alexey Khoroshilov authored
There is no any error handling in dgrp_create_class_sysfs_files(). The patch adds code to check return values and propagate them to dgrp_init_module(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Kurt Kanzenbach authored
The `usbip list -l' command shows your local usb-devices. Example: $ usbip list -l $ Local USB devices $ ================= $ - busid 1-1 (13fe:1d00) $ 1-1:1.0 -> usb-storage $ $ - busid 1-2 (0409:55aa) $ 1-2:1.0 -> hub However this list command doesn't show which device is connected to this busid. Therefore you have to use another tool e.g. lsusb to determine that. This patches adds the possibility to see which device that is. Example: $ usbip list -l $ Local USB devices $ ================= $ - busid 1-1 (13fe:1d00) $ Kingston Technology Company Inc. : DataTraveler 2.0 1GB/4GB Flash Drive / Patriot Xporter 4GB Flash $ 1-1:1.0 -> usb-storage $ $ - busid 1-2 (0409:55aa) $ NEC Corp. : Hub (0409:55aa) $ 1-2:1.0 -> hub If parsable is specified the info will be not printed. Signed-off-by:
Kurt Kanzenbach <ly80toro@cip.cs.fau.de> Signed-off-by:
Stefan Reif <ke42caxa@cip.cs.fau.de> Signed-off-by:
-
Kurt Kanzenbach authored
The command `usbip attach' uses --host for specifing the remote host, while `usbip list' uses --remote. This is confusing and this patch adapts this. In Addition changed the manpage and README accordingly. Before: $ usbip attach --host <host> -b <busid> $ usbip list --remote <host> Now: $ usbip attach --remote <host> -b <busid> $ usbip list --remote <host> Signed-off-by:
-
Kurt Kanzenbach authored
Since the names.c/names.h are taken from another project, some functions which names.c provides aren't used by usbipd. This patch fixes: - removed useless comments - unified debug/error messages by using the macros provided by usbip_common.h - removed unnused code The code cleanup includes: - remove unused data structures - remove code to create them - remove code to access them The file names.c is used to parse the `usb.ids' file. The parser stores a lot of information about usb devices that is never used. The `usb.ids' file has several sections. Some variables (like `lasthut') store the ID of the current section, and those variables are used to decide which section is currently being parsed (i.e. in which data structure the current line will be stored). We removed the code to read those IDs because they are never used anyway. We replaced them by the pseudo-ID `1' (instead of reading the ID from the file) to indicate that the parser is in a section that can be ignored. If the parser is in such a section, the current line (which contains sub-items for this section) is discarded. Signed-off-by:
-
Kurt Kanzenbach authored
Since no usbip_name function is used in usbipd, it's not necessary to parse "usb.ids" file at startup. Signed-off-by:
-
Stefan Reif authored
Call freeaddrinfo when connect/listen fails. Call usbip_host_driver_close on error. Signed-off-by:
-
Kurt Kanzenbach authored
This patch simplified "stub_device_free" cleanup function: - changed return type to void, since the return value is not checked anywhere - kfree is NULL-safe, so removed if statement - deleted debug-message Signed-off-by:
-
Kurt Kanzenbach authored
This for loop is not needed, since STUB_BUSID_OTHER is defined as 0. In Addition added a comment if STUB_BUSID_OTHER changes sometime. Signed-off-by:
-
Kurt Kanzenbach authored
In each if-else case "return" is called. This is why these if-else-statements are useless. Removing them improves understanding and readability. Signed-off-by:
-
Kurt Kanzenbach authored
In each errorcase spin_unlock_irq is called and -EINVAL is returned. To simplify that I created a label called "err" doing that. On Success count will be returned. Signed-off-by:
-
Stefan Reif authored
Fix an indent. Signed-off-by:
-
Stefan Reif authored
Remove broken preprocessor macro "hardware". It is unused and it references an element (pdev in vhci_hcd) that does not exist. Signed-off-by:
-
Kurt Kanzenbach authored
Enumerations for one comment makes no sense. This is why this should be removed. Signed-off-by:
-
Stefan Reif authored
re-indent funtion "pickup_urb_and_free_priv" to improve readability. Signed-off-by:
-
Kurt Kanzenbach authored
Reformat function stub_recv_cmd_unlink() to improve readability. Signed-off-by:
-
Stefan Reif authored
replace numbers in code by ascii text constants as suggested by Dan Carpenter: http://driverdev.linuxdriverproject.org/pipermail/devel/2013-February/035907.htmlSigned-off-by:
-
Dan Carpenter authored
There are some fields in "edata" which have not been cleared. One example is edata.cmd. It leaks uninitialized stack information to the user. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
"cfg_ap_config" has a number of fields which are not cleared before we copy them to the user. I've added a memset() at the beginning to set everything to zero. Signed-off-by:
-
H Hartley Sweeten authored
The simple mA ranges 0 to 20, 4 to 20, and 0 to 32 are fairly common. Introduce them in the comedi core and use them in the drivers. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private range, range_usbdux_ao_range, in this driver and use the comedi provided range_unipolar2_5 instead. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private range, range_ni_S_ai_6143, in this driver and use the comedi provided range_bipolar5 instead. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private range, range_ni_M_622x_ao, in this driver and use the comedi provided range_bipolar10 instead. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private ranges, dt9812_2pt5_a{in,out}_range, in this driver and use the comedi provided range_unipolar2_5 instead. Signed-off-by: -
H Hartley Sweeten authored
Introduce a simple unipolar 0 to 2.5 range, range_unipolar2_5, for use by the comedi drivers. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private ranges, dt9812_10_a{in,out}_range, in this driver and use the comedi provided range_bipolar10 instead. Signed-off-by: -
H Hartley Sweeten authored
Remove the private range, range_das800_ai, in this driver and use the comedi provided range_bipolar5 instead. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private range, range_ao_1, in this driver and use the comedi provided range_bipolar10 instead. Signed-off-by:
-
H Hartley Sweeten authored
Remove the private range, ao_ranges_60xx, in this driver and use the comedi provided range_bipolar10 instead. Signed-off-by:
-
- 03 Apr, 2013 9 commits
-
-
H Hartley Sweeten authored
For aesthetic reasons. rename the local variable 'thisboard' to 'board' throughout the driver. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase private data variable chanBipolar to chan_is_bipolar. Remove the unnecessary comment about it. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase function rtdConvertChanGain() as well as the CamelCase parameters to the function. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase struct rtdBoard to rtd_boardinfo. Also, rename the range10Start and rangeUniStart variables in the struct to range_bip10 and range_uni10. Signed-off-by:
-
H Hartley Sweeten authored
Rename this private data variable to ai_count. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase local variable fifoStatus to fifo_status. Also rename the goto lables abortTransfer and transferDone to xfer_abort and xfer_done. Signed-off-by:
-
H Hartley Sweeten authored
Rename this private data variable to fifosz. Signed-off-by:
-
H Hartley Sweeten authored
Rename this private data variable to xfer_count. Signed-off-by:
-
H Hartley Sweeten authored
Rename this private data variable to ao_readback and remove the unnecessary comments. Signed-off-by:
-
