Commits · 66af0d7e80fb55c6811ee289e777c8a8d69ce494 · nexedi / linux

16 Sep, 2011 40 commits

staging: brcm80211: fixed sparse endianness warnings on fullmac scan pars · 66af0d7e

Roland Vossen authored Sep 16, 2011

Three structures that are sent to the dongle have been annotated for correct
endianness:  struct brcmf_iscan_params, brcmf_scan_params,
brcmf_cfg80211_scan_req.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

66af0d7e

staging: brcm80211: removed set_fs/get_fs/get_ds calls from brcmf_dev_ioctl() · 90b3b115

Roland Vossen authored Sep 16, 2011

brcmf_dev_ioctl() does not provide a user space buffer to
brcmf_netdev_ioctl_priv. Hence these calls are not necessary.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

90b3b115

staging: brcm80211: simplified brcmf_proto_ioctl() · 862c307f

Roland Vossen authored Sep 16, 2011

Removed a function parameter since it was redundant.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

862c307f

staging: brcm80211: remove global variable brcmf_radio_up from fullmac · bb450766

Franky Lin authored Sep 16, 2011

Remove unnecessary global variable
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

bb450766

staging: brcm80211: remove global variable brcmf_roam from fullmac · 24d7d5e8

Franky Lin authored Sep 16, 2011

Remove unnecessary global variable
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

24d7d5e8

staging: brcm80211: remove fullmac module_param for packet filter feature · 82553d9b

Franky Lin authored Sep 16, 2011

Use constant values for packet filter configuration
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

82553d9b

staging: brcm80211: remove fullmac module_param brcmf_deferred_tx · 818cf60e

Franky Lin authored Sep 16, 2011

Remove brcmf_deferred_tx as it should be always 1
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

818cf60e

staging: brcm80211: remove fullmac module_param sd_f2_blocksize · 6760e1ba

Franky Lin authored Sep 16, 2011

Replaced the global variable with macro.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6760e1ba

staging: brcm80211: remove SOFTAP code from fullmac · e61a8fd5

Franky Lin authored Sep 16, 2011

Dead code removal.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e61a8fd5

drivers/staging/mei/interface.c: take size of pointed value, not pointer · c0569981

Julia Lawall authored Sep 16, 2011

Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression *e;
type T;
identifier f;
@@

f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c0569981

Staging: cx25821: cx25821-video.h: Fix long lines · 661d3bf6

Leonid V. Fedorenchik authored Sep 16, 2011

Fix long function prototypes and line up arguments nicely.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

661d3bf6

Staging: cx25821: cx25821-video.h: Fix indent · 64eb3244

Leonid V. Fedorenchik authored Sep 16, 2011

Fix indent of function arguments.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

64eb3244

Staging: cx25821: cx25821-video.h: Line up constant · 9ad6902d

Leonid V. Fedorenchik authored Sep 16, 2011

Line up integer constant with others.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

9ad6902d

Staging: cx25821: Replace :? by if-else in cx25821-video.c · 3038f638

Leonid V. Fedorenchik authored Sep 16, 2011

Replace :? operator by equivalent if-else statement where in improves
readability. Don't add else branch if it is not needed.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3038f638

Staging: cx25821: Fix braces around statements in cx25821-video.c · e313e1f9

Leonid V. Fedorenchik authored Sep 16, 2011

Delete braces around single statements.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e313e1f9

Staging: cx25821: Change indent with spaces to tabs 35 · 527db49d

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

527db49d

Staging: cx25821: Change indent with spaces to tabs 34 · fa7ce1f4

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

fa7ce1f4

Staging: cx25821: Change indent with spaces to tabs 33 · d2a167c8

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

d2a167c8

Staging: cx25821: Change indent with spaces to tabs 32 · 2a51749f

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2a51749f

Staging: cx25821: Change indent with spaces to tabs 31 · 12fe746f

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

12fe746f

Staging: cx25821: Change indent with spaces to tabs 30 · 16a81efe

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

16a81efe

Staging: cx25821: Change indent with spaces to tabs 29 · 5e644014

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

5e644014

Staging: cx25821: Change indent with spaces to tabs 28 · f9ef6be3

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f9ef6be3

Staging: cx25821: Change indent with spaces to tabs 27 · 43be3824

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

43be3824

Staging: cx25821: Change indent with spaces to tabs 26 · 6f87cc6c

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6f87cc6c

Staging: cx25821: Change indent with spaces to tabs 25 · 75965b8f

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

75965b8f

Staging: cx25821: Change indent with spaces to tabs 24 · 8a911ed9

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8a911ed9

Staging: cx25821: Change indent with spaces to tabs 23 · e0b871bd

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e0b871bd

Staging: cx25821: Change indent with spaces to tabs 22 · 70e7f145

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

70e7f145

Staging: cx25821: Change indent with spaces to tabs 21 · f9a8150c

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f9a8150c

Staging: cx25821: Change indent with spaces to tabs 20 · 02859b61

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

02859b61

Staging: cx25821: Change indent with spaces to tabs 19 · 6678762a

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6678762a

Staging: cx25821: Change indent with spaces to tabs 18 · 255c040a

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

255c040a

Staging: cx25821: Change indent with spaces to tabs 17 · a39bea3a

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a39bea3a

Staging: cx25821: Change indent with spaces to tabs 16 · eda59eb1

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

eda59eb1

Staging: cx25821: Change indent with spaces to tabs 15 · 3f3d9e4a

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3f3d9e4a

Staging: cx25821: Change indent with spaces to tabs 14 · 21377cdd

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

21377cdd

Staging: cx25821: Change indent with spaces to tabs 13 · 55c37c0d

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

55c37c0d

Staging: cx25821: Change indent with spaces to tabs 12 · 20e8a366

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

20e8a366

Staging: cx25821: Change indent with spaces to tabs 11 · 0bf42c9e

Leonid V. Fedorenchik authored Sep 16, 2011

Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0bf42c9e