- 28 Mar, 2016 40 commits
-
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Change null comparisons of the form x == NULL to !x. This was done using Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Removed Unused macro IS_MAC_ADDRESS_BROADCAST. Grep'd to find occurences. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary return statement. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary semicolon. Coccinelle sementic patch as follows: @r_case@ position p; @@ switch (...) { case ...: ...;@p } @r_default@ position p; @@ switch (...) { default: ...;@p } @r1@ statement S; position p1; position p != {r_case.p, r_default.p}; identifier label; @@ ( label:; | S@p1;@p ) Signed-off-by: -
Edward Lipinsky authored
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by:
Edward Lipinsky <ellipinsky@gmail.com> Signed-off-by:
-
Nik Nyby authored
This fixes a mis-spelled word in a few debug statements. Signed-off-by:
Nik Nyby <nikolas@gnu.org> Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary semicolon.This issue is found by coccinelle script. Signed-off-by:
-
Ben Marsh authored
This patch removes blank lines in r8192U_wx.c that were flagged by checkpatch.pl Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Remove & from function name,when function name passed as an argument to another function. Function name is used as pointer without &. Signed-off-by:
-
Alison Schofield authored
Use * on subsequent lines and trailing */ on a separate line in block comments. Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Use sizeof type *pointer instead of sizeof type. Signed-off-by:
-
Sandhya Bankar authored
Use sizeof type *pointer instead of sizeof type. Signed-off-by:
-
Sandhya Bankar authored
Remove return statement from void function. Signed-off-by:
-
Sandhya Bankar authored
Remove return statement from void function. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary space after cast. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary semicolon.This issue is detected by coccinelle script. Signed-off-by:
-
Sandhya Bankar authored
Add parentheses to complex macro. Signed-off-by:
-
Sandhya Bankar authored
Do not initialise statics to 0. Signed-off-by:
-
Sandhya Bankar authored
Use !x instead of x == NULL. Signed-off-by:
-
Sandhya Bankar authored
Add parentheses to complex macro. Signed-off-by:
-
Sandhya Bankar authored
No space is necessary after cast.This problem is found by checkpatch.pl script. Signed-off-by:
-
Sandhya Bankar authored
No space is necessary after cast.This patch is found by checkpatch.pl script. Signed-off-by:
-
Sandhya Bankar authored
No space is necessary after cast. Signed-off-by:
-
Heena Sirwani authored
The following patch fixes the following checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by:
Heena Sirwani <heenasirwani@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Add space around operator.This patch is found by checkpatch.pl script. Signed-off-by:
-
Dilek Uzulmez authored
Add space around operator '-'. Problem found using checkpatch.pl CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by:
Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Replace 'int32_t' with 'int'. Signed-off-by:
-
Sandhya Bankar authored
Add space around '+'. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary blank lines. Signed-off-by:
-
Sandhya Bankar authored
Fix alignment to match open parenthesis. Signed-off-by:
-
Dilek Uzulmez authored
Add space around operator '+'. Problem found using checkpatch.pl CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by:
-
Joe Perches authored
Use the inline instead of direct code to improve readability and shorten the code a little. Done with perl: $ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1, \2)/g' drivers/staging/skein/threefish_block.c Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Sam Horlbeck Olsen authored
This patch fixes the checkpatch.pl message: CHECK: spaces preferred around that '|' (ctx:VxV) + writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT), ^ ^ As per the guidelines for coding style in the kernel, I have updated the digi international driver to include spaces around the OR'd flags; not only is this formatting issue caught by `checkpatch.pl`, in the next `if` block the correct formatting is used, leading to both incorrect and inconsistent code formatting. This patch puts the line in question at 82 characters---while this is over the recommended limit, there are no clear locations to break the line and it barely breaks the cutoff. Signed-off-by:Sam Horlbeck Olsen <sam.horlsen@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Use !x instead of x == NULL. Signed-off-by:
-
Sandhya Bankar authored
Use !x instead of x == NULL. Signed-off-by:
-
Sandhya Bankar authored
Use x instead of x != NULL. Signed-off-by:
-
Sandhya Bankar authored
Use x instead of x != NULL. Signed-off-by:
-
Nicholas Sim authored
Remove unnecessary return statement from last line of void function call Signed-off-by:
Nicholas Sim <nicholassimws@gmail.com> Signed-off-by:
-
