On Wed, May 05, 2004 at 03:31:02PM -0700, Greg KH wrote:
> On Thu, Apr 29, 2004 at 02:53:01PM -0500, Matt Domsch wrote:
> > a) need this be a warning, wouldn't KERN_DEBUG suffice, if a message
> > is needed at all?  This is printed in pci_generic_prep_mwi().
>
> Yes, we should make that KERN_DEBUG.  I don't have a problem with that.
> Care to make a patch?

Attached is a revised version of rpaphp.patch.  It has the following fixes:
- Set up slot->name
- Kill some dbgs
- Eike's fixes
- New fixes for incorrect "goto" in rpaphp_slot.c.

This fixes allyesconfig

Remove a useless cast: pci_add_new_bus returns a struct pci_bus*, so no need
to cast.

A big bunch of coding style fixes for shpchp_ctrl.c and shpchp_pci.c

Eike

Some small coding style fixes for shpchp_core.c.

Convert shpchp_core.c::init_slots to use goto for error handling.

shpchp is the only driver which does not use a release function for the slot
struct. This adds one and does some minor coding style fixes. Also no one
cares about the return value of cleanup_slots (which is always 0 anyway) so
we can make the function void.

shpchp_core.c::hardware_test is empty. If we remove it we tell the user that
hardware tests are not supported at all.

Convert shpchp_core.c to use new style of module handling.

Eike

Some coding style fixes for rpaphp_pci.c.

Convert rpaphp_slot.c::alloc_slot_struct to use goto for error handling. Also
some small coding style fixes.

Remove two useless NULL checks from rpaphp_core.c

rpaphp_core.c::init_slots is not more than a for loop and is called only from
one place, this inlines the important 3 lines. Als add some __init and __exit.

Some coding style fixes for rpaphp_core.c:
-s/return(foo)/return foo/
-some whitespace fixes
-document function in proper way

Eike

The get_cur_bus_speed function of rpaphp does nothing that the PCI Hotplug Core
would not do by itself if this function does not exist, so just kill it.

The debug parameter of rpaphp is only used as a boolean so we can scan the
commandline of it like a boolean parameter.

This is a bunch of coding style fixes (wrap long lines, whitspacing etc.) for
pciehp_pci.c

This patch does two things:
-remove casts of pointers which are void* or already the correct type for the
 target
-if we dereferenced a struct member and copied this to it's own variable use
 this and don't dereference the member again

Don't know why, but it looks like a good idea to mark this global variables
static.

Some coding style fixes and small cleanups for pciehp_core.c:
-wrap long lines
-kill spaces before opening braces of functions
-remove code duplication where both parts of an if statement do exactly the
 same
-kill some useless comments
-kill an unneeded initialisation

The result of kmalloc does not need to be casted to any other pointer type.
Also use kmalloc(*foo) instead of kmalloc(type_of_foo) and wrap some long
lines.

Some small coding style fixes and a typo fix for pciehp.h

This changes pciehp_core.c::init_slots to use goto for error hanling. Also a
missing magic missed by previous patches is killed.

Remove useless NULL checks from cpqphp_ctrl.c. Under normal circumstances
there is no chance for any of this functions to get called with a NULL
argument. If we are in such trouble that we get a NULL pointer don't hide it,
just oops.

The hardware_test function of the PCI Express Hotplug driver is empty. It's
better to completely kill this to tell the user hardware tests are not
supported by this driver.

This patch removes the cast of kmalloc's results to the target pointer type.
Also it fixes kmalloc to use sizeof(*foo) instead of sizeof(type_of_foo) as
suggested by Matthew Wilcox. Also removes a few useless checks if a pointer
is NULL before calling kfree: kfree checks this itself.

Remove useless NULL checks and magic numbers from rpaphp. If one of these
ever becomes invalid we are in serious trouble anyway.

Remove useless NULL checks and magic numbers from PCI Express Hotplug, also
some minimal coding style fixes.

Doesn't anyone build their patches anymore before sending them out...

Fix missing braces. It does not change the code but makes it easier to read.

This converts PCI Express Hotplug to the new style of module parameter
handling.

Walking through a pci_resource list and freeing all members is done a lot of
times in unload functions. This patch moves this to an inline function in
pciehp_core.c, pciehp_pci.c, shpchp_core.c and shpchp_pci.c. This shrinks the
code a lot (some 200 lines) and makes it much easier to read. Also adds some
__exit.

Convert PCI Hotplug Core to new style of module parameter handling.

Add missing braces around if statement, if not we will try to add devices
for an empty slot.

This patch removes the cast of kmalloc's results to the target pointer type.
Also it fixes kmalloc to use sizeof(*foo) instead of sizeof(type_of_foo) as
suggested by Matthew Wilcox. Also removes a few useless checks if a pointer
is NULL before calling kfree: kfree checks this itself.

Final small fixes for cpqphp_core.c:
-use better error handling in one_time_init
-small coding style fixes
-the name of the driver is not "pci_hotplug"
-add an __exit for unload_cpqphp
-changes enough to increment version, isn't it?