- 07 May, 2018 34 commits
-
-
Sergio Paracuellos authored
New three functions have been created to centralice and simplify calls related with set MIB requests: - hostif_mib_set_request_int - hostif_mib_set_request_bool - hostif_mib_set_request_ostring Using these in different calls simplify functions related with this mainly when types are bool and int because no more conversions are needed in the caller functions. Those conversion details are now located in the new helpers improving a lot readability. Calls in hostif_sme_set_wep function has change also some if's to check invalid value first avoiding one level indentation. Signed-off-by:Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sergio Paracuellos authored
This commit changes parameter types to use enum mib_attribute, enum mib_data_type and size_t for size instead of unsigned short. It also reorder them in a more sense way. Code is updated in different calls to use new parameters order using 'size' auxiliar local variables in some of them to improve readability a bit. Signed-off-by:
-
Sergio Paracuellos authored
This commit changes some type cast in rate related preprocessor definitions included in ks_hostif header file to use preferred u8 type. Signed-off-by:
-
Sergio Paracuellos authored
This commit just change some preprocessor definitions related with MIB attributes into an enumeration which is much cleaner for this here. Also add kerneldoc to avoid long comment lines. Signed-off-by:
-
Sergio Paracuellos authored
This commit just change some preprocessor definitions related with MIB data types into an enumeration which is much cleaner for this here. Signed-off-by:
-
Sergio Paracuellos authored
This commit cleans code for the event SME_MIC_FAILURE_REQUEST changing if logic to handle invalid value first and using a local variable. Signed-off-by:
-
Sergio Paracuellos authored
Header file ks_wlan.h has a lot of nonsense comments along the different declarations included on it. Most of them are just the same as the variable name. Just remove them all. Signed-off-by:
-
Sergio Paracuellos authored
Local variable event in ks_wlan_hw_rx function is declared as unsigned short and can be declared as u16 which is preferred style. Signed-off-by:
-
Sergio Paracuellos authored
Event to send to init the card are always the same so change code to be more readable putting them into an array and enqueuing also using a for loop. Signed-off-by:
-
Sergio Paracuellos authored
Declaration of second parameter 'event' in ks_hostif .h and .c file is different using uint16_t and unsigned short respectively. Just unify both using 'u16' which is preferred instead. Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'byte' in ks7010_sdio_init_irqs is declared as unsigned char and can be declared as u8 which is preferred. It is being used in calls to ks7010_sdio_writeb which is already expected an u8. Signed-off-by:
-
Sergio Paracuellos authored
Local variables 'status', 'rsize' and 'byte' are declared as unsigned char and can be declared as u8 which is preferred. They are being used in ks7010_sdio_readb calls which is already expected an u8. Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'byte' in ks7010_rw_function is declared as unsigned char and can be declared as u8 which is preferred. It is being used in ks7010_sdio_readb which is already expecting an u8. Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'byte' in _ks_wlan_hw_power_save function is declared as unsigned char and can be declared as u8 which is preferred. It is being using with ks7010_sdio_readb which expects u8 already. Signed-off-by:
-
Sergio Paracuellos authored
Parameter buffer in write_to_device function is declared as a pointer to unsigned char and can be declared as an u8 type which is preferred. Internally it calls to ks7010_sdio_write which is using also u8 as parameter type. Update calls to this function as well. Signed-off-by:
-
Sergio Paracuellos authored
Commit 92c1552c removes WPS hardcoded definition and its related conditional preprocessor code. There was some missing stuff already in this files. Remove it. Signed-off-by:
-
Sergio Paracuellos authored
This commit avoids a long line changing a bit message in _ks_wlan_hw_power_save function. Signed-off-by:
-
Sergio Paracuellos authored
ks_wlan_private struct has a pointer to struct ks_sdio_card in its fields. Because of that a forward declaration in needed in ks_wlan.h header and also it makes necessary to have ks_sdio_card public in a ks7010_sdio.h header. Changing this pointer into a void pointer makes no longer necessary to have ks7010_sdio.h header as well as removes the forward dependency in ks_wlan.h. Declaration of ks_sdio_card has been moved to ks7010_sdio.c source file and To make code cleaner inside this file a new ks7010_to_func function has been added. The code has been updated to this changes. Signed-off-by:
-
Sergio Paracuellos authored
There are some definitions for rx and tx queues in ks7010_sdio which is not the best place to put them. Changing them into the ks_wlan header file there is no need to explicity include ks7010_sdio.h which makes no sense at all and can be resolved easily using forward declarations. The functions related with the queues circular buffers have been moved also into this header. Signed-off-by:
-
Sergio Paracuellos authored
It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. Fix up the all of the staging ks7010 files to have a proper SPDX identifier, based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Extra GPL text wording can be removed as it is no longer needed at all. Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistakes in message text and comments "dismatch" -> "mismatch" "Inviation" -> "Invitation" Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Tim Collier authored
Several of the wlan-ng header files had C++-style SPDX comments. Fixed checkpatch warnings by replacing with C-style comments, as per the kernel docs. Signed-off-by:
Tim Collier <osdevtc@gmail.com> Signed-off-by:
-
Tim Collier authored
Fix checkpatch warning due to line break after '(', leaving an over 80 character warning due to long macro name. Signed-off-by: -
Tim Collier authored
Fix checkpatch warning for missing parameter name for function prototype. Signed-off-by:
-
Efstratios Gavas authored
Fixed format/style issues found with checkpatch. No code changes. Corrected alignment of variables after open parenthesis and line breaks. Checkpatch now returns clean except for "line over 80 char" warnings. Signed-off-by:
Efstratios Gavas <xtrat@elg.io> Signed-off-by:
-
Sudip Mukherjee authored
The sm750 driver in staging has no future as new framebuffer driver will not be added to fbdev anymore. A drm driver is being prepared, and the details added to the TODO file. This sm750fb driver will be removed as soon as the drm driver is ready. Also, remove my old email. Cc: dri-devel@lists.freedesktop.org Signed-off-by:
Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by:
-
Vijayanand Jitta authored
An issue is observed where mallocs are failing due to overcommit failure. The failure happens when there is high ION page pool since ION page pool is not considered reclaimable by the overcommit calculation code. This change considers ion pool pages as indirectly reclaimable and thus accounted as available memory in the overcommit calculation. Signed-off-by:
Vijayanand Jitta <vjitta@codeaurora.org> Acked-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Hongchao Zhang authored
In keys_fill, the key_set_version could be changed after the keys are filled, then the keys in this context won't be refilled by the following lu_context_refill for its version is equal to the current key_set_version. In lu_context_refill, the key_set_version should be protected before comparing it to version stored in the lu_context. Signed-off-by:
Hongchao Zhang <hongchao.zhang@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8346 Reviewed-on: https://review.whamcloud.com/26099 Reviewed-on: https://review.whamcloud.com/27448 Reviewed-on: https://review.whamcloud.com/27994Reviewed-by:
Patrick Farrell <paf@cray.com> Reviewed-by:
Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Reviewed-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
John L. Hammond authored
Hoist lu_keys_guard locking out of the for loop in lu_context_exit(). Signed-off-by:
John L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8918 Reviewed-on: https://review.whamcloud.com/24217Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Jinshan Xiong <jinshan.xiong@gmail.com> Reviewed-by:
-
Li Xi authored
Most of the time, keys are never changed. So rwlock might be better for the concurrency of key read. Signed-off-by:
Li Xi <lixi@ddn.com> Signed-off-by:
Gu Zheng <gzheng@ddn.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6800 Reviewed-on: http://review.whamcloud.com/15558Reviewed-by:
Faccini Bruno <bruno.faccini@intel.com> Reviewed-by:
James Simmons <uja.ornl@yahoo.com> Reviewed-by:
-
Doug Oucahrek authored
cmid will be destroyed at OFED if kiblnd_cm_callback return error. if error happen before the end of kiblnd_connect_peer, it will touch destroyed cmid and fail as (o2iblnd_cb.c:1315:kiblnd_connect_peer()) ASSERTION( cmid->device != ((void *)0) ) failed: Signed-off-by:Alexander Boyko <alexander.boyko@seagate.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10015Reviewed-by:
Alexey Lyashkov <c17817@cray.com> Reviewed-by:
Doug Oucharek <dougso@me.com> Reviewed-by:
-
Doug Oucharek authored
The FastReg support in ko2iblnd was not unmapping pool items causing the items to leak. In addition, the mapping code is not growing the pool like we do with FMR. This patch makes sure we are unmapping FastReg pool elements when we are done with them. It also makes sure the pool will grow when we depleat the pool. Signed-off-by:
Doug Oucharek <doug.s.oucharek@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9472 Reviewed-on: https://review.whamcloud.com/27015Reviewed-by:
Andrew Perepechko <andrew.perepechko@seagate.com> Reviewed-by:
-
Wenwen Wang authored
In ll_dir_ioctl(), the object lumv3 is firstly copied from the user space using Its address, i.e., lumv1 = &lumv3. If the lmm_magic field of lumv3 is LOV_USER_MAGIC_V3, lumv3 will be modified by the second copy from the user space. The second copy is necessary, because the two versions (i.e., lov_user_md_v1 and lov_user_md_v3) have different data formats and lengths. However, given that the user data resides in the user space, a malicious user-space process can race to change the data between the two copies. By doing so, the attacker can provide a data with an inconsistent version, e.g., v1 version + v3 data. This can lead to logical errors in the following execution in ll_dir_setstripe(), which performs different actions according to the version specified by the field lmm_magic. This patch rechecks the version field lmm_magic in the second copy. If the version is not as expected, i.e., LOV_USER_MAGIC_V3, an error code will be returned: -EINVAL. Signed-off-by:
Wenwen Wang <wang6495@umn.edu> Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
NeilBrown authored
Rather than storing the name of a namespace in the hash table, store it directly in the namespace. This will allow the hashtable to be changed to use rhashtable. Signed-off-by:
NeilBrown <neilb@suse.com> Reviewed-by:
Andreas Dilger <andreas.dilger@dilger.ca> Signed-off-by:
-
- 03 May, 2018 6 commits
-
-
Ajay Singh authored
Rename 'WILC_WFI_band_2ghz' to avoid mixedcase for variable name. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Signed-off-by:
-
Ajay Singh authored
Rename 'during_ip_time' to 'DURING_IP_TIME_OUT' to have uppercase letter for macros(#define). Signed-off-by:
-
Ajay Singh authored
Make use of is_broadcast_ether_addr() to check if mac address is broadcast address. Remove static 'broadcast', as its not needed after use of is_broadcast_ether_addr(). Signed-off-by:
-
Ajay Singh authored
Cleanup patch to organize macro in a file together after #include statements. Signed-off-by:
-
Ajay Singh authored
Remove the unnecessary file inclusion in the source code. Also follow the convension to first include the system header then project specific header files. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unnecessary code. Signed-off-by:
-
