- 23 Apr, 2018 40 commits
-
-
Jia-Ju Bai authored
prism2_wep_init() is never called in atomic context. prism2_wep_init() is only set as ".init" in struct ieee80211_crypto_ops. The call chains ending up at "->init" function are: [1] ->init() <- ieee80211_wpa_set_encryption() <- ieee80211_wpa_supplicant_ioctl() [2] ->init() <- ieee80211_wx_set_encode_ext_rsl() <- r8192_wx_set_enc_ext() [3] ->init() <- ieee80211_wx_set_encode_rsl() <- r8192_wx_set_enc() ieee80211_wpa_supplicant_ioctl(), r8192_wx_set_enc_ext() and r8192_wx_set_enc() call mutex_lock(), which indicates these functions are not called in atomic context. Despite never getting called from atomic context, prism2_wep_init() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it Signed-off-by:Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jia-Ju Bai authored
ieee80211_tkip_init() is never called in atomic context. ieee80211_tkip_init() is only set as ".init" in struct ieee80211_crypto_ops. The call chains ending up at "->init" function are: [1] ->init() <- ieee80211_wpa_set_encryption() <- ieee80211_wpa_supplicant_ioctl() [2] ->init() <- ieee80211_wx_set_encode_ext_rsl() <- r8192_wx_set_enc_ext() [3] ->init() <- ieee80211_wx_set_encode_rsl() <- r8192_wx_set_enc() ieee80211_wpa_supplicant_ioctl(), r8192_wx_set_enc_ext() and r8192_wx_set_enc() call mutex_lock(), which indicates these functions are not called in atomic context. Despite never getting called from atomic context, ieee80211_tkip_init() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: -
Jia-Ju Bai authored
ieee80211_ccmp_init() is never called in atomic context. ieee80211_ccmp_init() is only set as ".init" in struct ieee80211_crypto_ops. The call chains ending up at "->init" function are: [1] ->init() <- ieee80211_wpa_set_encryption() <- ieee80211_wpa_supplicant_ioctl() [2] ->init() <- ieee80211_wx_set_encode_ext_rsl() <- r8192_wx_set_enc_ext() [3] ->init() <- ieee80211_wx_set_encode_rsl() <- r8192_wx_set_enc() ieee80211_wpa_supplicant_ioctl(), r8192_wx_set_enc_ext() and r8192_wx_set_enc() call mutex_lock(), which indicates these functions are not called in atomic context. Despite never getting called from atomic context, ieee80211_ccmp_init() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by:
-
Joao Dalben authored
Added blank spaces between a plus sign in order to standardize the coding style. Signed-off-by:
Joao Dalben <jhdalben@gmail.com> Signed-off-by:
-
Gabriel Francisco Mandaji authored
Fix most checkpatch.pl issues of type: CHECK: Alignment should match open parenthesis Signed-off-by:
Gabriel Francisco Mandaji <gfmandaji@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Geert Uytterhoeven authored
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI. Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway. This simplifies the dependencies, and allows to improve compile-testing. Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by:
Mark Brown <broonie@kernel.org> Acked-by:
Robin Murphy <robin.murphy@arm.com> Acked-by:
-
Stefan Wahren authored
We need to free the kthreads in error case before leaving vchiq_init_state() otherwise we leak resources. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Stefan Wahren authored
Move all calls of wake_up_process to one point, whichs makes the following implementation of clean-up code easier. Signed-off-by:
-
Stefan Wahren authored
vchiq_initialise() is used in non-interrupt context, so we can replace udelay with usleep_range as suggested by timers-howto.txt. Signed-off-by:
-
Stefan Wahren authored
Multiline dereferences aren't nice to review. So fix this checkpatch warning. Signed-off-by:
-
Stefan Wahren authored
It's better to use the __func__ macro instead of open-code the function name. This fixes the following checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'x', this function's name, in a string Signed-off-by:
-
Stefan Wahren authored
Hiding memset behind a macro isn't the best, because it relies on that the parameter is not a pointer. Luckily all user has been removed, so we can remove BITSET_ZERO too. Signed-off-by:
-
Stefan Wahren authored
This removes the stackhog in process_free_queue by allocating the necessary memory within the recycle thread main function instead of the stack. Signed-off-by:
-
Stefan Wahren authored
The bail out branch in case of a invalid tx_pos missed a semaphore release. Dan Carpenter found this with a static checker. Fixes: d1eab9de ("staging: vchiq_core: Bail out in case of invalid tx_pos") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Daniel Junho authored
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters + vbva = (void __force *)vbox->vbva_buffers + i * VBVA_MIN_BUFFER_SIZE; Signed-off-by:
Daniel Junho <djunho@gmail.com> Signed-off-by:
-
Eyal Ilsar authored
Remove unnecessary braces {} around an 'if' statement block with a single statement. Issue found by checkpatch. Signed-off-by:Eyal Ilsar <edilsar@gmail.com> Reviewed-by:
Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by:
-
Ian Liu Rodrigues authored
Signed-off-by:
Ian Liu Rodrigues <ian.liu88@gmail.com> Signed-off-by:
-
Shannon Booth authored
Some typos and grammar issues were found in the documentation. These mistakes were fixed. Signed-off-by:
Shannon Booth <shannon.ml.booth@gmail.com> Signed-off-by:
-
Valentin Vidic authored
Fixes checkpatch warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by:
Valentin Vidic <Valentin.Vidic@CARNet.hr> Signed-off-by:
-
Simon Sandström authored
Breaks long lines in rf69.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by:
Simon Sandström <simon@nikanor.nu> Signed-off-by:
-
Simon Sandström authored
Breaks long lines in rf69.h, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by:
-
Valentin Vidic authored
pi433_write requires locking due to multiple writers. After acquiring the lock check if enough free space is available in the kfifo to write the whole message. This check should prevent partial writes to tx_fifo so kfifo_reset is not needed anymore. pi433_tx_thread is the only reader so it does not require locking after kfifo_reset is removed. Signed-off-by:
Marcus Wolf <marcus.wolf@wolf-entwicklungen.de> Signed-off-by:
-
Wolfram Sang authored
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Acked-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
-
Gaurav Dhingra authored
Wrap comment to fix warning "prefer a maximum 75 chars per line" Signed-off-by:
Gaurav Dhingra <gauravdhingra.gxyd@gmail.com> Acked-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Reviewed-by:
Mark Greer <mgreer@animalcreek.com> Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The dma_addr field of msdc_host is never used, so remove it. Signed-off-by:
Christian Lütke-Stetzkamp <christian@lkamp.de> Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The cmd_rsp_done field of msdc_host is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The field cmd_r1b_done in msdc_host is unused, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The dma_left_size field of msdc_host is never used, remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The reserved field of msdc_host is never used and msdc_host is also never exposed to hardware, so remove that field. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The starttime field of msdc_host is never used, remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The current default transfer is to use DMA or not depending on the size of the data. The upstream driver mtk-sd uses DMA all times, change the standard mode here to DMA for testing, if there are any performance problems with DMA for small data sizes. If not, the option for transfer mode should be removed in the future, Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The msdc_init_gpd_bd function is currently hard to read, because of old, commented out code and a while loop, where a for loop is much easier to read. Refactor it to make the code more readable. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The xfersz field of msdc_dma is only set to host->xfer_size and this is also available at the (few) positions, where dma.xfersz is used, so it is removed. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The flags of msdc_dma are set to a constant value, so block and dword padding are disabled and checksum is enabled. By removing the field the code is easier to read and the difference to the mtk-sd driver is smaller. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The fields used_gpd|bd in struct msdc_dma are only set and reset, but never used, so remove them. The other removed fields are never used, so they were removed either. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Currently the msdc_dma_config function has some variables, that are not needed, uses the macro msdc_init_bd that is only used here and does not use the for_each_sg iterator. That last fact could cause a bug if the scatterlist is chained. The function is changed to remove these things, but none of the changes should change the behavior of it (despite the case of a linked scatterlist). Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The msdc_dma_dump function is disabled by a preprocessor macro, was only used in the msdc_dma_setup function. The code also contains no information about the device, it only dumps some memory for debug. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The burstsz field in msdc_dma is set to a constant value and later only used two times, using the constant directly in that places allows to remove the field and improves readability. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The data_offset field in msdc_hw is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Current code just busy waits with nop for clock becoming stable, relaxing the cpu here improves readability and portability and also removes a unnecessary difference with the mtk-sd driver. Signed-off-by:
-
