- 08 May, 2018 35 commits
-
-
Christian Gromm authored
The function unregister_chrdev_region is called with a different counter as the alloc_chrdev_region. To fix this, this patch introduces the constant CHRDEV_REGION_SIZE that is used in both functions. Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Christian Gromm authored
This patch avoids the warning that the pointer mbo might be used uninitialized that some environmens throw. Signed-off-by:
-
Christian Gromm authored
This patch is needed as function snd_card_new needs a valid parent device. Passing a NULL pointer leads to kernel Ooops. Signed-off-by:
-
Christian Gromm authored
On arm64/aarch64 architectures the allocation of coherent memory needs a device that has the dma_ops properly set. That's why the core module of the MOST driver is no longer able to allocate this type or memory. This patch moves the allocation process down to the interface drivers where the proper devices exist (e.g. platform device or USB system software). Signed-off-by:
-
Christian Gromm authored
Currently, there are two module parameters for the i2c driver: - polling_req: boolean irq/polling mode; - scan_rate: polling rate, that is used in the case where the polling mode is active This model is misconfiguration-prone. For example, it is possible to select polling mode with the zero polling rate or configure non-zero polling rate in a combination with the IRQ mode. This patch replaces the 'polling_req' and 'scan_rate' by the 'polling_rate', where the value zero means the interrupt driven mode and other values are used as the polling rate in the polling mode. Signed-off-by:Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
-
Christian Gromm authored
The elements of the dev->rx.list are consumed in the pending_rx_work and populated in the function enqueue() that cancels the pending_rx_work. The function enqueue() and poison_channel() do not race anyway. Signed-off-by:
-
Christian Gromm authored
The variable is_open is checked only in the work function pending_rx_work() that is only active between the calls configure_channel() and poison_channel(). Signed-off-by:
-
Christian Gromm authored
The real polling rate depends on the CONFIG_HZ and may differ from the required polling rate. Signed-off-by:
-
Christian Gromm authored
This patch avoids that a configured scan_rate of more than MSEC_PER_SEC might result in a polling delay of zero. Signed-off-by:
-
Christian Gromm authored
This patch prevents the driver from falling back to polling mode in case of IRQ misconfiguration. Signed-off-by:
-
Christian Gromm authored
This patch removes the function wait_event_interruptible from the work function to avoid waiting. Signed-off-by:
-
Christian Gromm authored
Currently the IRQ handler used for the rx channel lives between the functions i2c_probe and i2c_remove. This patch shortens the lifetime and keeps the handler alive only between the functions configure_channel and poison_channel. Signed-off-by:
-
Christian Gromm authored
Currently, the only supported PCM formats are 1x8", "2x16", "2x24", "2x32" or "6x16". This adds support for the format "Nx{8,16,24,32}" that also includes the exotic PCM formats like "4x16", "5x8", etc. Signed-off-by: -
Christian Gromm authored
This patch adds the channel property dbr_size to control the corresponding buffer size of the channels of the DIM2 interface. Signed-off-by:
-
Christian Gromm authored
This removes call of the poison_channel that is: - not allowed after most_deregister_interface; - is made during the most_deregister_interface call. Signed-off-by:
-
Christian Gromm authored
This prevents division by zero scan_rate. The zero scan_rate does not need any special action as it actually means "never poll again". Signed-off-by:
-
Christian Gromm authored
This removes the module parameter clock_speed from the HDM code. Instead, the platform-dependent clock speed must be delivered by the platform driver with the help of the dim2_platform_data.clk_speed. Signed-off-by:
-
Christian Gromm authored
This prohibits the allocation of the memory for the MBOs if only the part of the MBOs, requested by the application, may be allocated. The function arm_mbo_chain, if cannot allocate all requested MBO, frees all prior allocated memory and returns 0. Signed-off-by:
-
Nathan Chancellor authored
Fixes a checkpatch.pl warning. Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Acked-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Nathan Chancellor authored
checkpatch.pl complains these are invalid because the rules in Documentation/process/license-rules.rst state that C headers should have "/* */" style comments. Signed-off-by:
-
Nathan Chancellor authored
Fixes checkpatch.pl warnings about lines ending with parentheses. Signed-off-by:
-
Nathan Chancellor authored
Fixes checkpatch.pl warnings about lines ending with parentheses. Signed-off-by:
-
Nathan Chancellor authored
Fixes checkpatch.pl warnings about lines ending with parentheses. Signed-off-by:
-
Nathan Chancellor authored
Fixes checkpatch.pl warnings about lines ending with parentheses. Signed-off-by:
-
Nathan Chancellor authored
Add the identifiers when missing and fix the ones already present according to checkpatch.pl. Signed-off-by:
-
Nathan Chancellor authored
Fixes the following checkpatch.pl warning: "prefer 'help' over '---help---' for new help texts" Signed-off-by:
-
NeilBrown authored
d_splice_alias() can return an ERR_PTR(). If it does while debugging is enabled, the following CDEBUG() will dereference that error and crash. So add appropriate checking, and provide a separate debug message for the error case. Reported-and-tested-by:
James Simmons <jsimmons@infradead.org> Fixes: e9d4f0b9 ("staging: lustre: llite: use d_splice_alias for directories.") Reviewed-by:
NeilBrown <neilb@suse.com> Signed-off-by:
-
NeilBrown authored
There is no longer any need to keep this code separate, and now we can remove linux-module.c Reviewed-by:
-
NeilBrown authored
The ioctl handler for the misc device is in lnet/libcfs/module.c but is it registered in lnet/libcfs/linux/linux-module.c. Keeping related code together make maintenance easier, so move the code. Reviewed-by:
-
NeilBrown authored
Both the 'next' and the 'show' functions for the dump_page_cache seqfile perform a lookup based on the current file index. This is needless duplication. The reason appears to be that the state that needs to be communicated from "next" to "show" is two pointers, but seq_file only provides for a single pointer to be returned from next and passed to show. So make use of the new 'seq_private' structure to store the extra pointer. So when 'next' (or 'start') find something, it returns the page and stores the clob in the private area. 'show' accepts the page as an argument, and finds the clob where it was stored. Signed-off-by:
-
NeilBrown authored
The dump_page_cache debugfs file allocates and frees an 'env' in each call to vvp_pgcache_start,next,show. This is likely to be fast, but does introduce the need to check for errors. It is reasonable to allocate a single 'env' when the file is opened, and use that throughout. So create 'seq_private' structure which stores the sbi, env, and refcheck, and attach this to the seqfile. Then use it throughout instead of allocating 'env' repeatedly. Signed-off-by:
-
NeilBrown authored
lu_object_new() duplicates a lot of code that is in lu_object_find_at(). There is no real need for a separate function, it is simpler just to skip the bits of lu_object_find_at() that we don't want in the LOC_F_NEW case. Signed-off-by:
-
NeilBrown authored
The current retry logic, to wait when a 'dying' object is found, spans multiple functions. The process is attached to a waitqueue and set TASK_UNINTERRUPTIBLE in htable_lookup, and this status is passed back through lu_object_find_try() to lu_object_find_at() where schedule() is called and the process is removed from the queue. This can be simplified by moving all the logic (including hashtable locking) inside htable_lookup(), which now never returns EAGAIN. Note that htable_lookup() is called with the hash bucket lock held, and will drop and retake it if it needs to schedule. I made this a 'goto' loop rather than a 'while(1)' loop as the diff is easier to read. Signed-off-by:
-
NeilBrown authored
lu_object maintains 2 lru counts. One is a per-bucket lsb_lru_len. The other is the per-cpu ls_lru_len_counter. The only times the per-bucket counters are use are: - a debug message when an object is added - in lu_site_stats_get when all the counters are combined. The debug message is not essential, and the per-cpu counter can be used to get the combined total. So discard the per-bucket lsb_lru_len. Reviewed-by:
Andreas Dilger <andreas.dilger@dilger.ca> Signed-off-by:
-
NeilBrown authored
This data structure only needs to be public so that various modules can access a wait queue to wait for object destruction. If we provide a function to get the wait queue, rather than the whole bucket, the structure can be made private. Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
- 07 May, 2018 5 commits
-
-
Nathan Chancellor authored
Fixes the following W=1 warning: variable ‘intf_id’ set but not used [-Wunused-but-set-variable] Signed-off-by:
-
Nathan Chancellor authored
This satisfies a checkpatch.pl warning and is the preferred method for notating the license due to its lack of ambiguity. Signed-off-by:
-
Nathan Chancellor authored
This statment triggers GCC's -Wtype-limit since key_index is an unsigned integer so it cannot be less than zero. Signed-off-by:
-
Nathan Chancellor authored
GCC warns that 'wid' is unused in wilc_remove_key and it's correct; the variable is only local. Get rid of the function (since it just returns zero) and shuffle the remaining code into one if statement. Signed-off-by:
-
Nathan Chancellor authored
GCC warns these variables are all set but never used so remove them. Signed-off-by:
-
