1. 12 Mar, 2020 2 commits
  2. 11 Mar, 2020 11 commits
    • Remi Pommarel's avatar
      ath9k: Handle txpower changes even when TPC is disabled · 968ae2ca
      Remi Pommarel authored
      When TPC is disabled IEEE80211_CONF_CHANGE_POWER event can be handled to
      reconfigure HW's maximum txpower.
      
      This fixes 0dBm txpower setting when user attaches to an interface for
      the first time with the following scenario:
      
      ieee80211_do_open()
          ath9k_add_interface()
              ath9k_set_txpower() /* Set TX power with not yet initialized
                                     sc->hw->conf.power_level */
      
          ieee80211_hw_config() /* Iniatilize sc->hw->conf.power_level and
                                   raise IEEE80211_CONF_CHANGE_POWER */
      
          ath9k_config() /* IEEE80211_CONF_CHANGE_POWER is ignored */
      
      This issue can be reproduced with the following:
      
        $ modprobe -r ath9k
        $ modprobe ath9k
        $ wpa_supplicant -i wlan0 -c /tmp/wpa.conf &
        $ iw dev /* Here TX power is either 0 or 3 depending on RF chain */
        $ killall wpa_supplicant
        $ iw dev /* TX power goes back to calibrated value and subsequent
                    calls will be fine */
      
      Fixes: 283dd119 ("ath9k: add per-vif TX power capability")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarRemi Pommarel <repk@triplefau.lt>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      968ae2ca
    • Krzysztof Kozlowski's avatar
      ath5k: Add proper dependency for ATH5K_AHB · c98cdaef
      Krzysztof Kozlowski authored
      The CONFIG_ATH5K_AHB could be enabled on ATH25 system without enabling
      ATH5K driver itself.  This does not make sense because CONFIG_ATH5K_AHB
      controls object build within drivers/net/wireless/ath/ath5k/ so enabling
      it without CONFIG_ATH5K brings nothing.
      
      Add proper dependency to CONFIG_ATH5K_AHB.
      Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      c98cdaef
    • Pradeep Kumar Chitrapu's avatar
      ath11k: add thermal sensor device support · a41d1034
      Pradeep Kumar Chitrapu authored
      Temperature sensor generates electrical analog voltage from temperature
      of each chain. The analog voltage is converted to digital value through
      ADC. For reading temperature values fom user space, hw monitoring device
      is used.
      
      Whenever the user requests for current temperature, the driver sends WMI
      command and wait for response. For reading temperature,
      
      cat /sys/class/ieee80211/phy*/device/hwmon/hwmon2/temp1_input
      Signed-off-by: default avatarPradeep Kumar Chitrapu <pradeepc@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      a41d1034
    • Pradeep Kumar Chitrapu's avatar
      ath11k: add thermal cooling device support · 2a63bbca
      Pradeep Kumar Chitrapu authored
      Thermal cooling device support is added to control the temperature by
      throttling the data transmission for the given duration. Throttling is
      done by suspending all data tx queues by given percentage of time. The
      thermal device allows user to configure duty cycle.
      
      Throttling can be disabled by setting the duty cycle to 0. The cooling
      device can be found under /sys/class/thermal/cooling_deviceX/.
      Corresponding soft link to this device can be found under phy folder.
      
      /sys/class/ieee80211/phy*/device/cooling_device.
      
      To set duty cycle as 40%,
      
      echo 40 >/sys/class/ieee80211/phy*/device/cooling_device/cur_state
      Signed-off-by: default avatarPradeep Kumar Chitrapu <pradeepc@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      2a63bbca
    • Yibo Zhao's avatar
      ath10k: fix not registering airtime of 11a station with WMM disable · f9680c75
      Yibo Zhao authored
      The tid of 11a station with WMM disable reported by FW is 0x10 in
      tx completion. The tid 16 is mapped to a NULL txq since buffer
      MMPDU capbility is not supported. Then 11a station's airtime will
      not be registered due to NULL txq check. As a results, airtime of
      11a station keeps unchanged in debugfs system.
      
      Mask the tid along with IEEE80211_QOS_CTL_TID_MASK to make it in
      the valid range.
      
      Hardwares tested : QCA9984
      Firmwares tested : 10.4-3.10-00047
      Signed-off-by: default avatarYibo Zhao <yiboz@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      f9680c75
    • Govindaraj Saminathan's avatar
      ath11k: config reorder queue for all tids during peer setup · a36adf54
      Govindaraj Saminathan authored
      Currently rx tid setup is happening for TID 0 and TID 16
      during peer setup. And if other TID packets received for
      the peer it will be redirected to rx error ring and not through
      reo ring. And this rx tid configuration cannot be done
      in the rx error ring path since it is a atomic context.
      So moving the rx tid setup for all tids during the peer setup.
      This is required to enable PN offload functionality to route
      all packets through reo ring.
      Co-developed-by: default avatarTamizh Chelvam <tamizhr@codeaurora.org>
      Signed-off-by: default avatarTamizh Chelvam <tamizhr@codeaurora.org>
      Signed-off-by: default avatarGovindaraj Saminathan <gsamin@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      a36adf54
    • Yingying Tang's avatar
      ath10k: fix unsupported chip reset debugs file write · bbdc8c5a
      Yingying Tang authored
      Before this change, after writing "warm_hw_reset" debugfs file, host
      will send chip reset command to FW even though FW do not support this
      service getting a warning print.
      
      Though there is no FW impact before this change, this patch restricts
      chip reset command sent to FW only if FW advertises the support via WMI
      service bit.
      
      Removed the redundant check and ath10k_warn() print as well.
      
      New version FW will report chip reset service bit to host. Host allow user
      to trigger WLAN chip reset only when fw report this service bit.
      
      For older NON-TLV FW, since it do not report chip reset service bit, host
      will not send chip reset command. For older TLV FW, since it report chip
      reset service bit, host will send chip reset command.
      
      Tested HW:  QCA9984, WCN3990
      
      QCA9984 FW version: WLAN.BL.3.9.0.2-00042-S-1
      Signed-off-by: default avatarYingying Tang <yintang@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      bbdc8c5a
    • Wen Gong's avatar
      ath10k: use kzalloc to read for ath10k_sdio_hif_diag_read · 402f2992
      Wen Gong authored
      When use command to read values, it crashed.
      
      command:
      dd if=/sys/kernel/debug/ieee80211/phy0/ath10k/mem_value count=1 bs=4 skip=$((0x100233))
      
      It will call to ath10k_sdio_hif_diag_read with address = 0x4008cc and buf_len = 4.
      
      Then system crash:
      [ 1786.013258] Unable to handle kernel paging request at virtual address ffffffc00bd45000
      [ 1786.013273] Mem abort info:
      [ 1786.013281]   ESR = 0x96000045
      [ 1786.013291]   Exception class = DABT (current EL), IL = 32 bits
      [ 1786.013299]   SET = 0, FnV = 0
      [ 1786.013307]   EA = 0, S1PTW = 0
      [ 1786.013314] Data abort info:
      [ 1786.013322]   ISV = 0, ISS = 0x00000045
      [ 1786.013330]   CM = 0, WnR = 1
      [ 1786.013342] swapper pgtable: 4k pages, 39-bit VAs, pgdp = 000000008542a60e
      [ 1786.013350] [ffffffc00bd45000] pgd=0000000000000000, pud=0000000000000000
      [ 1786.013368] Internal error: Oops: 96000045 [#1] PREEMPT SMP
      [ 1786.013609] Process swapper/0 (pid: 0, stack limit = 0x0000000084b153c6)
      [ 1786.013623] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.86 #137
      [ 1786.013631] Hardware name: MediaTek krane sku176 board (DT)
      [ 1786.013643] pstate: 80000085 (Nzcv daIf -PAN -UAO)
      [ 1786.013662] pc : __memcpy+0x94/0x180
      [ 1786.013678] lr : swiotlb_tbl_unmap_single+0x84/0x150
      [ 1786.013686] sp : ffffff8008003c60
      [ 1786.013694] x29: ffffff8008003c90 x28: ffffffae96411f80
      [ 1786.013708] x27: ffffffae960d2018 x26: ffffff8019a4b9a8
      [ 1786.013721] x25: 0000000000000000 x24: 0000000000000001
      [ 1786.013734] x23: ffffffae96567000 x22: 00000000000051d4
      [ 1786.013747] x21: 0000000000000000 x20: 00000000fe6e9000
      [ 1786.013760] x19: 0000000000000004 x18: 0000000000000020
      [ 1786.013773] x17: 0000000000000001 x16: 0000000000000000
      [ 1786.013787] x15: 00000000ffffffff x14: 00000000000044c0
      [ 1786.013800] x13: 0000000000365ba4 x12: 0000000000000000
      [ 1786.013813] x11: 0000000000000001 x10: 00000037be6e9000
      [ 1786.013826] x9 : ffffffc940000000 x8 : 000000000bd45000
      [ 1786.013839] x7 : 0000000000000000 x6 : ffffffc00bd45000
      [ 1786.013852] x5 : 0000000000000000 x4 : 0000000000000000
      [ 1786.013865] x3 : 0000000000000c00 x2 : 0000000000000004
      [ 1786.013878] x1 : fffffff7be6e9004 x0 : ffffffc00bd45000
      [ 1786.013891] Call trace:
      [ 1786.013903]  __memcpy+0x94/0x180
      [ 1786.013914]  unmap_single+0x6c/0x84
      [ 1786.013925]  swiotlb_unmap_sg_attrs+0x54/0x80
      [ 1786.013938]  __swiotlb_unmap_sg_attrs+0x8c/0xa4
      [ 1786.013952]  msdc_unprepare_data+0x6c/0x84
      [ 1786.013963]  msdc_request_done+0x58/0x84
      [ 1786.013974]  msdc_data_xfer_done+0x1a0/0x1c8
      [ 1786.013985]  msdc_irq+0x12c/0x17c
      [ 1786.013996]  __handle_irq_event_percpu+0xe4/0x250
      [ 1786.014006]  handle_irq_event_percpu+0x28/0x68
      [ 1786.014015]  handle_irq_event+0x48/0x78
      [ 1786.014026]  handle_fasteoi_irq+0xd0/0x1a0
      [ 1786.014039]  __handle_domain_irq+0x84/0xc4
      [ 1786.014050]  gic_handle_irq+0x124/0x1a4
      [ 1786.014059]  el1_irq+0xb0/0x128
      [ 1786.014072]  cpuidle_enter_state+0x298/0x328
      [ 1786.014082]  cpuidle_enter+0x30/0x40
      [ 1786.014094]  do_idle+0x190/0x268
      [ 1786.014104]  cpu_startup_entry+0x24/0x28
      [ 1786.014116]  rest_init+0xd4/0xe0
      [ 1786.014126]  start_kernel+0x30c/0x38c
      [ 1786.014139] Code: f8408423 f80084c3 36100062 b8404423 (b80044c3)
      [ 1786.014150] ---[ end trace 3b02ddb698ea69ee ]---
      [ 1786.015415] Kernel panic - not syncing: Fatal exception in interrupt
      [ 1786.015433] SMP: stopping secondary CPUs
      [ 1786.015447] Kernel Offset: 0x2e8d200000 from 0xffffff8008000000
      [ 1786.015458] CPU features: 0x0,2188200c
      [ 1786.015466] Memory Limit: none
      
      For sdio chip, it need the memory which is kmalloc, if it is
      vmalloc from ath10k_mem_value_read, then it have a memory error.
      kzalloc of ath10k_sdio_hif_diag_read32 is the correct type, so
      add kzalloc in ath10k_sdio_hif_diag_read to replace the buffer
      which is vmalloc from ath10k_mem_value_read.
      
      This patch only effect sdio chip.
      
      Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
      Signed-off-by: default avatarWen Gong <wgong@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      402f2992
    • Wen Gong's avatar
      ath10k: start recovery process when read int status fail for sdio · 37b7ecb7
      Wen Gong authored
      When running simulate crash stress test, it happened
      "failed to read from address 0x800: -110".
      
      Test steps:
      1. Run command continuous
      echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash
      
      2. error happened and it did not begin recovery for long time.
      [74377.334846] ath10k_sdio mmc1:0001:1: simulating soft firmware crash
      [74378.378217] ath10k_sdio mmc1:0001:1: failed to read from address 0x800: -110
      [74378.378371] ath10k_sdio mmc1:0001:1: failed to process pending SDIO interrupts: -110
      
      It has sdio errors since it can not read MBOX_HOST_INT_STATUS_ADDRESS,
      then it has to do recovery process to recovery ath10k.
      
      Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
      Signed-off-by: default avatarWen Gong <wgong@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      37b7ecb7
    • Erik Stromdahl's avatar
      ath10k: add QCA9377 sdio hw_param item · 6e51b0e4
      Erik Stromdahl authored
      Add hardware parameters for QCA9377 sdio devices, it's now properly supported.
      Signed-off-by: default avatarErik Stromdahl <erik.stromdahl@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      6e51b0e4
    • Vikas Patel's avatar
      ath10k: avoid consecutive OTP download to reduce boot time · a4b9f641
      Vikas Patel authored
      Currently, OTP is downloaded twice in case of "pre-cal-dt"
      and "pre-cal-file" to fetch the board ID and takes around
      ~2 sec more boot uptime.
      
      First OTP download happens in "ath10k_core_probe_fw" and
      second in ath10k_core_start. First boot does not need OTP
      download in core start when valid board id acquired.
      
      The second OTP download is required upon core stop/start.
      
      This patch skips the OTP download when first OTP download
      has acquired a valid board id. This patch also marks board
      id invalid in "ath10k_core_stop", which will force the OTP
      download in ath10k_core_start and fetches valid board id.
      
      Tested HW: QCA9984
      Tested FW: 10.4-3.6-00104
      Signed-off-by: default avatarVikas Patel <vikpatel@codeaurora.org>
      Signed-off-by: default avatarMaharaja Kennadyrajan <mkenna@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      a4b9f641
  3. 11 Feb, 2020 11 commits
    • Venkateswara Naralasetty's avatar
      ath11k: fix incorrect peer stats counters update · 92bacd1c
      Venkateswara Naralasetty authored
      Convert mac80211 bw to ath11k bw before updating peer stats
      bw counters, which fixes incorrect peer stats counters update.
      Signed-off-by: default avatarVenkateswara Naralasetty <vnaralas@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      92bacd1c
    • Vikas Patel's avatar
      ath11k: Fixing dangling pointer issue upon peer delete failure · 58595c98
      Vikas Patel authored
      When there is WMI command failure, 'peer->sta' was not getting
      cleaned up, and mac80211 frees the 'sta' memory, which is causing
      the below page fault.
      
      Cleaning up the sta pointer in ath11k whenever peer delete command
      is sent.
      
      Unable to handle kernel paging request at virtual address 200080000006a
      pgd = ffffffc02a774000
      [200080000006a] *pgd=0000000000000000, *pud=0000000000000000
      Internal error: Oops: 96000004 [#1] PREEMPT SMP
      .
      .
      .
      CPU: 0 PID: 0 Comm: swapper/0 Tainted: G        W       4.4.60 #1
      Hardware name: Qualcomm Technologies, Inc. IPQ807x/AP-HK01-C1 (DT)
      task: ffffffc00083c6d0 ti: ffffffc00083c6d0 task.ti: ffffffc00083c6d0
      PC is at ath11k_dp_rx_process_mon_status+0x114/0x4e0 [ath11k]
      LR is at ath11k_dp_rx_process_mon_status+0xe8/0x4e0 [ath11k]
      pc : [<ffffffbffcf8e544>] lr : [<ffffffbffcf8e518>] pstate: 60000145
      sp : ffffffc000833a30
      Signed-off-by: default avatarVikas Patel <vikpatel@codeaurora.org>
      Signed-off-by: default avatarVenkateswara Naralasetty <vnaralas@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      58595c98
    • Anilkumar Kolli's avatar
      ath11k: fix parsing PPDU_CTRL type in pktlog · 443d2ee7
      Anilkumar Kolli authored
      PPDU_CTRL type is missing in current pktlog dumps.
      PPDU_CTRL is sent on CE5 with len 2560 bytes, current
      driver ignores the payload len greter than 2048.
      PPDU_CTRL of 2560 bytes is sent in two fragments of len 2028
      and 532 bytes, but firmware reports pkt header has length as 2560
      for both of the fragments.
      Signed-off-by: default avatarAnilkumar Kolli <akolli@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      443d2ee7
    • Karthikeyan Periyasamy's avatar
      ath11k: fix warn-on in disassociation · 79c080db
      Karthikeyan Periyasamy authored
      In multi AP VAP scenario, when user bring down the interfaces. mac80211 mark
      the interface down for the duplicated VAP and removed from the
      local->interfaces list. ath11k_mac_get_arvif() is dependent on
      ieee80211_iterate_active_interfaces_atomic() API to find the vdev id
      in a given radio. In disassociation path, ath11k_mac_get_arvif() not
      able to find the given vdev id since that VAP is removed from the
      local->interfaces list. since sta_state callback throws error, mac80211 log
      the below WARN_ON_ONCE message.
      
      Fixed it by storing the allocated_vdev_map in each radio structure to maintain
      the created vdev id bits. so that we can directly mask this against the given
      vdev_id to find out the ar from the vdev_id.
      
      WARN LOG:
      
      WARNING: at net/mac80211/sta_info.c:1008
      CPU: 2 PID: 2135 Comm: hostapd Not tainted #1
      Hardware name: Qualcomm Technologies, Inc. IPQ807x/AP-HK01-C1 (DT)
      task: ffffffc03a43d800 ti: ffffffc03a43d800 task.ti: ffffffc03a43d800
      PC is at sta_set_sinfo+0x9dc/0xad4 [mac80211]
      LR is at sta_set_sinfo+0x9cc/0xad4 [mac80211]
      pc : [<ffffffbffce2a008>] lr : [<ffffffbffce29ff8>] pstate: 20000145
      sp : ffffffc02cedb5f0
      x29: ffffffc02cedb5f0 x28: ffffffc03a43d800
      x27: 0000000000000014 x26: 0000000000000001
      x25: ffffffc02cfc4000 x24: ffffffc036905508
      x23: 0000000000000012 x22: ffffffc02cedb670
      x21: ffffffc03bc64880 x20: ffffffc036904f80
      x19: ffffffc02ae31000 x18: 00000000b019f3a1
      x17: 0000000057f30331 x16: 00000000d8d1998e
      x15: 0000000000000066 x14: 393a35383a36343a
      x13: 6337203a6e6f6974 x12: 6174732065746169
      x11: 636f737361736964 x10: 206f742064656c69
      x9 : 6146203a31696669 x8 : 6337203a6e6f6974
      x7 : 6174732065746169 x6 : ffffffc0008c33f6
      x5 : 0000000000000000 x4 : 0000000000000000
      x3 : 0000000000000000 x2 : 00000000ffffff92
      x1 : 0000000000000000 x0 : ffffffbffcea1091
      ---[ end trace 63c4b1c527345d5a ]---
      Call trace:
      [<ffffffbffce2a008>] sta_set_sinfo+0x9dc/0xad4 [mac80211]
      [<ffffffbffce2a2c4>] __sta_info_flush+0xec/0x130 [mac80211]
      [<ffffffbffce3dc48>] ieee80211_nan_func_match+0x1a34/0x23e4 [mac80211]
      [<ffffffbffcde03e0>] __cfg80211_stop_ap+0x60/0xf0 [cfg80211]
      [<ffffffbffcdb6d08>] __cfg80211_leave+0x110/0x150 [cfg80211]
      [<ffffffbffcdb6d78>] cfg80211_leave+0x30/0x48 [cfg80211]
      [<ffffffbffcdb6fbc>] cfg80211_init_wdev+0x22c/0x808 [cfg80211]
      [<ffffffc0000afe28>] notifier_call_chain+0x50/0x84
      [<ffffffc0000afefc>] raw_notifier_call_chain+0x14/0x1c
      [<ffffffc0004ae94c>] call_netdevice_notifiers_info+0x5c/0x6c
      [<ffffffc0004ae96c>] call_netdevice_notifiers+0x10/0x18
      [<ffffffc0004aea80>] __dev_close_many+0x54/0xc0
      [<ffffffc0004aeb50>] dev_close_many+0x64/0xdc
      [<ffffffc0004b0b70>] rollback_registered_many+0x138/0x2f4
      [<ffffffc0004b0d4c>] rollback_registered+0x20/0x34
      [<ffffffc0004b34b4>] unregister_netdevice_queue+0x68/0xa8
      [<ffffffbffce3870c>] ieee80211_if_remove+0x84/0xc0 [mac80211]
      [<ffffffbffce3e588>] ieee80211_nan_func_match+0x2374/0x23e4 [mac80211]
      [<ffffffbffcdc29e8>] cfg80211_wext_giwscan+0x1000/0x1140 [cfg80211]
      [<ffffffbffcb2a87c>] backport_genlmsg_multicast_allns+0x158/0x1b4 [compat]
      [<ffffffc0004e0944>] genl_family_rcv_msg+0x258/0x2c0
      [<ffffffc0004e09f4>] genl_rcv_msg+0x48/0x6c
      [<ffffffc0004dfb50>] netlink_rcv_skb+0x5c/0xc4
      [<ffffffc0004e06d8>] genl_rcv+0x34/0x48
      [<ffffffc0004df570>] netlink_unicast+0x12c/0x1e0
      [<ffffffc0004df9a4>] netlink_sendmsg+0x2bc/0x2dc
      [<ffffffc00049a540>] sock_sendmsg+0x18/0x2c
      [<ffffffc00049ab94>] ___sys_sendmsg+0x1bc/0x248
      [<ffffffc00049ba24>] __sys_sendmsg+0x40/0x68
      [<ffffffc00049ba5c>] SyS_sendmsg+0x10/0x20
      [<ffffffc000085db0>] el0_svc_naked+0x24/0x28
      Signed-off-by: default avatarKarthikeyan Periyasamy <periyasa@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      79c080db
    • Karthikeyan Periyasamy's avatar
      ath11k: fix rcu lock protect in peer assoc confirmation · db0889ab
      Karthikeyan Periyasamy authored
      ath11k_mac_get_ar_by_vdev_id() get protected under rcu lock
      and unlock. peer association confirmation event get used this API
      without rcu protection, so corrected it.
      Signed-off-by: default avatarKarthikeyan Periyasamy <periyasa@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      db0889ab
    • John Crispin's avatar
      ath11k: add HE rate accounting to driver · 6a0c3702
      John Crispin authored
      Parse and store the out-of-band rates reported by the FW.
      Signed-off-by: default avatarJohn Crispin <john@phrozen.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      6a0c3702
    • John Crispin's avatar
      ath11k: drop tx_info from ath11k_sta · be43ce64
      John Crispin authored
      We will start using ieee80211_tx_status_ext() so we do not need to track
      tx rates inside a struct ieee80211_tx_info. It is currently not possible
      to populate that struct with HE rate info anyhow.
      Signed-off-by: default avatarJohn Crispin <john@phrozen.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      be43ce64
    • Nathan Chancellor's avatar
      ath11k: Silence clang -Wsometimes-uninitialized in ath11k_update_per_peer_stats_from_txcompl · df57acc4
      Nathan Chancellor authored
      Clang warns a few times (trimmed for brevity):
      
      ../drivers/net/wireless/ath/ath11k/debugfs_sta.c:185:7: warning:
      variable 'rate_idx' is used uninitialized whenever 'if' condition is
      false [-Wsometimes-uninitialized]
      
      It is not wrong, rate_idx is only initialized in the first if block.
      However, this is not necessarily an issue in practice because rate_idx
      will only be used when initialized because
      ath11k_accumulate_per_peer_tx_stats only uses rate_idx when flags is not
      set to RATE_INFO_FLAGS_HE_MCS, RATE_INFO_FLAGS_VHT_MCS, or
      RATE_INFO_FLAGS_MCS. Still, it is not good to stick uninitialized values
      into another function so initialize it to zero to prevent any issues
      down the line.
      
      Fixes: d5c65159 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
      Link: https://github.com/ClangBuiltLinux/linux/issues/832
      Reported-by: ci_notify@linaro.org
      Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
      Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      df57acc4
    • Tamizh Chelvam's avatar
      ath10k: Add support to read btcoex related data from DT · 9f83993e
      Tamizh Chelvam authored
      BTCOEX feature is not supported by all QCA4019 chipsets.
      Since btcoex enabled by default in firmware, host needs to
      enable COEX support depends on the hardware. Enabling it
      by default in unsupported hardware will cause some
      feature disabled in hardware.
      This patch will read btcoex_support flag and
      wlan priority gpio pin number from DT. Depends on the
      btcoex_support flag value host will expose BTCOEX support
      and wlan priority gpio pin number to target.
      
      Testing:
      	* Tested HW : QCA4019
      	* Tested FW : 10.4-3.2.1.1-00017
      Signed-off-by: default avatarTamizh Chelvam <tamizhr@codeaurora.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      9f83993e
    • Tamizh Chelvam's avatar
      dt-bindings: ath10k: Add new dt entries to identify coex support · 7354de9c
      Tamizh Chelvam authored
      This adds new dt entries qcom,coexist-support and qcom,coexist-gpio-pin
      which will be used by ath10k driver to identify coex support
      of a hardware and notify wifi firmware the gpio pin number.
      This pin number information is needed for the hardware QCA4019.
      Signed-off-by: default avatarTamizh Chelvam <tamizhr@codeaurora.org>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      7354de9c
    • Kalle Valo's avatar
      ath10k: fix few checkpatch warnings · 9a5fccc1
      Kalle Valo authored
      Fix warnings which were recently introduced:
      
      drivers/net/wireless/ath/ath10k/ahb.c:462: Alignment should match open parenthesis
      drivers/net/wireless/ath/ath10k/ahb.c:470: Alignment should match open parenthesis
      drivers/net/wireless/ath/ath10k/sdio.c:697: space prohibited before that close parenthesis ')'
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      9a5fccc1
  4. 10 Feb, 2020 2 commits
    • Linus Torvalds's avatar
      Linux 5.6-rc1 · bb6d3fb3
      Linus Torvalds authored
      bb6d3fb3
    • Linus Torvalds's avatar
      Merge tag 'kbuild-v5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild · 89a47dd1
      Linus Torvalds authored
      Pull more Kbuild updates from Masahiro Yamada:
      
       - fix randconfig to generate a sane .config
      
       - rename hostprogs-y / always to hostprogs / always-y, which are more
         natual syntax.
      
       - optimize scripts/kallsyms
      
       - fix yes2modconfig and mod2yesconfig
      
       - make multiple directory targets ('make foo/ bar/') work
      
      * tag 'kbuild-v5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        kbuild: make multiple directory targets work
        kconfig: Invalidate all symbols after changing to y or m.
        kallsyms: fix type of kallsyms_token_table[]
        scripts/kallsyms: change table to store (strcut sym_entry *)
        scripts/kallsyms: rename local variables in read_symbol()
        kbuild: rename hostprogs-y/always to hostprogs/always-y
        kbuild: fix the document to use extra-y for vmlinux.lds
        kconfig: fix broken dependency in randconfig-generated .config
      89a47dd1
  5. 09 Feb, 2020 12 commits
    • Linus Torvalds's avatar
      Merge tag 'zonefs-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs · 380a129e
      Linus Torvalds authored
      Pull new zonefs file system from Damien Le Moal:
       "Zonefs is a very simple file system exposing each zone of a zoned
        block device as a file.
      
        Unlike a regular file system with native zoned block device support
        (e.g. f2fs or the on-going btrfs effort), zonefs does not hide the
        sequential write constraint of zoned block devices to the user. As a
        result, zonefs is not a POSIX compliant file system. Its goal is to
        simplify the implementation of zoned block devices support in
        applications by replacing raw block device file accesses with a richer
        file based API, avoiding relying on direct block device file ioctls
        which may be more obscure to developers.
      
        One example of this approach is the implementation of LSM
        (log-structured merge) tree structures (such as used in RocksDB and
        LevelDB) on zoned block devices by allowing SSTables to be stored in a
        zone file similarly to a regular file system rather than as a range of
        sectors of a zoned device. The introduction of the higher level
        construct "one file is one zone" can help reducing the amount of
        changes needed in the application while at the same time allowing the
        use of zoned block devices with various programming languages other
        than C.
      
        Zonefs IO management implementation uses the new iomap generic code.
        Zonefs has been successfully tested using a functional test suite
        (available with zonefs userland format tool on github) and a prototype
        implementation of LevelDB on top of zonefs"
      
      * tag 'zonefs-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs:
        zonefs: Add documentation
        fs: New zonefs file system
      380a129e
    • Marc Zyngier's avatar
      irqchip/gic-v4.1: Avoid 64bit division for the sake of 32bit ARM · 490d332e
      Marc Zyngier authored
      In order to allow the GICv4 code to link properly on 32bit ARM,
      make sure we don't use 64bit divisions when it isn't strictly
      necessary.
      
      Fixes: 4e6437f1 ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Cc: Zenghui Yu <yuzenghui@huawei.com>
      Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      490d332e
    • Linus Torvalds's avatar
      Merge tag '5.6-rc-smb3-plugfest-patches' of git://git.samba.org/sfrench/cifs-2.6 · d1ea35f4
      Linus Torvalds authored
      Pull cifs fixes from Steve French:
       "13 cifs/smb3 patches, most from testing at the SMB3 plugfest this week:
      
         - Important fix for multichannel and for modefromsid mounts.
      
         - Two reconnect fixes
      
         - Addition of SMB3 change notify support
      
         - Backup tools fix
      
         - A few additional minor debug improvements (tracepoints and
           additional logging found useful during testing this week)"
      
      * tag '5.6-rc-smb3-plugfest-patches' of git://git.samba.org/sfrench/cifs-2.6:
        smb3: Add defines for new information level, FileIdInformation
        smb3: print warning once if posix context returned on open
        smb3: add one more dynamic tracepoint missing from strict fsync path
        cifs: fix mode bits from dir listing when mounted with modefromsid
        cifs: fix channel signing
        cifs: add SMB3 change notification support
        cifs: make multichannel warning more visible
        cifs: fix soft mounts hanging in the reconnect code
        cifs: Add tracepoints for errors on flush or fsync
        cifs: log warning message (once) if out of disk space
        cifs: fail i/o on soft mounts if sessionsetup errors out
        smb3: fix problem with null cifs super block with previous patch
        SMB3: Backup intent flag missing from some more ops
      d1ea35f4
    • Linus Torvalds's avatar
      Merge branch 'work.vboxsf' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · 5586c3c1
      Linus Torvalds authored
      Pull vboxfs from Al Viro:
       "This is the VirtualBox guest shared folder support by Hans de Goede,
        with fixups for fs_parse folded in to avoid bisection hazards from
        those API changes..."
      
      * 'work.vboxsf' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        fs: Add VirtualBox guest shared folder (vboxsf) support
      5586c3c1
    • Linus Torvalds's avatar
      Merge tag 'x86-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 1a2a76c2
      Linus Torvalds authored
      Pull x86 fixes from Thomas Gleixner:
       "A set of fixes for X86:
      
         - Ensure that the PIT is set up when the local APIC is disable or
           configured in legacy mode. This is caused by an ordering issue
           introduced in the recent changes which skip PIT initialization when
           the TSC and APIC frequencies are already known.
      
         - Handle malformed SRAT tables during early ACPI parsing which caused
           an infinite loop anda boot hang.
      
         - Fix a long standing race in the affinity setting code which affects
           PCI devices with non-maskable MSI interrupts. The problem is caused
           by the non-atomic writes of the MSI address (destination APIC id)
           and data (vector) fields which the device uses to construct the MSI
           message. The non-atomic writes are mandated by PCI.
      
           If both fields change and the device raises an interrupt after
           writing address and before writing data, then the MSI block
           constructs a inconsistent message which causes interrupts to be
           lost and subsequent malfunction of the device.
      
           The fix is to redirect the interrupt to the new vector on the
           current CPU first and then switch it over to the new target CPU.
           This allows to observe an eventually raised interrupt in the
           transitional stage (old CPU, new vector) to be observed in the APIC
           IRR and retriggered on the new target CPU and the new vector.
      
           The potential spurious interrupts caused by this are harmless and
           can in the worst case expose a buggy driver (all handlers have to
           be able to deal with spurious interrupts as they can and do happen
           for various reasons).
      
         - Add the missing suspend/resume mechanism for the HYPERV hypercall
           page which prevents resume hibernation on HYPERV guests. This
           change got lost before the merge window.
      
         - Mask the IOAPIC before disabling the local APIC to prevent
           potentially stale IOAPIC remote IRR bits which cause stale
           interrupt lines after resume"
      
      * tag 'x86-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/apic: Mask IOAPIC entries when disabling the local APIC
        x86/hyperv: Suspend/resume the hypercall page for hibernation
        x86/apic/msi: Plug non-maskable MSI affinity race
        x86/boot: Handle malformed SRAT tables during early ACPI parsing
        x86/timer: Don't skip PIT setup when APIC is disabled or in legacy mode
      1a2a76c2
    • Linus Torvalds's avatar
      Merge tag 'smp-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · f4137760
      Linus Torvalds authored
      Pull SMP fixes from Thomas Gleixner:
       "Two fixes for the SMP related functionality:
      
         - Make the UP version of smp_call_function_single() match SMP
           semantics when called for a not available CPU. Instead of emitting
           a warning and assuming that the function call target is CPU0,
           return a proper error code like the SMP version does.
      
         - Remove a superfluous check in smp_call_function_many_cond()"
      
      * tag 'smp-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        smp/up: Make smp_call_function_single() match SMP semantics
        smp: Remove superfluous cond_func check in smp_call_function_many_cond()
      f4137760
    • Linus Torvalds's avatar
      Merge tag 'perf-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · ca21b9b3
      Linus Torvalds authored
      Pull perf fixes from Thomas Gleixner:
       "A set of fixes and improvements for the perf subsystem:
      
        Kernel fixes:
      
         - Install cgroup events to the correct CPU context to prevent a
           potential list double add
      
         - Prevent an integer underflow in the perf mlock accounting
      
         - Add a missing prototype for arch_perf_update_userpage()
      
        Tooling:
      
         - Add a missing unlock in the error path of maps__insert() in perf
           maps.
      
         - Fix the build with the latest libbfd
      
         - Fix the perf parser so it does not delete parse event terms, which
           caused a regression for using perf with the ARM CoreSight as the
           sink configuration was missing due to the deletion.
      
         - Fix the double free in the perf CPU map merging test case
      
         - Add the missing ustring support for the perf probe command"
      
      * tag 'perf-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        perf maps: Add missing unlock to maps__insert() error case
        perf probe: Add ustring support for perf probe command
        perf: Make perf able to build with latest libbfd
        perf test: Fix test case Merge cpu map
        perf parse: Copy string to perf_evsel_config_term
        perf parse: Refactor 'struct perf_evsel_config_term'
        kernel/events: Add a missing prototype for arch_perf_update_userpage()
        perf/cgroups: Install cgroup events to correct cpuctx
        perf/core: Fix mlock accounting in perf_mmap()
      ca21b9b3
    • Linus Torvalds's avatar
      Merge tag 'timers-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 2fbc23c7
      Linus Torvalds authored
      Pull timer fixes from Thomas Gleixner:
       "Two small fixes for the time(r) subsystem:
      
         - Handle a subtle race between the clocksource watchdog and a
           concurrent clocksource watchdog stop/start sequence correctly to
           prevent a timer double add bug.
      
         - Fix the file path for the core time namespace file"
      
      * tag 'timers-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        clocksource: Prevent double add_timer_on() for watchdog_timer
        MAINTAINERS: Correct path to time namespace source file
      2fbc23c7
    • Linus Torvalds's avatar
      Merge tag 'irq-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · f06bed87
      Linus Torvalds authored
      Pull interrupt fixes from Thomas Gleixner:
       "A set of fixes for the interrupt subsystem:
      
         - Provision only ACPI enabled redistributors on GICv3
      
         - Use the proper command colums when building the INVALL command for
           the GICv3-ITS
      
         - Ensure the allocation of the L2 vPE table for GICv4.1
      
         - Correct the GICv4.1 VPROBASER programming so it uses the proper
           size
      
         - A set of small GICv4.1 tidy up patches
      
         - Configuration cleanup for C-SKY interrupt chip
      
         - Clarify the function documentation for irq_set_wake() to document
           that the wakeup functionality is orthogonal to the irq
           disable/enable mechanism"
      
      * tag 'irq-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        irqchip/gic-v3-its: Rename VPENDBASER/VPROPBASER accessors
        irqchip/gic-v3-its: Remove superfluous WARN_ON
        irqchip/gic-v4.1: Drop 'tmp' in inherit_vpe_l1_table_from_rd()
        irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level
        irqchip/gic-v4.1: Set vpe_l1_base for all redistributors
        irqchip/gic-v4.1: Fix programming of GICR_VPROPBASER_4_1_SIZE
        genirq: Clarify that irq wake state is orthogonal to enable/disable
        irqchip/gic-v3-its: Reference to its_invall_cmd descriptor when building INVALL
        irqchip: Some Kconfig cleanup for C-SKY
        irqchip/gic-v3: Only provision redistributors that are enabled in ACPI
      f06bed87
    • Linus Torvalds's avatar
      Merge tag 'efi-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 6ff90aa2
      Linus Torvalds authored
      Pull EFI fix from Thomas Gleixner:
       "A single fix for a EFI boot regression on X86 which was caused by the
        recent rework of the EFI memory map parsing. On systems with invalid
        memmap entries the cleanup function uses an value which cannot be
        relied on in this stage. Use the actual EFI memmap entry instead"
      
      * tag 'efi-urgent-2020-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        efi/x86: Fix boot regression on systems with invalid memmap entries
      6ff90aa2
    • Linus Torvalds's avatar
      Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · fdfa3a67
      Linus Torvalds authored
      Pull misc SCSI fixes from James Bottomley:
       "Five small patches, all in drivers or doc, which missed the initial
        pull request.
      
        The qla2xxx and megaraid_sas are actual fixes and the rest are
        spelling and doc changes"
      
      * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: ufs: fix spelling mistake "initilized" -> "initialized"
        scsi: pm80xx: fix spelling mistake "to" -> "too"
        scsi: MAINTAINERS: ufs: remove pedrom.sousa@synopsys.com
        scsi: megaraid_sas: fixup MSIx interrupt setup during resume
        scsi: qla2xxx: Fix unbound NVME response length
      fdfa3a67
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 291abfea
      Linus Torvalds authored
      Pull networking fixes from David Miller:
      
       1) Unbalanced locking in mwifiex_process_country_ie, from Brian Norris.
      
       2) Fix thermal zone registration in iwlwifi, from Andrei
          Otcheretianski.
      
       3) Fix double free_irq in sgi ioc3 eth, from Thomas Bogendoerfer.
      
       4) Use after free in mptcp, from Florian Westphal.
      
       5) Use after free in wireguard's root_remove_peer_lists, from Eric
          Dumazet.
      
       6) Properly access packets heads in bonding alb code, from Eric
          Dumazet.
      
       7) Fix data race in skb_queue_len(), from Qian Cai.
      
       8) Fix regression in r8169 on some chips, from Heiner Kallweit.
      
       9) Fix XDP program ref counting in hv_netvsc, from Haiyang Zhang.
      
      10) Certain kinds of set link netlink operations can cause a NULL deref
          in the ipv6 addrconf code. Fix from Eric Dumazet.
      
      11) Don't cancel uninitialized work queue in drop monitor, from Ido
          Schimmel.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (84 commits)
        net: thunderx: use proper interface type for RGMII
        mt76: mt7615: fix max_nss in mt7615_eeprom_parse_hw_cap
        bpf: Improve bucket_log calculation logic
        selftests/bpf: Test freeing sockmap/sockhash with a socket in it
        bpf, sockhash: Synchronize_rcu before free'ing map
        bpf, sockmap: Don't sleep while holding RCU lock on tear-down
        bpftool: Don't crash on missing xlated program instructions
        bpf, sockmap: Check update requirements after locking
        drop_monitor: Do not cancel uninitialized work item
        mlxsw: spectrum_dpipe: Add missing error path
        mlxsw: core: Add validation of hardware device types for MGPIR register
        mlxsw: spectrum_router: Clear offload indication from IPv6 nexthops on abort
        selftests: mlxsw: Add test cases for local table route replacement
        mlxsw: spectrum_router: Prevent incorrect replacement of local table routes
        net: dsa: microchip: enable module autoprobe
        ipv6/addrconf: fix potential NULL deref in inet6_set_link_af()
        dpaa_eth: support all modes with rate adapting PHYs
        net: stmmac: update pci platform data to use phy_interface
        net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter
        net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter
        ...
      291abfea
  6. 08 Feb, 2020 2 commits