1. 05 May, 2019 15 commits
  2. 04 May, 2019 25 commits
    • Eelco Chaudron's avatar
      net: openvswitch: return an error instead of doing BUG_ON() · a734d1f4
      Eelco Chaudron authored
      For all other error cases in queue_userspace_packet() the error is
      returned, so it makes sense to do the same for these two error cases.
      Reported-by: default avatarDavide Caratti <dcaratti@redhat.com>
      Signed-off-by: default avatarEelco Chaudron <echaudro@redhat.com>
      Acked-by: default avatarFlavio Leitner <fbl@sysclose.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a734d1f4
    • Heiner Kallweit's avatar
      r8169: remove rtl_write_exgmac_batch · 3aa4c491
      Heiner Kallweit authored
      rtl_write_exgmac_batch is used in only one place, so we can remove it.
      Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3aa4c491
    • David S. Miller's avatar
      Merge branch 'netlink-strict-attribute-checking-follow-up' · 8cca3397
      David S. Miller authored
      Michal Kubecek says:
      
      ====================
      netlink: strict attribute checking follow-up
      
      Three follow-up patches for recent strict netlink validation series.
      
      Patch 1 fixes dump handling for genetlink families which validate and parse
      messages themselves (e.g. because they need different policies for diferent
      commands).
      
      Patch 2 sets bad_attr in extack in one place where this was omitted.
      
      Patch 3 adds new NL_VALIDATE_NESTED flags for strict validation to enable
      checking that NLA_F_NESTED value in received messages matches expectations
      and includes this flag in NL_VALIDATE_STRICT. This would change userspace
      visible behavior but the previous switching to NL_VALIDATE_STRICT for new
      code is still only in net-next at the moment.
      
      v2: change error messages to mention NLA_F_NESTED explicitly
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8cca3397
    • Michal Kubecek's avatar
      netlink: add validation of NLA_F_NESTED flag · b424e432
      Michal Kubecek authored
      Add new validation flag NL_VALIDATE_NESTED which adds three consistency
      checks of NLA_F_NESTED_FLAG:
      
        - the flag is set on attributes with NLA_NESTED{,_ARRAY} policy
        - the flag is not set on attributes with other policies except NLA_UNSPEC
        - the flag is set on attribute passed to nla_parse_nested()
      Signed-off-by: default avatarMichal Kubecek <mkubecek@suse.cz>
      
      v2: change error messages to mention NLA_F_NESTED explicitly
      Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b424e432
    • Michal Kubecek's avatar
      netlink: set bad attribute also on maxtype check · d54a16b2
      Michal Kubecek authored
      The check that attribute type is within 0...maxtype range in
      __nla_validate_parse() sets only error message but not bad_attr in extack.
      Set also bad_attr to tell userspace which attribute failed validation.
      Signed-off-by: default avatarMichal Kubecek <mkubecek@suse.cz>
      Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d54a16b2
    • Michal Kubecek's avatar
      genetlink: do not validate dump requests if there is no policy · 05d7f547
      Michal Kubecek authored
      Unlike do requests, dump genetlink requests now perform strict validation
      by default even if the genetlink family does not set policy and maxtype
      because it does validation and parsing on its own (e.g. because it wants to
      allow different message format for different commands). While the null
      policy will be ignored, maxtype (which would be zero) is still checked so
      that any attribute will fail validation.
      
      The solution is to only call __nla_validate() from genl_family_rcv_msg()
      if family->maxtype is set.
      
      Fixes: ef6243ac ("genetlink: optionally validate strictly/dumps")
      Signed-off-by: default avatarMichal Kubecek <mkubecek@suse.cz>
      Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      05d7f547
    • David S. Miller's avatar
      Merge branch 'mlxsw-Firmware-version-update' · 5eabc27d
      David S. Miller authored
      Ido Schimmel says:
      
      ====================
      mlxsw: Firmware version update
      
      This patchset updates mlxsw to use a new firmware version and adds
      support for split into two ports on Spectrum-2 based systems.
      
      Patch #1 updates the firmware version to 13.2000.1122
      
      Patch #2 queries new resources from the firmware.
      
      Patch #3 makes use of these resources in order to support split into two
      ports on Spectrum-2 based systems. The need for these resources is
      explained by Shalom:
      
      When splitting a port, different local ports need to be mapped on different
      systems. For example:
      
      SN3700 (local_ports_in_2x=2):
        * Without split:
            front panel 1   --> local port 1
            front panel 2   --> local port 5
        * Split to 2:
            front panel 1s0 --> local port 1
            front panel 1s1 --> local port 3
            front panel 2   --> local port 5
      
      SN3800 (local_ports_in_2x=1):
        * Without split:
            front panel 1 --> local port 1
            front panel 2 --> local port 3
        * Split to 2:
            front panel 1s0 --> local port 1
            front panel 1s1 --> local port 2
            front panel 2   --> local port 3
      
      The local_ports_in_{1x, 2x} resources provide the offsets from the base
      local ports according to which the new local ports can be calculated.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5eabc27d
    • Shalom Toledo's avatar
      mlxsw: spectrum: split base on local_ports_in_{1x, 2x} resources · fd321c6c
      Shalom Toledo authored
      When splitting a port, different local ports need to be mapped on different
      systems. For example:
      
      SN3700 (local_ports_in_2x=2):
        * Without split:
            front panel 1   --> local port 1
            front panel 2   --> local port 5
        * Split to 2:
            front panel 1s0 --> local port 1
            front panel 1s1 --> local port 3
            front panel 2   --> local port 5
      
      SN3800 (local_ports_in_2x=1):
        * Without split:
            front panel 1 --> local port 1
            front panel 2 --> local port 3
        * Split to 2:
            front panel 1s0 --> local port 1
            front panel 1s1 --> local port 2
            front panel 2   --> local port 3
      
      The local_ports_in_{1x, 2x} resources provide the offsets from the base
      local ports according to which the new local ports can be calculated.
      Signed-off-by: default avatarShalom Toledo <shalomt@mellanox.com>
      Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fd321c6c
    • Shalom Toledo's avatar
      mlxsw: resources: Add local_ports_in_{1x, 2x} · 4fa050d2
      Shalom Toledo authored
      Since the number of local ports in 4x changed between SPC and SPC-2,
      firmware expose new resources that the driver can query.
      Signed-off-by: default avatarShalom Toledo <shalomt@mellanox.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4fa050d2
    • Ido Schimmel's avatar
      mlxsw: Bump firmware version to 13.2000.1122 · 913e89a4
      Ido Schimmel authored
      The new version supports two features that are required by upcoming
      changes in the driver:
      
      * Querying of new resources allowing port split into two ports on
      Spectrum-2 systems
      
      * Querying of number of gearboxes on supported systems such as SN3800
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      913e89a4
    • Tuong Lien's avatar
      tipc: fix missing Name entries due to half-failover · c0b14a08
      Tuong Lien authored
      TIPC link can temporarily fall into "half-establish" that only one of
      the link endpoints is ESTABLISHED and starts to send traffic, PROTOCOL
      messages, whereas the other link endpoint is not up (e.g. immediately
      when the endpoint receives ACTIVATE_MSG, the network interface goes
      down...).
      
      This is a normal situation and will be settled because the link
      endpoint will be eventually brought down after the link tolerance time.
      
      However, the situation will become worse when the second link is
      established before the first link endpoint goes down,
      For example:
      
         1. Both links <1A-2A>, <1B-2B> down
         2. Link endpoint 2A up, but 1A still down (e.g. due to network
            disturbance, wrong session, etc.)
         3. Link <1B-2B> up
         4. Link endpoint 2A down (e.g. due to link tolerance timeout)
         5. Node B starts failover onto link <1B-2B>
      
         ==> Node A does never start link failover.
      
      When the "half-failover" situation happens, two consequences have been
      observed:
      
      a) Peer link/node gets stuck in FAILINGOVER state;
      b) Traffic or user messages that peer node is trying to failover onto
      the second link can be partially or completely dropped by this node.
      
      The consequence a) was actually solved by commit c140eb16 ("tipc:
      fix failover problem"), but that commit didn't cover the b). It's due
      to the fact that the tunnel link endpoint has never been prepared for a
      failover, so the 'l->drop_point' (and the other data...) is not set
      correctly. When a TUNNEL_MSG from peer node arrives on the link,
      depending on the inner message's seqno and the current 'l->drop_point'
      value, the message can be dropped (- treated as a duplicate message) or
      processed.
      At this early stage, the traffic messages from peer are likely to be
      NAME_DISTRIBUTORs, this means some name table entries will be missed on
      the node forever!
      
      The commit resolves the issue by starting the FAILOVER process on this
      node as well. Another benefit from this solution is that we ensure the
      link will not be re-established until the failover ends.
      Acked-by: default avatarJon Maloy <jon.maloy@ericsson.com>
      Signed-off-by: default avatarTuong Lien <tuong.t.lien@dektech.com.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c0b14a08
    • Heiner Kallweit's avatar
      net: phy: improve resuming from hibernation · f24098f8
      Heiner Kallweit authored
      I got an interesting report [0] that after resuming from hibernation
      the link has 100Mbps instead of 1Gbps. Reason is that another OS has
      been used whilst Linux was hibernated. And this OS speeds down the link
      due to WoL. Therefore, when resuming, we shouldn't expect that what
      the PHY advertises is what it did when hibernating.
      Easiest way to do this is removing state PHY_RESUMING. Instead always
      go via PHY_UP that configures PHY advertisement.
      
      [0] https://bugzilla.kernel.org/show_bug.cgi?id=202851Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f24098f8
    • Heiner Kallweit's avatar
      net: phy: improve pause handling · 22c0ef6b
      Heiner Kallweit authored
      When probing the phy device we set sym and asym pause in the "supported"
      bitmap (unless the PHY tells us otherwise). However we don't know yet
      whether the MAC supports pause. Simply copying phy->supported to
      phy->advertising will trigger advertising pause, and that's not
      what we want. Therefore add phy_advertise_supported() that copies all
      modes but doesn't touch the pause bits.
      
      In phy_support_(a)sym_pause we shouldn't set any bits in the supported
      bitmap because we may set a bit the PHY intentionally disabled.
      Effective pause support should be the AND-combined PHY and MAC pause
      capabilities. If the MAC supports everything, then it's only relevant
      what the PHY supports. If MAC supports sym pause only, then we have to
      clear the asym bit in phydev->supported.
      Copy the pause flags only and don't touch the modes, because a driver
      may have intentionally removed a mode from phydev->advertising.
      Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      22c0ef6b
    • Gustavo A. R. Silva's avatar
      net: sched: cls_u32: use struct_size() helper · e512fcf0
      Gustavo A. R. Silva authored
      Make use of the struct_size() helper instead of an open-coded version
      in order to avoid any potential type mistakes, in particular in the
      context in which this code is being used.
      
      So, replace code of the following form:
      
      sizeof(*s) + s->nkeys*sizeof(struct tc_u32_key)
      
      with:
      
      struct_size(s, keys, s->nkeys)
      
      This code was detected with the help of Coccinelle.
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e512fcf0
    • Cong Wang's avatar
      net: add a generic tracepoint for TX queue timeout · 141b6b2a
      Cong Wang authored
      Although devlink health report does a nice job on reporting TX
      timeout and other NIC errors, unfortunately it requires drivers
      to support it but currently only mlx5 has implemented it.
      Before other drivers could catch up, it is useful to have a
      generic tracepoint to monitor this kind of TX timeout. We have
      been suffering TX timeout with different drivers, we plan to
      start to monitor it with rasdaemon which just needs a new tracepoint.
      
      Sample output:
      
        ksoftirqd/1-16    [001] ..s2   144.043173: net_dev_xmit_timeout: dev=ens3 driver=e1000 queue=0
      
      Cc: Eran Ben Elisha <eranbe@mellanox.com>
      Cc: Jiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
      Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
      Reviewed-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      141b6b2a
    • David S. Miller's avatar
      Merge tag 'mlx5-updates-2019-04-30' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux · f3f050a4
      David S. Miller authored
      Saeed Mahameed says:
      
      ====================
      mlx5-updates-2019-04-30
      
      mlx5 misc updates:
      
      1) Bodong Wang and Parav Pandit (6):
         - Remove unused mlx5_query_nic_vport_vlans
         - vport macros refactoring
         - Fix vport access in E-Switch
         - Use atomic rep state to serialize state change
      
      2) Eli Britstein (2):
         - prio tag mode support, added ACLs and replace TC vlan pop with
           vlan 0 rewrite when prio tag mode is enabled.
      
      3) Erez Alfasi (2):
         - ethtool: Add SFF-8436 and SFF-8636 max EEPROM length definitions
         - mlx5e: ethtool, Add support for EEPROM high pages query
      
      4) Masahiro Yamada (1):
         - remove meaningless CFLAGS_tracepoint.o
      
      5) Maxim Mikityanskiy (1):
         - Put the common XDP code into a function
      
      6) Tariq Toukan (2):
         - Turn on HW tunnel offload in all TIRs
      
      7) Vlad Buslov (1):
         - Return error when trying to insert existing flower filter
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f3f050a4
    • David S. Miller's avatar
      Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue · 18af9626
      David S. Miller authored
      Jeff Kirsher says:
      
      ====================
      100GbE Intel Wired LAN Driver Updates 2019-05-02
      
      This series contains updates to the ice driver only.
      
      Anirudh introduces the framework to store queue specific information in
      the VSI queue contexts.  This will allow future changes to update the
      structure to hold queue specific information.
      
      Akeem adds additional check so that if there is no queue to disable when
      attempting to disable a queue, return a configuration error without
      acquiring the lock.  Fixed an issue with non-trusted VFs being able to
      add more than the permitted number of VLANs.
      
      Bruce removes unreachable code and updated the function to return void
      since it would never return anything but success.
      
      Brett provides most of the changes in the series, starting with reducing
      the scope of the error variable used and improved the debug message if
      we fail to configure the receive queue.  Updates the driver to use a
      macro instead of using the same 'for' loop throughout the driver which
      helps with readability.  Fixed an issue where users were led to believe
      they could set rx-usecs-high value, yet the changes to this value would
      not stick because it was not yet implemented to allow changes to this
      value, so implement the missing code to change the value.  Found we had
      unnecessary wait when disabling queues, so remove it.  I,proved a
      wasteful addition operation in our hot path by adding a member to the
      ice_q_vector structure and the necessary changes to use the member which
      stores the calculated vector hardware index.  Refactored the link event
      flow to make it cleaner and more clear.
      
      Maciej updates the array index when stopping transmit rings, so that
      process every ring the VSI, not just the rings in a given transmit
      class.
      
      Paul adds support for setting 52 byte RSS hash keys.
      
      Md Fahad cleaned up a runtime change to the PFINT_OICR_ENA register,
      since the interrupt handlers will handle resetting the bit, if
      necessary.
      
      Tony adds a missing PHY type, which was causing warning message about an
      unrecognized PHY.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      18af9626
    • Gustavo A. R. Silva's avatar
      wimax/i2400m: use struct_size() helper · 70bb13a5
      Gustavo A. R. Silva authored
      Make use of the struct_size() helper instead of an open-coded version
      in order to avoid any potential type mistakes, in particular in the
      context in which this code is being used.
      
      So, replace code of the following form:
      
      sizeof(*tx_msg) + le16_to_cpu(tx_msg->num_pls) * sizeof(tx_msg->pld[0]);
      
      with:
      
      struct_size(tx_msg, pld, le16_to_cpu(tx_msg->num_pls));
      
      This code was detected with the help of Coccinelle.
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      70bb13a5
    • David S. Miller's avatar
      Merge branch 'net-hns3-enhance-capabilities-for-fibre-port' · 504159c3
      David S. Miller authored
      Jian Shen says:
      
      ====================
      net: hns3: enhance capabilities for fibre port
      
      This patchset enhances more capabilities for fibre port,
      include multipe media type identification, autoneg,
      change port speed and FEC encoding.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      504159c3
    • Jian Shen's avatar
      net: hns3: add support for FEC encoding control · 7e6ec914
      Jian Shen authored
      This patch adds support for FEC encoding control, user can change
      FEC mode by command ethtool --set-fec, and get FEC mode by command
      ethtool --show-fec. The fec capability is changed follow the port
      speed. If autoneg on, the user configure fec mode will be overwritten
      by autoneg result.
      Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
      Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7e6ec914
    • Jian Shen's avatar
      net: hns3: add autoneg and change speed support for fibre port · 22f48e24
      Jian Shen authored
      Previously, our driver only supports phydev to autoneg or change
      port speed. This patch adds support for fibre port, driver gets
      media speed capability and autoneg capability from firmware. If
      the media supports multiple speeds, user can change port speed
      with command "ethtool -s <devname> speed xxxx autoneg off duplex
      full". If autoneg on, the user configuration may be overwritten
      by the autoneg result.
      Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
      Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      22f48e24
    • Jian Shen's avatar
      net: hns3: add support for multiple media type · 88d10bd6
      Jian Shen authored
      Previously, we can only identify copper and fiber type, the
      supported link modes of port information are always showing
      SR type. This patch adds support for multiple media types,
      include SR, LR CR, KR. Driver needs to query the media type
      from firmware periodicly, and updates the port information.
      
      The new port information looks like this:
      Settings for eth0:
              Supported ports: [ FIBRE ]
              Supported link modes:   25000baseCR/Full
                                      25000baseSR/Full
                                      1000baseX/Full
                                      10000baseCR/Full
                                      10000baseSR/Full
                                      10000baseLR/Full
              Supported pause frame use: Symmetric
              Supports auto-negotiation: No
              Supported FEC modes: None BaseR
              Advertised link modes:  Not reported
              Advertised pause frame use: No
              Advertised auto-negotiation: No
              Advertised FEC modes: Not reported
              Speed: 10000Mb/s
              Duplex: Full
              Port: FIBRE
              PHYAD: 0
              Transceiver: internal
              Auto-negotiation: off
              Current message level: 0x00000036 (54)
                                     probe link ifdown ifup
              Link detected: yes
      
      In order to be compatible with old firmware which only support
      sfp speed, we remained using the same query command, and kept
      the former logic.
      Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
      Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      88d10bd6
    • Guenter Roeck's avatar
      usbnet: ipheth: Remove unnecessary NULL pointer check · e28441e2
      Guenter Roeck authored
      ipheth_carrier_set() is called from two locations. In
      ipheth_carrier_check_work(), its parameter 'dev' is set with
      container_of(work, ...) and can not be NULL. In ipheth_open(),
      dev is extracted from netdev_priv(net) and dereferenced before
      the call to ipheth_carrier_set(). The NULL pointer check of dev
      in ipheth_carrier_set() is therefore unnecessary and can be removed.
      
      Cc: Gustavo A. R. Silva <garsilva@embeddedor.com>
      Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e28441e2
    • Andrew Lunn's avatar
      net: dsa: mv88e6xxx: Pass interrupt number in platform data · a27415de
      Andrew Lunn authored
      Allow an interrupt number to be passed in the platform data. The
      driver will then use it if not zero, otherwise it will poll for
      interrupts.
      Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a27415de
    • David S. Miller's avatar
      Merge branch 'mv88e6xxx-Disable-ports-to-save-power' · 3b3600ff
      David S. Miller authored
      Andrew Lunn says:
      
      ====================
      mv88e6xxx: Disable ports to save power
      
      Save some power by disabling ports. The first patch fully disables a
      port when it is runtime disabled. The second disables any ports which
      are not used at all.
      
      Depending on configuration strapping, this can lower the temperature
      of an idle switch a few degrees.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3b3600ff