- 12 Oct, 2011 12 commits
-
-
Aaro Koskinen authored
The current mode index should be stored in the device-specific data allocated in probe(). Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
We can get the information from the table with mode index. Signed-off-by:
-
Aaro Koskinen authored
Delete global xgi_video_info and dynamically allocate the data. Signed-off-by:
-
Aaro Koskinen authored
Avoid direct references to global xgi_video_info. This will help changing the data from statically allocated to dynamically allocated. Signed-off-by:
-
Aaro Koskinen authored
Rename struct video_info to xgifb_video_info. Signed-off-by:
-
Aaro Koskinen authored
Add a global variable for the default refresh rate. This is done to get rid of references to xgi_video_info before the probe routine, which should allocate the xgi_video_info dynamically in the future. Signed-off-by:
-
Aaro Koskinen authored
XGIfb_query_VGA_config_space() is used only once during the init and can be replaced with a single PCI configuration space read. Signed-off-by:
-
Aaro Koskinen authored
Move xgi_hw_device_info into xgi_video_info. Signed-off-by:
-
Aaro Koskinen authored
Move fb_info into xgi_video_info. Signed-off-by:
-
Aaro Koskinen authored
Don't access the global xgi_video_info directly in xgifb_remove(). Signed-off-by:
-
Seth Jennings authored
tmem uses hash buckets each with their own rbtree and lock to quickly lookup tmem objects. tmem has TMEM_HASH_BUCKETS (256) buckets per pool. However, because of the way the tmem_oid is generated for frontswap pages, only 16 unique tmem_oids are being generated, resulting in only 16 of the 256 buckets being used. This cause high lock contention for the per bucket locks. This patch changes SWIZ_BITS to include more bits of the offset. The result is that all 256 hash buckets are potentially used resulting in a 95% drop in hash bucket lock contention. Signed-off-by:
Seth Jennings <sjenning@linux.vnet.ibm.com> Acked-by:
Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by:
-
Arend van Spriel authored
With the mainline patch being applied to the wireless-next repository by John Linville this driver is no longer needed under the staging directory. This patch ends its life under the staging tree. Cc: John W. Linville <linville@tuxdriver.com> Signed-off-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
-
- 11 Oct, 2011 28 commits
-
-
Kevin McKinney authored
This patch cleans up several code style issues found in InterfaceMisc.c reported by checkpatch.pl. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This patch removes an assignment from three if conditions. In all three cases, the line of code was attempting to allocate memory, and check if the memory was allocated in the if statement. This issue was reported by checkpatch.pl. Signed-off-by:
-
Kevin McKinney authored
This patch cleans up several code style issues found in InterfaceInit.c reported by checkpatch.pl. Signed-off-by:
-
Kevin McKinney authored
This patch fixes an error where an assignment "=" was being used in an if statement to determine if Firmware was downloaded. This patch removes that assignment, and places it above the if statement. The if statement then evaluates the status to verify if "0" successful, or != 0 failure. Signed-off-by:
-
Kevin McKinney authored
There is a case where an assignment was being done in an if condition. This patch removes the assignment from the if condition and places the assignment above the if statement; thereby improving the readability of the code. Signed-off-by:
-
Kevin McKinney authored
This patch replaces the obsolete variable, __FUNCTION__, that holds the name of the current function with variable, __func__. Signed-off-by:
-
Kevin McKinney authored
This patch cleans up several hundred code style issues found in Misc.c reported by checkpatch.pl. Signed-off-by:
-
Mark Einon authored
Added some more tasks to the TODO list, as highlighted by Francois Romieu <romieu@fr.zoreil.com>. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Mark Einon authored
Remove some unused defines from et1310_mac.c. Signed-off-by:
-
Mark Einon authored
This fixes the following issues: et131x_initpci.c +488 et131x_adjust_link(45) error: we previously assumed 'phydev' could be null. et131x_initpci.c +504 et131x_adjust_link(61) warn: variable dereferenced before check 'phydev' Signed-off-by:
-
Mark Einon authored
This fixes the following warnings: et1310_mac.c:375:44: warning: incorrect type in initializer (different address spaces) et1310_mac.c:382:28: warning: incorrect type in argument 2 (different address spaces) et1310_mac.c:384:31: warning: incorrect type in argument 2 (different address spaces) et131x_initpci.c:555:5: warning: symbol 'et131x_mii_probe' was not declared. Should it be static? et131x_netdev.c:267:5: warning: symbol 'et131x_ioctl' was not declared. Should it be static? et131x_netdev.c:285:5: warning: symbol 'et131x_set_packet_filter' was not declared. Should it be static? et131x_netdev.c:347:6: warning: symbol 'et131x_multicast' was not declared. Should it be static? et131x_netdev.c:420:5: warning: symbol 'et131x_tx' was not declared. Should it be static? et131x_netdev.c:453:6: warning: symbol 'et131x_tx_timeout' was not declared. Should it be static? et131x_netdev.c:511:5: warning: symbol 'et131x_change_mtu' was not declared. Should it be static? et131x_netdev.c:564:5: warning: symbol 'et131x_set_mac_addr' was not declared. Should it be static? Signed-off-by:
-
Mark Einon authored
Removed defines in et131x_version.h and replaced them by actual strings where convinient, or moved them to et131x.h Signed-off-by:
-
Mark Einon authored
Move the pci driver suspend/resume calls up to the driver.pm ops structure, as they are not pci device specific. Thanks to Francois Romieu <romieu@fr.zoreil.com> for pointing this out. Signed-off-by:
-
Mark Einon authored
Removing an error path from et131x suspend/resume functions. Also added a call to phy_stop() to complement the phy_start() call during device start/stop routine. Thanks to Francois Romieu <romieu@fr.zoreil.com> for pointing this out. Signed-off-by:
-
Mark Einon authored
On 3 October 2011 18:51, Uwe Ranft <uwe.ranft@telozo.com> wrote: > Hello, > olaf is not more longer owner of this e-mailadress. he has left our > company. > Please remove olaf fron the mailing list! > Best Regards > Uwe Signed-off-by:
-
Larry Finger authored
Array XGrpKey has only 2 elements and uses (keyid - 1) as the index, which allows the possibility of memory corruption from an out-of-bounds index. This problem was reported by a new version of smatch. Reported-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Seth Jennings authored
In the case that a cpu is taken offline before zcache_do_preload() is ever called on the cpu, the per-cpu zcache_preloads structure will be uninitialized. In the CPU_DEAD case for zcache_cpu_notifier(), kp->obj is not checked before calling kmem_cache_free() on it. If it is NULL, a crash results. This patch ensures that both kp->obj and kp->page are not NULL before calling the respective free functions. In practice, just checking one or the other should be sufficient since they are assigned together in zcache_do_preload(), but I check both for safety. Signed-off-by:
Dave Hansen <dave@linux.vnet.ibm.com> Signed-off-by:
-
Dan Carpenter authored
The '!' is dead code that was left over from a previous version. It causes a compiler warning: drivers/staging/dt3155v4l/dt3155v4l.c:335:3: warning: value computed is not used Signed-off-by:
-
Thomas Petazzoni authored
Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Lars-Peter Clausen authored
Commit c6fc8062 ("staging:iio: ABI rework - add in_ or out_ prefix to channnels") added the AD5868_CHANNEL macro to simplify channel initialization. Unfortunately the macro hardcodes the channel's address to AD5686_ADDR_DAC0. As a result writing to any of the channels will change the value of the first channel. This patch fixes the issue by calculating the channel address based on the channel number. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. Signed-off-by:
-
Jonathan Cameron authored
Again, there is a mix of the two names for the struct iio_dev. Lets pick one and run with it. Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. This patch covers the core. Others will clean up the drivers. Signed-off-by:
-
Dan Carpenter authored
The error_ret label should have been before the mutex_unlock(). It's a typo. Signed-off-by:
-
Dan Carpenter authored
This fixes a compile warning: drivers/staging/iio/light/tsl2563.c:696:2: warning: initialization from incompatible pointer type [enabled by default] drivers/staging/iio/light/tsl2563.c:696:2: warning: (near initialization for ‘tsl2563_info.write_event_value’) [enabled by default] The tsl2563_write_thresh() function returns zero on success and error codes on failure, so nothing is lost by making the return type int instead of ssize_t. Signed-off-by:
-
Dan Carpenter authored
We need to unlock here before returning. Signed-off-by:
-
Greg Kroah-Hartman authored
This is only used/needed by the vmbus core code, so move it out of the hyperv.h file and into the .c file that uses it. Signed-off-by:
-
