- 20 Feb, 2016 40 commits
-
-
Eva Rachel Retuya authored
Add spaces around operators to improve readability and to address the checkpatch issue: CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Eva Rachel Retuya authored
Use a combination of tabs and spaces to align parameters to its corresponding open parenthesis. Checkpatch found this issue. Signed-off-by:
-
Eva Rachel Retuya authored
Rewrite the multiple assignments to clear checkpatch check: CHECK: multiple assignments should be avoided Signed-off-by:
-
Eva Rachel Retuya authored
Address checkpatch check pointing out the lack of space around the operator '*'. Signed-off-by:
-
Eva Rachel Retuya authored
Add the trailing */ accordingly to suit the preferred way of placing block comments. Signed-off-by:
-
Eva Rachel Retuya authored
Remove the unneeded space as pointed out by checkpatch: CHECK: No space is necessary after a cast Signed-off-by:
-
Eva Rachel Retuya authored
Indent the parameters to match open parenthesis as suggested by checkpatch. Signed-off-by:
-
Janani Ravichandran authored
This patch removes the unnecessary else following an if block with a goto statement. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Acked-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove unnecessary test condition on ret variable which has been previously tested and returns its value if the value is non zero. This fixes the following smatch warnings: drivers/staging/iio/adc/ad7816.c:299 ad7816_set_oti() warn: we tested 'ret' before and it was 'false' drivers/staging/iio/adc/ad7816.c:306 ad7816_set_oti() warn: we tested 'ret' before and it was 'false' Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by:
-
Bhumika Goyal authored
Using typedef for a structure type is not suggested in Linux kernel coding style guidelines. So remove typedefs from structures wilc_sdio_t, wilc_spi_t and wilc_mac_cfg_t. Also remove '_t' suffix from the struct names by hand. The following semantic patch detects cases: @tn1@ type td; @@ typedef struct { ... } td; @script:python tf@ td << tn1.td; tdres; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
This patch removes the function WILC_WFI_update_stats as it is not used anywhere in the kernel. Also remove its declaration from the header file. Grepped to find the occurences. Signed-off-by:
-
Bhumika Goyal authored
This patch gets rid of struct typedef lstcon_session_t as it is not suggested to use typdefs for structure types. Also drop '_t' from the name. Signed-off-by:
-
Amitoj Kaur Chawla authored
This patch fixes the following checkpatch.pl warning: "WARNING: __packed is preferred over __attribute__((packed))". Signed-off-by:
-
Janani Ravichandran authored
Remove unnecessary else following an if block with a goto statement. Signed-off-by:
-
Janani Ravichandran authored
Else is unnecessary when there is a return statement in the corresponding if block. Coccinelle patch used: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by: -
Bhumika Goyal authored
Assignments in function call arguments are undesirable. So pull such assignments out before function call. Made a coccinelle script to detect such cases: @@ expression fn,b,d; @@ * fn(...,d=b,...); Signed-off-by:
-
Amitoj Kaur Chawla authored
Declare osc_cleanup() function and osc_obd_ops structure as static since they are defined and called only in this file. Removed osc_cleanup() function prototype since it wasn't required. This fixes the following sparse warnings: drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning: symbol 'osc_cleanup' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning: symbol 'osc_obd_ops' was not declared. Should it be static? Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Amitoj Kaur Chawla authored
Declare lustre_mount() function static since it is defined and called in this file only. This fixes the following sparse warning: drivers/staging/lustre/lustre/obdclass/obd_mount.c:1169:15: warning: symbol 'lustre_mount' was not declared. Should it be static? Signed-off-by:
-
Shalin Mehta authored
The parentehsis are fixed in the macro for the ldlm lock to set and clear the flags. Signed-off-by:
Shalin Mehta <shalinmehta85@gmail.com> Acked-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Oleg Drokin authored
simple_strtoul is obsolete Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
simple_strtoul is obsolete Signed-off-by:
-
Oleg Drokin authored
This is against kernel-code style. Signed-off-by:
-
Oleg Drokin authored
They make checkpatch unhappy, and I guess overall might confuse people too. Signed-off-by:
-
Oleg Drokin authored
Replace it with enum cfs_trace_buf_type Signed-off-by:
-
Oleg Drokin authored
We do really mean to fall through to that default case statement from all previous ones, so add a comment to unconfuse verious tools Signed-off-by:
-
Oleg Drokin authored
No need for an empty line after opening curvy brace and no need for an empty line before the closing one too. Remove them. Signed-off-by:
-
Oleg Drokin authored
Return at the end of a void function does not serve any particular purpose and makes checkpatch unhappy, so eliminate them. Signed-off-by:
-
Oleg Drokin authored
checkpatch complains that the trailing */ on the multiline comments should be on it's own line. Signed-off-by:
-
Oleg Drokin authored
the struct page_collection, struct cfs_trace_page and struct tracefiled_ctl are only used by tracefile.c, so move them there. Signed-off-by:
-
Oleg Drokin authored
Does not appear to be used anywhere. Signed-off-by:
-
Oleg Drokin authored
Lines that were too long for not good reason were shortened in this patch. Found with checkpatch. Signed-off-by:
-
Oleg Drokin authored
Problem highlighted by checkpatch. Signed-off-by:
-
Oleg Drokin authored
Avoid using leading spaces that make checkpatch unhappy. Signed-off-by:
-
Oleg Drokin authored
This fixes checkpatch messages about "spaces preferred around that '-' (ctx:VxV)" Signed-off-by:
-
Oleg Drokin authored
Found with checkpatch Signed-off-by:
-
Oleg Drokin authored
Adjust alignment of argments that were pushed to next lines to conform to kernel code style. Found with checkpatch. Signed-off-by:
-
Oleg Drokin authored
Checkpatch highlighted that some of our Lustre files carry this extra paragraph and indeed it does seem somewhat redundant, so remove it. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
