- 02 Mar, 2015 11 commits
-
-
Aya Mahfouz authored
This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by:Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aya Mahfouz authored
This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: -
Aya Mahfouz authored
This patch removes variables that were simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: -
Aya Mahfouz authored
This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: -
Yeliz Taneroglu authored
drivers/staging/rtl8723au/core/rtw_cmd.c warning: space prohibited before semicolon Signed-off-by:
Yeliz Taneroglu <yeliztaneroglu@gmail.com> Signed-off-by:
-
Navya Sri Nizamkari authored
The memory area set by the call to memset is immediately overwritten by the subsequent call to memcpy. Hence, remove that redundant memset. Signed-off-by:
Navya Sri Nizamkari <navyasri.tech@gmail.com> Signed-off-by:
-
Navya Sri Nizamkari authored
This patch removes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by:
-
Navya Sri Nizamkari authored
This patch removes the use of a variable used only for returning a value. The following coccinelle script was used to discover it: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; It also fixes the checkpatch.pl warning about line being over 80 characters, in the lines where changes were made. Signed-off-by: -
Vatika Harlalka authored
Remove unused variable assignment for is2t and assign sim_bitmap at declaration to make the code more compact. Signed-off-by:
Vatika Harlalka <vatikaharlalka@gmail.com> Signed-off-by:
-
Aya Mahfouz authored
This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: -
Vatika Harlalka authored
Variable path_on is assigned explicitly in the if branch and so its assignment outside can be moved to the else branch. Signed-off-by:
-
- 01 Mar, 2015 11 commits
-
-
Vatika Harlalka authored
Remove braces from single statement if condition to follow kernel coding convention. Signed-off-by:
-
Hatice ERTÜRK authored
Insert missing space before '=' to improve readability. This Error found with checkpatch.pl Signed-off-by:
Hatice ERTURK <haticeerturk27@gmail.com> Signed-off-by:
-
Hatice ERTÜRK authored
Insert missing space before '|' to improve readability. This Error found with checkpatch.pl Signed-off-by:
-
Hatice ERTÜRK authored
This patch fixes these error messages found by checkpatch.pl: ERROR: "foo* bar" should be "foo *bar" Signed-off-by:
-
Navya Sri Nizamkari authored
This patch uses kasprintf as it combines kmalloc and sprintf, and takes care of the size calculation itself. The semantic patch that makes this change is as follows: // <smpl> @@ expression a,flag; expression list args; statement S; @@ a = - \(kmalloc\|kzalloc\)(...,flag) + kasprintf(flag,args) <... when != a if (a == NULL || ...) S ...> - sprintf(a,args); Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Cristina Opriceana authored
This patch replaces printk() with dev_dbg() in order to avoid the suggestion of using a more specific function while printing debug information. Warning found by checkpatch.pl. Signed-off-by:
Cristina Opriceana <cristina.opriceana@gmail.com> Reviewed-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Cristina Opriceana authored
This patch fixes the following checkpatch.pl warning: WARNING: Prefer [subsystem eg: netdev]_err over printk(KERN_ERR, ...). Signed-off-by:
-
Aya Mahfouz authored
This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: -
Yeliz Taneroglu authored
Fix checkpatch.pl issues with do not use C99 // comments in key.h Signed-off-by:
-
Dilek Uzulmez authored
This patch fixes "quoted string split across lines warning" warning in exec-osm.c Signed-off-by:
Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by:
-
Katie Dunne authored
Addresses checkpatch.pl check: CHECK: Extern prototypes should be avoided in .h files Removes the 'extern' keyword from function prototypes Signed-off-by:
Katie Dunne <kdunne@mail.ccsf.edu> Signed-off-by:
-
- 27 Feb, 2015 17 commits
-
-
Jean Delvare authored
I find the Kconfig dependencies of the various Unisys drivers rather confusing. Due to the dependencies, you must select the drivers one by one to see the following ones. So if you are looking for a specific driver, it is not visible by default. And if you don't know exactly what you need, it's even worse as you don't know what is available. In a case like this with several helper drivers and many dependencies, I think it makes more sense to list all the drivers at first, and use select statements to fulfill the dependencies for the user. As a nice side effect, it avoids the weird indentation, which was technically correct but still somewhat confusing. I also dropped the dependencies on HAS_IOMEM, as the whole driver set is for X86_64 only anyway which always has HAS_IOMEM set. And I dropped the redundant dependencies on UNISYSSPAR as all drivers are already inside an "if UNISYSSPAR" block. Signed-off-by:
Jean Delvare <jdelvare@suse.de> Cc: Benjamin Romer <benjamin.romer@unisys.com> Cc: David Kershner <david.kershner@unisys.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Devendra Naga authored
remove the should_stop variable and KILL API as they are no longer required Cc: Ken Cox <jkc@redhat.com> Cc: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
Devendra Naga <devendra.aaru@gmail.com> Signed-off-by:
-
Devendra Naga authored
convert the users of should_stop into using kthread_should_stop API. Cc: Ken Cox <jkc@redhat.com> Cc: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Devendra Naga authored
convert the users of should_stop variable into kthread_should_stop() API. Cc: Ken Cox <jkc@redhat.com> Cc: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Devendra Naga authored
The code does the checks on should_stop variable in the kernel threads. The uisthread_stop function sets the should_stop and calls KILL (eventually kill_pid) to stop the thread. The checking of should_stop variable can be replaced to a call to kthread_should_stop function and the setting of the should_stop and a call to KILL can be replaced with kthread_stop function. Cc: Ken Cox <jkc@redhat.com> Cc: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Devendra Naga authored
kthread_run calls kthread_create and if the thread is created it then calls wake_up_process on the corresponding returned task struct. So the code can be simplified by calling just kthread_run. Cc: Ken Cox <jkc@redhat.com> Cc: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Quentin Lambert authored
This patch reduces the kernel size by removing error messages that duplicate the normal OOM message. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @@ identifier f,print,l; expression e; constant char[] c; @@ e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(...); if (e == NULL) { <+... - print(...,c,...); ... when any ( goto l; | return ...; ) ...+> } Signed-off-by:
Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by:
-
Frederico Cadete authored
Signed-off-by:
Frederico Cadete <frederico@cadete.eu> Signed-off-by:
-
Frederico Cadete authored
Signed-off-by:
-
Frederico Cadete authored
Signed-off-by:
-
Frederico Cadete authored
This symbol is not exported nor referenced anywhere else in the kernel. Signed-off-by:
-
Sudip Mukherjee authored
these functions are not being used anywhere.so we can remove them. has been verified by "git grep" that they are not being referenced anywhere also has been build tested. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Quentin Lambert authored
This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by:
-
Sudip Mukherjee authored
we were getting three warnings about timskmod and sparstopdriver and channels. These warnings were about no such file or directory. These directory names were included in the Makefile, but the directories were not existing. Signed-off-by:
-
Sudip Mukherjee authored
we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the value assigned to it was never used. Signed-off-by:
-
Haneen Mohammed authored
This patch updates kconfig with paragraphs that describe config symbol fully. Issue addressed by checkpatch.pl warning. Signed-off-by:
Haneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by:
-
Aya Mahfouz authored
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) The changes were applied using the following coccinelle rule: @@ expression e1, e2; @@ - memcpy(e1, e2, ETH_ALEN); + ether_addr_copy(e1, e2); All variables defined in vnt_mac_set_key start at even offsets making the variables aligned to the u16 datatype. Signed-off-by:
-
- 26 Feb, 2015 1 commit
-
-
Ksenija Stanojevic authored
For dynamic debugging netdev_dbg(), dev_dbg() or pr_debug() macro is preferred over printk(), which is the raw way to print something. Network system has it's own printk format, netdev_dbg, but in this case function's argument list has no pointer to a struct netdevice so pr_debug is used instead. Issue found by checkpatch.pl. Signed-off-by:
Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by:
-
