• Teemu Ollakka's avatar
    10.4 wsrep group commit fixes (#1224) · 1ef50a34
    Teemu Ollakka authored
    * MDEV-16509 Improve wsrep commit performance with binlog disabled
    
    Release commit order critical section early after trx_commit_low() if
    binlog is not transaction coordinator. In order to avoid two phase commit,
    binlog_hton is not registered for THD during IO_CACHE population.
    
    Implemented a test which verifies that the transactions release
    commit order early.
    
    This optimization will change behavior during recovery as the commit
    is not two phase when binlog is off. Fixed and recorded wsrep-recover-v25
    and wsrep-recover to match the behavior.
    
    * MDEV-18730 Ordering for wsrep binlog group commit
    
    Previously out of order execution was allowed for wsrep commits.
    Established proper ordering by populating wait_for_commit
    for every wsrep THD and making group commit leader to wait for
    prior commits before proceeding to trx_group_commit_leader().
    
    * MDEV-18730 Added a test case to verify correct commit ordering
    
    * MDEV-16509, MDEV-18730 Review fixes
    
    Use WSREP_EMULATE_BINLOG() macro to decide if the binlog_hton
    should be registered. Whitespace/syntax fixes and cleanups.
    
    * MDEV-16509 Require binlog for galera_var_innodb_disallow_writes test
    
    If the commit to InnoDB is done in one phase, the native InnoDB behavior
    is that the transaction is committed in memory before it is persisted to
    disk. This means that the innodb_disallow_writes=ON may not prevent
    transaction to become visible to other readers before commit is completely
    over. On the other hand, if the commit is two phase (as it is with binlog),
    the transaction will be blocked in prepare phase.
    
    Fixed the test to use binlog, which enforces two phase commit, which
    in turn makes commit to block before the changes become visible to
    other connections. This guarantees that the test produces expected
    result.
    1ef50a34
trx0trx.cc 60.9 KB