• unknown's avatar
    WL#1596 "make mysqldump --master-data --single-transaction able to do online... · 313ce62f
    unknown authored
    WL#1596 "make mysqldump --master-data --single-transaction able to do online dump of InnoDB AND report reliable
    binlog coordinates corresponding to the dump".
    The good news is that now mysqldump can be used to get an online backup of InnoDB *which works for
    point-in-time recovery and replication slave creation*. Formerly, mysqldump --master-data --single-transaction
    used to call in fact mysqldump --master-data, so the dump was not an online dump (took big lock all time of dump).
    The only lock which is now taken in this patch is at the beginning of the dump: mysqldump does:
    FLUSH TABLES WITH READ LOCK; START TRANSACTION WITH CONSISTENT SNAPSHOT; SHOW MASTER STATUS; UNLOCK TABLES;
    so the lock time is in fact the time FLUSH TABLES WITH READ LOCK takes to return (can be 0 or very long, if
    a table is undergoing a huge update).
    I have done some more minor changes listed in the paragraph of mysqldump.c.
    WL#2237 "WITH CONSISTENT SNAPSHOT clause for START TRANSACTION":
    it's a START TRANSACTION which additionally starts a consistent read on all
    capable storage engine (i.e. InnoDB). So, can serve as a replacement for
    BEGIN; SELECT * FROM some_innodb_table LIMIT 1; which starts a consistent read too. 
    
    
    client/mysqldump.c:
      Main change: mysqldump --single-transaction --master-data is now able to, at the same time,
      take an online dump of InnoDB (using consistent read) AND get the binlog position corresponding to this dump
      (before, using the two options used to silently cancel --single-transaction).
      This uses the new START TRANSACTION WITH CONSISTENT SNAPSHOT syntax.
      Additional changes: 
      a) cleanup:
       - DBerror calls exit() so some code was unneeded
       - no need to call COMMIT at end, leave disconnection do the job
       - mysql_query_with_error_report()
      b) requirements I had heard from colleagues:
       - --master-data now requires an argument, to comment out ("--") the CHANGE MASTER or not
         (commenting had been asked for point-in-time recovery when replication is not necessary).
       - --first-slave is renamed to --lock-all-tables
      c) more sensible behaviours (has been discussed internally):
       - if used with --master-data, --flush-logs is probably intended to get a flush synchronous
         with the dump, not one random flush per dumped db.
       - disabled automatic reconnection as, at least, SQL_MODE would be lost (and also, depending
         on options, LOCK TABLES, BEGIN, FLUSH TABLES WITH READ LOCK).
    include/mysqld_error.h:
      an error if START TRANSACTION WITH CONSISTENT SNAPSHOT is called and there is no consistent-read capable storage engine
      (idea ((C) PeterG) is that it's a bit like CREATE TABLE ENGINE=InnoDB when there is no support for InnoDB).
    sql/handler.cc:
      new ha_start_consistent_snapshot(), which, inside an existing transaction, starts a consistent read
      (offers an alternative to SELECTing any InnoDB table). Does something only for InnoDB.
      Warning if no suitable engine supported.
    sql/handler.h:
      declarations
    sql/lex.h:
      symbols for lex
    sql/share/czech/errmsg.txt:
      new message
    sql/share/danish/errmsg.txt:
      new message
    sql/share/dutch/errmsg.txt:
      new message
    sql/share/english/errmsg.txt:
      new message
    sql/share/estonian/errmsg.txt:
      new message
    sql/share/french/errmsg.txt:
      new message
    sql/share/german/errmsg.txt:
      new message
    sql/share/greek/errmsg.txt:
      new message
    sql/share/hungarian/errmsg.txt:
      new message
    sql/share/italian/errmsg.txt:
      new message
    sql/share/japanese/errmsg.txt:
      new message
    sql/share/korean/errmsg.txt:
      new message
    sql/share/norwegian-ny/errmsg.txt:
      new message
    sql/share/norwegian/errmsg.txt:
      new message
    sql/share/polish/errmsg.txt:
      new message
    sql/share/portuguese/errmsg.txt:
      new message
    sql/share/romanian/errmsg.txt:
      new message
    sql/share/russian/errmsg.txt:
      new message
    sql/share/serbian/errmsg.txt:
      new message
    sql/share/slovak/errmsg.txt:
      new message
    sql/share/spanish/errmsg.txt:
      new message
    sql/share/swedish/errmsg.txt:
      new message
    sql/share/ukrainian/errmsg.txt:
      new message
    sql/sql_lex.h:
      new option in lex (transaction options)
    sql/sql_parse.cc:
      warning comment (never make UNLOCK TABLES commit a transaction, please);
      support for starting consistent snapshot.
    sql/sql_yacc.yy:
      new clause WITH CONSISTENT SNAPSHOT (syntax ok'd by PeterG) for START TRANSACTION.
    313ce62f
errmsg.txt 18 KB