• unknown's avatar
    5.1 version of fix for: · 5698a6a8
    unknown authored
      Bug #23667 "CREATE TABLE LIKE is not isolated from alteration
                  by other connections"
      Bug #18950 "CREATE TABLE LIKE does not obtain LOCK_open"
    As well as:
      Bug #25578 "CREATE TABLE LIKE does not require any privileges
                  on source table".
    
    The first and the second bugs resulted in various errors and wrong
    binary log order when one tried to execute concurrently CREATE TABLE LIKE
    statement and DDL statements on source table or DML/DDL statements on its
    target table.
    
    The problem was caused by incomplete protection/table-locking against
    concurrent statements implemented in mysql_create_like_table() routine.
    We solve it by simply implementing such protection in proper way.
    Most of actual work for 5.1 was already done by fix for bug 20662 and
    preliminary patch changing locking in ALTER TABLE.
    
    The third bug allowed user who didn't have any privileges on table create
    its copy and therefore circumvent privilege check for SHOW CREATE TABLE.
    
    This patch solves this problem by adding privilege check, which was missing.
    
    Finally it also removes some duplicated code from mysql_create_like_table()
    and thus fixes bug #26869 "TABLE_LIST::table_name_length inconsistent with
    TABLE_LIST::table_name".
    
    
    mysql-test/r/create-big.result:
      Added test coverage for concurrency-related issues with CREATE TABLE LIKE.
    mysql-test/r/create.result:
      Adjusted error-code in the test case after refactoring code that
      implements CREATE TABLE ... LIKE.
    mysql-test/r/grant2.result:
      Added test for bug#25578 "CREATE TABLE LIKE does not require any privileges
      on source table".
    mysql-test/t/create-big.test:
      Added test coverage for concurrency-related issues with CREATE TABLE LIKE.
    mysql-test/t/create.test:
      Adjusted error-code in the test case after refactoring code that
      implements CREATE TABLE ... LIKE.
    mysql-test/t/disabled.def:
      Recent code changes ensured that CREATE TABLE LIKE statement is properly
      isolated against other statements, so synchronization.test should no
      longer fail (see fix for bug 20662 and preliminary patch for bug 23667
      changing ALTER TABLE locking).
    mysql-test/t/grant2.test:
      Added test for bug#25578 "CREATE TABLE LIKE does not require any privileges
      on source table".
    sql/handler.h:
      Introduced new flag for HA_CREATE_INFO::options in order to be able to
      distinguish CREATE TABLE ... LIKE from other types of CREATE TABLE.
    sql/mysql_priv.h:
      mysql_create_like_table() now takes source table name not as a
      Table_ident object but as regular table list element.
    sql/sql_lex.h:
      Removed LEX::like_name member. Now we use special flag in
      LEX::create_info::options for distinguishing CREATE TABLE ... LIKE
      from other types of CREATE TABLE and store name of source table as
      regular element in statement's table list.
    sql/sql_parse.cc:
      CREATE TABLE ... LIKE implementation now uses statement's table list
      for storing information about the source table. We also use flag
      in LEX::create_info.options for distinguishing it from other types
      of CREATE TABLE.
      Finally CREATE TABLE ... LIKE now requires the same privileges on
      the source tables as SHOW CREATE TABLE. Moved this privilege check
      to check_show_create_table_access() function.
    sql/sql_partition.cc:
      Now we use special flag in LEX::create_info::options for distinguishing
      CREATE TABLE ... LIKE from other types of CREATE TABLE and store name
      of source table as regular element in statement's table list.
    sql/sql_table.cc:
      mysql_create_like_table():  
       - Commented and cleaned-up a bit code which is responsible for achieving
         isolation from concurrent statements. Most of actual work was done by
         fix for bug 20662 and preliminary patch changing locking locking in
         ALTER TABLE, so here we do minor things like relaxing locking on
         source table (we don't need lock on it, to have it open is enough) and
         adjusting code to make it more friendly against code implementing I_S.
       - Get rid of duplicated code related to source database/table name
         handling. All these operations are already done in
         st_select_lex::add_table_to_list(), so we achieve the same effect
         by including source table into the statement's table list.
    sql/sql_yacc.yy:
      Now we use special flag in LEX::create_info::options for distinguishing
      CREATE TABLE ... LIKE from other types of CREATE TABLE and store name
      of source table as regular element in statement's table list.
    5698a6a8
handler.h 64.9 KB