• Vicențiu Ciorbaru's avatar
    Apply clang-tidy to remove empty constructors / destructors · 08c85202
    Vicențiu Ciorbaru authored
    This patch is the result of running
    run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' .
    
    Code style changes have been done on top. The result of this change
    leads to the following improvements:
    
    1. Binary size reduction.
    * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by
      ~400kb.
    * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb.
    
    2. Compiler can better understand the intent of the code, thus it leads
       to more optimization possibilities. Additionally it enabled detecting
       unused variables that had an empty default constructor but not marked
       so explicitly.
    
       Particular change required following this patch in sql/opt_range.cc
    
       result_keys, an unused template class Bitmap now correctly issues
       unused variable warnings.
    
       Setting Bitmap template class constructor to default allows the compiler
       to identify that there are no side-effects when instantiating the class.
       Previously the compiler could not issue the warning as it assumed Bitmap
       class (being a template) would not be performing a NO-OP for its default
       constructor. This prevented the "unused variable warning".
    08c85202
util.hpp 361 Bytes