• unknown's avatar
    API change: mysql_shutdown() now needs a 2nd parameter, the shutdown level. · aba49a6c
    unknown authored
    Server will however still accept shutdown without specified level; so that old
    mysqladmin can still shut server down.
    I would like your comments on the names of shutdown level which I chose. You
    are welcome to propose better names. Please however check WL#709 before.
    Reason for the names I propose is to be accurate, thus leaving possibility
    for other levels which we may imagine in the future; that's why I have rejected
    names like "fast", "smart", "graceful" so far. My position is that WAIT_ALL_BUFFERS
    or WAIT_CRITICAL_BUFFERS say what the shutdown does, whereas for "smart", "fast" you
    need to remember what it does.
    This should be pushed in 4.1.3 but only after your comments.
    
    
    client/mysqladmin.c:
      2nd parameter for mysql_shutdown()
    include/mysql.h:
      2nd paramater for mysql_shutdown()
    include/mysql_com.h:
      4 types of shutdown
    libmysql/libmysql.c:
      passing the requested shutdown level
    sql/sql_parse.cc:
      check for the shutdown level in dispatch_command(). Though its value is ignored for now.
    tools/mysqlmanager.c:
      2nd parameter to mysql_shutdown
    aba49a6c
mysqladmin.c 32.6 KB